After M72 branch, it should be OK to remove the old Print preview UI, which resides at [1], along with the new UI (which is under new/). [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21ef7349026004d6006dfcb55264b46d15babbc6 commit 21ef7349026004d6006dfcb55264b46d15babbc6 Author: rbpotter <rbpotter@chromium.org> Date: Sat Dec 01 01:31:19 2018 Print Preview: Remove pre-Web Components UI Removes the pre-Web Components Print Preview UI and the NewPrintPreview flag. Bug: 908705 Change-Id: Ia80a1d6576ede3f3866dd647b8df6fa1a8f82d25 Reviewed-on: https://chromium-review.googlesource.com/c/1356329 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612893} [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/browser/about_flags.cc [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/browser/browser_resources.grd [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/browser/flag_descriptions.h [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/browser/resources/print_preview/BUILD.gn [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/common/overlay.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/common/search_box.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/common/search_box.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/common/search_box.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/common/search_bubble.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/common/search_bubble.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/component.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/1x/minus.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/1x/plus.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/1x/printer.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/1x/printer_shared.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/2x/minus.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/2x/plus.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/2x/printer.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/2x/printer_shared.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/cloud.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/google_doc.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/mobile.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/mobile_shared.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/pdf.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/images/search.png [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/preview_generator.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/previewarea/margin_control.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/previewarea/margin_control.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/previewarea/margin_control.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/previewarea/margin_control_container.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/previewarea/margin_control_container.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/previewarea/preview_area.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/previewarea/preview_area.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/previewarea/preview_area.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/print_header.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/print_header.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/print_header.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/print_preview.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/print_preview.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/print_preview.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/print_preview_animations.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/print_preview_focus_manager.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/destination_list.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/destination_list.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/destination_list.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/destination_list_item.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/destination_list_item.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/destination_list_item.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/destination_search.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/destination_search.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/destination_search.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/provisional_destination_resolver.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/provisional_destination_resolver.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/provisional_destination_resolver.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/search/recent_destination_list.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/advanced_options_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/advanced_options_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/advanced_options_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/color_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/color_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/color_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/copies_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/copies_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/destination_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/destination_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/destination_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/dpi_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/dpi_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/dpi_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/layout_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/layout_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/layout_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/margin_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/margin_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/margin_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/media_size_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/media_size_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/media_size_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/more_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/more_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/more_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/other_options_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/other_options_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/page_settings.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/page_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/page_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/scaling_settings.html [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/scaling_settings.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/settings_box.css [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/settings_section.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/browser/resources/print_preview/settings/settings_section_select.js [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/browser/ui/webui/print_preview/print_preview_ui.cc [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/common/chrome_features.cc [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/common/chrome_features.h [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/test/data/webui/BUILD.gn [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/test/data/webui/print_preview/print_preview_tests.js [delete] https://crrev.com/09489a7f4d6727c8c0cfe72eb8032eccc478c051/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js [modify] https://crrev.com/21ef7349026004d6006dfcb55264b46d15babbc6/testing/buildbot/filters/webui_polymer2_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/caa80875fabc1c14da309555f837888efc26aa89 commit caa80875fabc1c14da309555f837888efc26aa89 Author: rbpotter <rbpotter@chromium.org> Date: Mon Dec 03 21:50:24 2018 Print Preview: Finish deletion, remove unused strings - Delete ticket items and other unused files in data/ - Complete TODOs in handler - Remove unused strings Bug: 908705 Change-Id: Ie02a00ad6b8ada56b3d327d75e2ad841e534cb9f Reviewed-on: https://chromium-review.googlesource.com/c/1357527 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#613267} [modify] https://crrev.com/caa80875fabc1c14da309555f837888efc26aa89/chrome/app/printing_strings.grdp [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/app_state.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/capabilities_holder.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/page_number_set.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/print_ticket_store.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/collate.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/color.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/copies.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/css_background.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/custom_margins.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/dpi.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/duplex.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/fit_to_page.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/header_footer.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/landscape.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/margins_type.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/media_size.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/page_range.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/rasterize.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/scaling.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/selection_only.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/ticket_item.js [delete] https://crrev.com/c8ce1331aa0e3273c5c35d389a78ebb32247b38a/chrome/browser/resources/print_preview/data/ticket_items/vendor_items.js [modify] https://crrev.com/caa80875fabc1c14da309555f837888efc26aa89/chrome/browser/resources/print_preview/native_layer.js [modify] https://crrev.com/caa80875fabc1c14da309555f837888efc26aa89/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/caa80875fabc1c14da309555f837888efc26aa89/chrome/browser/ui/webui/print_preview/print_preview_handler.h [modify] https://crrev.com/caa80875fabc1c14da309555f837888efc26aa89/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e444634d69b43c5f9b3833330cf5d6561ee4534a commit e444634d69b43c5f9b3833330cf5d6561ee4534a Author: rbpotter <rbpotter@chromium.org> Date: Sat Jan 05 01:11:24 2019 Print Preview cleanup: Remove some unused utils functions - Remove utils functions that are now unused due to deletion of old UI - Remove arrayContains usage in favor of Array.includes - Remove utils unittests. Page range tests have been migrated to chrome/test/data/webui/print_preview/pages_settings_test.js. Bug: 908705 Change-Id: I832bbfd095e8ab671fa71300fef554f49fcf512f Reviewed-on: https://chromium-review.googlesource.com/c/1396682 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#620137} [modify] https://crrev.com/e444634d69b43c5f9b3833330cf5d6561ee4534a/chrome/browser/resources/print_preview/data/cloud_parsers.js [modify] https://crrev.com/e444634d69b43c5f9b3833330cf5d6561ee4534a/chrome/browser/resources/print_preview/data/destination.js [modify] https://crrev.com/e444634d69b43c5f9b3833330cf5d6561ee4534a/chrome/browser/resources/print_preview/data/destination_match.js [modify] https://crrev.com/e444634d69b43c5f9b3833330cf5d6561ee4534a/chrome/browser/resources/print_preview/print_preview_utils.js [delete] https://crrev.com/8942ec06dcb917f36df5c217dfd6c2d72b7ceb2a/chrome/browser/resources/print_preview/print_preview_utils_unittest.gtestjs [modify] https://crrev.com/e444634d69b43c5f9b3833330cf5d6561ee4534a/chrome/test/data/webui/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d05c56e17bb3f85dd3cb7511bd67cd3b853c6cd6 commit d05c56e17bb3f85dd3cb7511bd67cd3b853c6cd6 Author: Max Morin <maxmorin@chromium.org> Date: Mon Jan 07 10:35:27 2019 Revert "Print Preview cleanup: Remove some unused utils functions" This reverts commit e444634d69b43c5f9b3833330cf5d6561ee4534a. Reason for revert: https://crbug.com/919437 Original change's description: > Print Preview cleanup: Remove some unused utils functions > > - Remove utils functions that are now unused due to deletion of old UI > - Remove arrayContains usage in favor of Array.includes > - Remove utils unittests. Page range tests have been migrated to > chrome/test/data/webui/print_preview/pages_settings_test.js. > > Bug: 908705 > Change-Id: I832bbfd095e8ab671fa71300fef554f49fcf512f > Reviewed-on: https://chromium-review.googlesource.com/c/1396682 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620137} TBR=dpapad@chromium.org,rbpotter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 908705 , 919437 Change-Id: I22b869cd7a5172234e6432aa62c9cc91e12cf926 Reviewed-on: https://chromium-review.googlesource.com/c/1397622 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#620284} [modify] https://crrev.com/d05c56e17bb3f85dd3cb7511bd67cd3b853c6cd6/chrome/browser/resources/print_preview/data/cloud_parsers.js [modify] https://crrev.com/d05c56e17bb3f85dd3cb7511bd67cd3b853c6cd6/chrome/browser/resources/print_preview/data/destination.js [modify] https://crrev.com/d05c56e17bb3f85dd3cb7511bd67cd3b853c6cd6/chrome/browser/resources/print_preview/data/destination_match.js [modify] https://crrev.com/d05c56e17bb3f85dd3cb7511bd67cd3b853c6cd6/chrome/browser/resources/print_preview/print_preview_utils.js [add] https://crrev.com/d05c56e17bb3f85dd3cb7511bd67cd3b853c6cd6/chrome/browser/resources/print_preview/print_preview_utils_unittest.gtestjs [modify] https://crrev.com/d05c56e17bb3f85dd3cb7511bd67cd3b853c6cd6/chrome/test/data/webui/BUILD.gn
Comment 1 by dpa...@chromium.org
, Nov 27