Allow viewing USZD format 3D models using AR Quick Look (Tracking Bug) |
|||||||||
Issue descriptionEnable viewing USDZ format AR models in Bling using AR Quick Look, available in iOS 12.
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18a250971b1cc0a556f081ebdeaac81b099671b1 commit 18a250971b1cc0a556f081ebdeaac81b099671b1 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Nov 29 01:24:12 2018 [AR][IOS] Creates a ARQuickLookTabHelper to download USDZ format files. - Integrates ARQuickLookTabHelper in BrowserDownloadService in order to handle downloading USDZ format files. Bug: 908696 Change-Id: I977e1609d02e6f14e7f84d9d2fba5b4cce96e76e Reviewed-on: https://chromium-review.googlesource.com/c/1352120 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#611978} [modify] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/browser/download/BUILD.gn [add] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/browser/download/ar_quick_look_tab_helper.h [add] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/browser/download/ar_quick_look_tab_helper.mm [add] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/browser/download/ar_quick_look_tab_helper_delegate.h [add] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/browser/download/ar_quick_look_tab_helper_unittest.mm [add] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/browser/download/usdz_mime_type.cc [add] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/browser/download/usdz_mime_type.h [modify] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/test/fakes/BUILD.gn [add] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/test/fakes/fake_ar_quick_look_tab_helper_delegate.h [add] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/ios/chrome/test/fakes/fake_ar_quick_look_tab_helper_delegate.mm [modify] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/tools/metrics/histograms/enums.xml [modify] https://crrev.com/18a250971b1cc0a556f081ebdeaac81b099671b1/tools/metrics/histograms/histograms.xml
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41118a8b24359a22695491cb11a8fe4c2a122fb8 commit 41118a8b24359a22695491cb11a8fe4c2a122fb8 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri Nov 30 01:57:07 2018 [AR][IOS] Creates a ARQuickLookCoordinator to display USDZ format files. - Creates a ARQuickLookCoordinator as the ARQuickLookTabHelperDelegate that presents a QLPreviewController in order to display USDZ format files. Bug: 908696 Change-Id: I7cee24392cd7133aa23127dd991b51694fabadfa Reviewed-on: https://chromium-review.googlesource.com/c/1353048 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612510} [modify] https://crrev.com/41118a8b24359a22695491cb11a8fe4c2a122fb8/ios/chrome/browser/download/ar_quick_look_tab_helper.mm [modify] https://crrev.com/41118a8b24359a22695491cb11a8fe4c2a122fb8/ios/chrome/browser/ui/download/BUILD.gn [add] https://crrev.com/41118a8b24359a22695491cb11a8fe4c2a122fb8/ios/chrome/browser/ui/download/ar_quick_look_coordinator.h [add] https://crrev.com/41118a8b24359a22695491cb11a8fe4c2a122fb8/ios/chrome/browser/ui/download/ar_quick_look_coordinator.mm [add] https://crrev.com/41118a8b24359a22695491cb11a8fe4c2a122fb8/ios/chrome/browser/ui/download/ar_quick_look_coordinator_unittest.mm [modify] https://crrev.com/41118a8b24359a22695491cb11a8fe4c2a122fb8/ios/testing/BUILD.gn [add] https://crrev.com/41118a8b24359a22695491cb11a8fe4c2a122fb8/ios/testing/data/http_server_files/retrotv.usdz [modify] https://crrev.com/41118a8b24359a22695491cb11a8fe4c2a122fb8/tools/metrics/histograms/enums.xml [modify] https://crrev.com/41118a8b24359a22695491cb11a8fe4c2a122fb8/tools/metrics/histograms/histograms.xml
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee commit 2d4c8453dec66bd51b7ffffa0a837d0cd14997ee Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri Nov 30 04:44:26 2018 [AR][IOS] AR Quick Look integration - Adds a feature and corresponding flags in order to gate the integration. - Modifies ARQuickLookTabHelper to inform delegate only if download was successful. - Hooks up ARQuickLookTabHelper in DownloadServiceManager. - Sets up ARQuickLookCoordinator and ARQuickLookTabHelper in browser coordinator. - Replaces the test USDZ file with a smaller one. - Adds EG tests. Bug: 908696 Change-Id: I37482d356b2e5db5ac09f46df957a3b0cdc48879 Reviewed-on: https://chromium-review.googlesource.com/c/1351980 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612564} [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/BUILD.gn [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/ar_quick_look_tab_helper.mm [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/ar_quick_look_tab_helper_unittest.mm [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/browser_download_service.mm [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/browser_download_service_unittest.mm [add] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/download_test_util.cc [add] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/download_test_util.h [add] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/features.h [add] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/features.mm [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/download/pass_kit_tab_helper_unittest.mm [delete] https://crrev.com/f0a854a2ca29cb5525b37a37cd0616de74164ab2/ios/chrome/browser/download/pass_kit_test_util.cc [delete] https://crrev.com/f0a854a2ca29cb5525b37a37cd0616de74164ab2/ios/chrome/browser/download/pass_kit_test_util.h [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/ui/download/BUILD.gn [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/ui/download/ar_quick_look_coordinator_unittest.mm [add] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/ui/download/ar_quick_look_egtest.mm [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/ui/download/pass_kit_coordinator_unittest.mm [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/ui/download/pass_kit_egtest.mm [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/ui/main/BUILD.gn [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/chrome/browser/ui/main/browser_coordinator.mm [modify] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/testing/BUILD.gn [add] https://crrev.com/2d4c8453dec66bd51b7ffffa0a837d0cd14997ee/ios/testing/data/http_server_files/redchair.usdz [delete] https://crrev.com/f0a854a2ca29cb5525b37a37cd0616de74164ab2/ios/testing/data/http_server_files/retrotv.usdz
,
Nov 30
,
Dec 5
Requesting merge of the CL in #c4 into M72. CL barely missed the milestone and is needed for a feature targeted for M72. Feature verified in Chrome Canary 73.0.3629.0
,
Dec 5
,
Dec 6
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2942a438ebc228bdc796ddf8a54ebe7543b383db commit 2942a438ebc228bdc796ddf8a54ebe7543b383db Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri Dec 07 06:38:23 2018 [AR][IOS] AR Quick Look integration - Adds a feature and corresponding flags in order to gate the integration. - Modifies ARQuickLookTabHelper to inform delegate only if download was successful. - Hooks up ARQuickLookTabHelper in DownloadServiceManager. - Sets up ARQuickLookCoordinator and ARQuickLookTabHelper in browser coordinator. - Replaces the test USDZ file with a smaller one. - Adds EG tests. TBR=mahmadi@chromium.org (cherry picked from commit 2d4c8453dec66bd51b7ffffa0a837d0cd14997ee) Bug: 908696 Change-Id: I37482d356b2e5db5ac09f46df957a3b0cdc48879 Reviewed-on: https://chromium-review.googlesource.com/c/1351980 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612564} Reviewed-on: https://chromium-review.googlesource.com/c/1367082 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#131} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/BUILD.gn [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/ar_quick_look_tab_helper.mm [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/ar_quick_look_tab_helper_unittest.mm [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/browser_download_service.mm [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/browser_download_service_unittest.mm [add] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/download_test_util.cc [add] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/download_test_util.h [add] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/features.h [add] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/features.mm [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/download/pass_kit_tab_helper_unittest.mm [delete] https://crrev.com/91f2729c151fb5fb47bf90dfdf7967203e3eba9d/ios/chrome/browser/download/pass_kit_test_util.cc [delete] https://crrev.com/91f2729c151fb5fb47bf90dfdf7967203e3eba9d/ios/chrome/browser/download/pass_kit_test_util.h [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/ui/download/BUILD.gn [add] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/ui/download/ar_quick_look_coordinator_unittest.mm [add] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/ui/download/ar_quick_look_egtest.mm [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/ui/download/pass_kit_coordinator_unittest.mm [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/ui/download/pass_kit_egtest.mm [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/ui/main/BUILD.gn [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/chrome/browser/ui/main/browser_coordinator.mm [modify] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/testing/BUILD.gn [add] https://crrev.com/2942a438ebc228bdc796ddf8a54ebe7543b383db/ios/testing/data/http_server_files/redchair.usdz
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/386cac96488a0d6d9aa45ab37f9e4f80571d4606 commit 386cac96488a0d6d9aa45ab37f9e4f80571d4606 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Mon Dec 10 23:04:48 2018 [AR][IOS] AR Quick Look integration followup - Addresses feedback on crrev.com/c/1351980 posted after it landed: - Moves ARQuickLookTabHelper creation to AttachTabHelpers(). - Makes ARQuickLookCoordinator a WebStateList observer to install and uninstall itself as the ARQuickLookTabHelper. - Fixes a bug where QLPreviewController was not being presented any longer if it failed to be presented once, e.g., due to base view controller's view not being in the window hirerachy b/c incognito tab is not open. Bug: 908696 Change-Id: Id5f325f862db9cd398468b1833203b950a5b1060 Reviewed-on: https://chromium-review.googlesource.com/c/1364830 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615301} [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/download/ar_quick_look_tab_helper.h [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/download/ar_quick_look_tab_helper.mm [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/download/ar_quick_look_tab_helper_unittest.mm [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/download/browser_download_service_unittest.mm [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/tabs/tab_helper_util.mm [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/ui/download/ar_quick_look_coordinator.h [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/ui/download/ar_quick_look_coordinator.mm [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/ui/download/ar_quick_look_coordinator_unittest.mm [modify] https://crrev.com/386cac96488a0d6d9aa45ab37f9e4f80571d4606/ios/chrome/browser/ui/main/browser_coordinator.mm
,
Dec 11
Beta release branch compilation failing after cherrypick in comment 9. See: https://logs.chromium.org/logs/chrome/bb/internal.bling.main/beta-simulator/3699/+/recipes/steps/compile/0/stdout https://logs.chromium.org/logs/chrome/bb/internal.bling.main/beta-simulator/3700/+/recipes/steps/compile/0/stdout Error message: [19569/73606] OBJCXX obj/ios/chrome/browser/ui/main/main/browser_coordinator.o FAILED: obj/ios/chrome/browser/ui/main/main/browser_coordinator.o /b/c/goma_cache/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ios/chrome/browser/ui/main/main/browser_coordinator.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_XCODE_VERSION=1010 -DCR_CLANG_REVISION=\"346388-5\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DWEBP_EXTERN=extern -DEXPAT_RELATIVE_PATH -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DWEBRTC_IOS -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -DLEVELDB_PLATFORM_CHROMIUM=1 -DLEVELDB_PLATFORM_CHROMIUM=1 -I../.. -Igen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/abseil-cpp -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -Igen/third_party/metrics_proto -I../../ios/third_party/material_components_ios/src/components/ActivityIndicator/src -I../../ios/third_party/material_components_ios/src/components/Buttons/src/ButtonThemer -I../../ios/third_party/material_components_ios/src/components/Buttons/src/ShapeThemer -I../../ios/third_party/material_components_ios/src/components/AppBar/src -I../../ios/third_party/material_components_ios/src/components/private/ShapeLibrary/src -I../../ios/third_party/material_components_ios/src/components/ButtonBar/src -I../../ios/third_party/material_components_ios/src/components/Buttons/src -I../../ios/third_party/material_components_ios/src/components/Cards/src -I../../ios/third_party/material_components_ios/src/components/CollectionCells/src -I../../ios/third_party/material_components_ios/src/components/CollectionLayoutAttributes/src -I../../ios/third_party/material_components_ios/src/components/Collections/src -I../../ios/third_party/material_components_ios/src/components/Dialogs/src -I../../ios/third_party/material_components_ios/src/components/FlexibleHeader/src -I../../ios/third_party/material_components_ios/src/components/HeaderStackView/src -I../../ios/third_party/material_components_ios/src/components/Ink/src -I../../ios/third_party/material_components_ios/src/components/NavigationBar/src -I../../ios/third_party/material_components_ios/src/components/OverlayWindow/src -I../../ios/third_party/material_components_ios/src/components/Palettes/src -I../../ios/third_party/material_components_ios/src/components/ProgressView/src -I../../ios/third_party/material_components_ios/src/components/ShadowElevations/src -I../../ios/third_party/material_components_ios/src/components/ShadowLayer/src -I../../ios/third_party/material_components_ios/src/components/Snackbar/src -I../../ios/third_party/material_components_ios/src/components/Themes/src -I../../ios/third_party/material_components_ios/src/components/Typography/src -I../../ios/third_party/material_components_ios/src/components/private/Shapes/src -I../../ios/third_party/material_components_ios/src/components/private/UIMetrics/src -I../../ios/third_party/material_components_ios/src/components/schemes/Color/src -I../../ios/third_party/material_components_ios/src/components/schemes/Shape/src -I../../ios/third_party/material_components_ios/src/components/schemes/Typography/src -I../../ios/third_party/motion_animator_objc/forwarding_headers -I../../ios/third_party/motion_interchange_objc/forwarding_headers -I../../ios/third_party/motion_transitioning_objc/forwarding_headers -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wundeclared-selector -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -O0 -fno-omit-frame-pointer -gdwarf-2 -isysroot /b/c/xcode_ios_10b61.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk -stdlib=libc++ -mios-simulator-version-min=11.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-shorten-64-to-32 -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++14 -fobjc-call-cxx-cdtors -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -fobjc-arc -c ../../ios/chrome/browser/ui/main/browser_coordinator.mm -o obj/ios/chrome/browser/ui/main/main/browser_coordinator.o ../../ios/chrome/browser/ui/main/browser_coordinator.mm:28:9: fatal error: 'ios/chrome/browser/ui/download/ar_quick_look_coordinator.h' file not found #import "ios/chrome/browser/ui/download/ar_quick_look_coordinator.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ar_quick_look_coordinator.h was added in comment 3 https://chromium-review.googlesource.com/c/1353048 which missed the branch point. Cherrypicking comment 4 without comment 3 breaks the build.
,
Dec 11
I didn't realized #c3 had also missed branch point. Merging #c into 3626 based on the previous approval.
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61f88387abe8623ccd5c164c519a82e451741c24 commit 61f88387abe8623ccd5c164c519a82e451741c24 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Dec 11 00:59:34 2018 [AR][IOS] Creates a ARQuickLookCoordinator to display USDZ format files. - Creates a ARQuickLookCoordinator as the ARQuickLookTabHelperDelegate that presents a QLPreviewController in order to display USDZ format files. TBR=mahmadi@chromium.org (cherry picked from commit 41118a8b24359a22695491cb11a8fe4c2a122fb8) Bug: 908696 Change-Id: I7cee24392cd7133aa23127dd991b51694fabadfa Reviewed-on: https://chromium-review.googlesource.com/c/1353048 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612510} Reviewed-on: https://chromium-review.googlesource.com/c/1370228 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#246} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/61f88387abe8623ccd5c164c519a82e451741c24/ios/chrome/browser/download/ar_quick_look_tab_helper.mm [modify] https://crrev.com/61f88387abe8623ccd5c164c519a82e451741c24/ios/chrome/browser/ui/download/BUILD.gn [add] https://crrev.com/61f88387abe8623ccd5c164c519a82e451741c24/ios/chrome/browser/ui/download/ar_quick_look_coordinator.h [add] https://crrev.com/61f88387abe8623ccd5c164c519a82e451741c24/ios/chrome/browser/ui/download/ar_quick_look_coordinator.mm [modify] https://crrev.com/61f88387abe8623ccd5c164c519a82e451741c24/ios/testing/BUILD.gn [add] https://crrev.com/61f88387abe8623ccd5c164c519a82e451741c24/ios/testing/data/http_server_files/retrotv.usdz [modify] https://crrev.com/61f88387abe8623ccd5c164c519a82e451741c24/tools/metrics/histograms/enums.xml [modify] https://crrev.com/61f88387abe8623ccd5c164c519a82e451741c24/tools/metrics/histograms/histograms.xml
,
Dec 12
Feature available on M72.0.3626.15 beta. Testing is in progress.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2942a438ebc228bdc796ddf8a54ebe7543b383db Commit: 2942a438ebc228bdc796ddf8a54ebe7543b383db Author: mahmadi@chromium.org Commiter: mahmadi@chromium.org Date: 2018-12-07 06:38:23 +0000 UTC [AR][IOS] AR Quick Look integration - Adds a feature and corresponding flags in order to gate the integration. - Modifies ARQuickLookTabHelper to inform delegate only if download was successful. - Hooks up ARQuickLookTabHelper in DownloadServiceManager. - Sets up ARQuickLookCoordinator and ARQuickLookTabHelper in browser coordinator. - Replaces the test USDZ file with a smaller one. - Adds EG tests. TBR=mahmadi@chromium.org (cherry picked from commit 2d4c8453dec66bd51b7ffffa0a837d0cd14997ee) Bug: 908696 Change-Id: I37482d356b2e5db5ac09f46df957a3b0cdc48879 Reviewed-on: https://chromium-review.googlesource.com/c/1351980 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612564} Reviewed-on: https://chromium-review.googlesource.com/c/1367082 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#131} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61f88387abe8623ccd5c164c519a82e451741c24 Commit: 61f88387abe8623ccd5c164c519a82e451741c24 Author: mahmadi@chromium.org Commiter: mahmadi@chromium.org Date: 2018-12-11 00:59:34 +0000 UTC [AR][IOS] Creates a ARQuickLookCoordinator to display USDZ format files. - Creates a ARQuickLookCoordinator as the ARQuickLookTabHelperDelegate that presents a QLPreviewController in order to display USDZ format files. TBR=mahmadi@chromium.org (cherry picked from commit 41118a8b24359a22695491cb11a8fe4c2a122fb8) Bug: 908696 Change-Id: I7cee24392cd7133aa23127dd991b51694fabadfa Reviewed-on: https://chromium-review.googlesource.com/c/1353048 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612510} Reviewed-on: https://chromium-review.googlesource.com/c/1370228 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#246} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Yesterday
(35 hours ago)
Issue 883399 has been merged into this issue. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 28