crosvm: print syscall number for SIGSYS |
||
Issue descriptionNeed a crosvm libc uprev first, then signalfd should provide the syscall number.
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b1964e613553072e759407d555c0961b1adff4c1 commit b1964e613553072e759407d555c0961b1adff4c1 Author: Stephen Barber <smbarber@chromium.org> Date: Wed Nov 28 03:13:44 2018 crosvm: update libc crate to 0.2.44 BUG=chromium:908695 TEST=emerge crosvm CQ-DEPEND=CL:1351219 Change-Id: Ib3c20484cf9a0ce2737d4f0ad185f09aca49713d Reviewed-on: https://chromium-review.googlesource.com/1351218 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org> [modify] https://crrev.com/b1964e613553072e759407d555c0961b1adff4c1/chromeos-base/crosvm/Manifest [modify] https://crrev.com/b1964e613553072e759407d555c0961b1adff4c1/chromeos-base/crosvm/crosvm-9999.ebuild
,
Nov 30
how were you planning on using signalfd ? if it's a parent process watching a child, and the child gets the SIGSYS (and gets killed), then i don't think the parent process will get the details sent over to it. i implemented that approach in minijail: https://android-review.googlesource.com/838010 the SIGSYS fields are all zero. looking in the kernel's fs/signalfd.c, SIL_CHLD will fill in the pid and related fields, but it doesn't fill in the seccomp related fields like SIL_SYS does. i had more thoughts in issue 856316 on the topic.
,
Nov 30
I had thought for sure that there was a mechanism for surfacing the signal info associated with the SIGCHLD. I guess I thought the SIL_CHLD case would fall through? https://elixir.bootlin.com/linux/latest/source/fs/signalfd.c#L137 Seems like the best option is to fix up the kernel to fill out the SIL_SYS fields as well if the child was killed by SIGSYS.
,
Nov 30
i would love it if you did that ;). i think waitid() has the same limitation as i noted in that other bug.
,
Dec 20
Moving back to assigned, this would require a bunch of refactoring of exit_group. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 28