New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 908693 link

Starred by 1 user
Status: Fixed
Owner:
█ kehuangli@chromium.org
Last visit > 30 days ago
Closed: Dec 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

AlsaInput may fail to open device

Project Member Reported by kehuangli@google.com, Nov 27 
On some platform, when ALSA driver is used in a special way (b/117101986), AlsaInput may fail to create audio capture using the default PcmSetParams in OpenDevice(). One solution would be use a customized SetParams function to choose buffer size and period size that may consider invalid in snd_pcm_set_params().
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c0a48b6d8327b9900bc07439bdcc647fddbad9b

commit 9c0a48b6d8327b9900bc07439bdcc647fddbad9b
Author: Kehuang Li <kehuangli@chromium.org>
Date: Thu Dec 20 03:27:10 2018

Add customized function to set pcm parameters

Add a fallback function that can be used when the default one fails.

Bug:  908693 , b/117101986
Test: Printed log shows the fallback function opens the audio device.
Change-Id: I717e51fc146a0d50c459e9718f25151b4afb2714
Reviewed-on: https://chromium-review.googlesource.com/c/1303355
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Kehuang Li <kehuangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618097}
[modify] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/chromecast/media/cma/backend/alsa/alsa_wrapper.cc
[modify] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/chromecast/media/cma/backend/alsa/alsa_wrapper.h
[modify] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/BUILD.gn
[modify] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/alsa/alsa_input.cc
[modify] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/alsa/alsa_output_unittest.cc
[modify] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/alsa/alsa_util.cc
[modify] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/alsa/alsa_util.h
[add] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/alsa/alsa_util_unittest.cc
[modify] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/alsa/alsa_wrapper.cc
[modify] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/alsa/alsa_wrapper.h
[add] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/alsa/mock_alsa_wrapper.cc
[add] https://crrev.com/9c0a48b6d8327b9900bc07439bdcc647fddbad9b/media/audio/alsa/mock_alsa_wrapper.h

Comment 2 by kehuangli@chromium.org, Dec 20

Status: Fixed (was: Started)
►

Sign in to add a comment