cursor is not set on GPU process restart |
||
Issue description
When the GPU process restarts we need to re-send the cursor bitmap since all GPU process display state is lost.
It looks like it may have been broken all the way back to d818104f773a ("[Ozone-Drm] Notify cursor of channel established last"), which fixed a different issue but also caused the message that was intended to restore the cursor (in CommitBoundsChange) to not get delivered.
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/843847fcb01b920fa5c5693623ebc243151254c8 commit 843847fcb01b920fa5c5693623ebc243151254c8 Author: Michael Spang <spang@chromium.org> Date: Tue Nov 27 17:29:09 2018 ozone: drm: Re-set cursor when GPU process connects When the GPU process restarts we need to re-send the cursor bitmap since all GPU process display state is lost. It looks like it may have been broken all the way back to d818104f773a ("[Ozone-Drm] Notify cursor of channel established last"), which fixed a different issue but also caused the message that was intended to restore the cursor (in CommitBoundsChange) to not get delivered. Bug: 908682 Test: kill $(pgrep -f type=gpu-process), cursor restored Change-Id: Ibacab25807995d9402c46f88a7d51b68fe8dfbfc Reviewed-on: https://chromium-review.googlesource.com/c/1351903 Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#611166} [modify] https://crrev.com/843847fcb01b920fa5c5693623ebc243151254c8/ui/ozone/platform/drm/host/drm_cursor.cc [modify] https://crrev.com/843847fcb01b920fa5c5693623ebc243151254c8/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/055f555c83f4e76d562b615e1c5fa8f038b2eaad commit 055f555c83f4e76d562b615e1c5fa8f038b2eaad Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Nov 28 08:12:11 2018 Revert "ozone: drm: Re-set cursor when GPU process connects" This reverts commit 843847fcb01b920fa5c5693623ebc243151254c8. Reason for revert: VDA unittest on eve is broken. Original change's description: > ozone: drm: Re-set cursor when GPU process connects > > When the GPU process restarts we need to re-send the cursor bitmap since > all GPU process display state is lost. > > It looks like it may have been broken all the way back to d818104f773a > ("[Ozone-Drm] Notify cursor of channel established last"), which fixed a > different issue but also caused the message that was intended to restore > the cursor (in CommitBoundsChange) to not get delivered. > > Bug: 908682 > Test: kill $(pgrep -f type=gpu-process), cursor restored > > Change-Id: Ibacab25807995d9402c46f88a7d51b68fe8dfbfc > Reviewed-on: https://chromium-review.googlesource.com/c/1351903 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611166} TBR=spang@chromium.org,dnicoara@chromium.org Change-Id: I6b69290c0d193190a0bcecc56819b3c59872eff8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908682 Reviewed-on: https://chromium-review.googlesource.com/c/1353038 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#611594} [modify] https://crrev.com/055f555c83f4e76d562b615e1c5fa8f038b2eaad/ui/ozone/platform/drm/host/drm_cursor.cc [modify] https://crrev.com/055f555c83f4e76d562b615e1c5fa8f038b2eaad/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76fef47af1b63a6d23876f0387c9288adfacceae commit 76fef47af1b63a6d23876f0387c9288adfacceae Author: Michael Spang <spang@chromium.org> Date: Wed Nov 28 20:54:51 2018 ozone: drm: Re-set cursor when GPU process connects (reland) When the GPU process restarts we need to re-send the cursor bitmap since all GPU process display state is lost. It looks like it may have been broken all the way back to d818104f773a ("[Ozone-Drm] Notify cursor of channel established last"), which fixed a different issue but also caused the message that was intended to restore the cursor (in CommitBoundsChange) to not get delivered. Reland fixing case where a GPU process connects and the cursor is not placed because there are no displays to place it on. This should only affects tests, because there's always at least one display on Chrome OS. Bug: 908682 Test: kill $(pgrep -f type=gpu-process), cursor restored Change-Id: I378d14e61c95822c2362d047123e5f7e40778a80 Reviewed-on: https://chromium-review.googlesource.com/c/1351143 Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611861} [modify] https://crrev.com/76fef47af1b63a6d23876f0387c9288adfacceae/ui/ozone/platform/drm/host/drm_cursor.cc [modify] https://crrev.com/76fef47af1b63a6d23876f0387c9288adfacceae/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
,
Dec 4
|
||
►
Sign in to add a comment |
||
Comment 1 by spang@google.com
, Nov 27