New issue
Advanced search Search tips

Issue 908679 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Dec 3
Cc:
omrilio@chromium.org
x...@chromium.org
mccanny@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Center overview windows when shelf is set to auto-hide

Project Member Reported by mccanny@chromium.org, Nov 27 
Chrome OS Version: 72

Overview windows should be vertically-centered within the space above the shelf as they are when the shelf is set to "always show". Currently they are centered within the entire screen when the shelf is set to auto-hide (see screenshot: https://drive.google.com/file/d/1CRXDWrTVZQYgbFFCOYOnvAxvkardZICJ/view?usp=sharing)
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f6fd36bb94d977b97ea7b34b8d348672773ed30

commit 1f6fd36bb94d977b97ea7b34b8d348672773ed30
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Nov 30 23:59:59 2018

overview: Grid bounds should respect the auto hidden shelf.

Adds an inset when the shelf is auto hidden because we want the grid to
be centered as if the shelf is fully visible.

Test: ash_unittests WindowSelectorTest.GridBounds
Bug:  908679 ,  908982 
Change-Id: Ibccfb0bab70d68a463c3325fa8ca3b7912d0dc65
Reviewed-on: https://chromium-review.googlesource.com/c/1354355
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612859}
[modify] https://crrev.com/1f6fd36bb94d977b97ea7b34b8d348672773ed30/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/1f6fd36bb94d977b97ea7b34b8d348672773ed30/ash/wm/overview/window_selector_unittest.cc

Comment 2 by sammiequon@chromium.org, Dec 3

Status: Fixed (was: Untriaged)

Comment 3 by sammiequon@chromium.org, Dec 3

Labels: OS-Chrome
►

Sign in to add a comment