New issue
Advanced search Search tips

Issue 908677 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in BrowserView::GetBrowserViewForBrowser

Project Member Reported by ClusterFuzz, Nov 27

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6150857856647168

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000f8
Crash State:
  BrowserView::GetBrowserViewForBrowser
  QuitInstructionBubble::AnimationProgressed
  gfx::LinearAnimation::Step
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=599791:599800

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6150857856647168

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 27

Components: Internals>Compositing>Animation UI>Browser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 27

Labels: Test-Predator-Auto-Owner
Owner: collinbaker@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/c2635b23eeffa4713fdf2c540f704b3e1ed7eee7 (Make tabs focusable and add focus ring).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: collinbaker@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
I'm pretty sure this is unrelated to my change.
Labels: M-72 Test-Predator-Wrong
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using the code search for the file, “quit_instruction_bubble.cc” assigning to concern owner from GIT revision log.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/3610635d00f7bb182f760e7cfa55942b450bb828

@thomasanderson-- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.
Thank You.

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bbb2939476f2b88ecb53cecbe3656f61f02e6ee

commit 3bbb2939476f2b88ecb53cecbe3656f61f02e6ee
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Nov 28 00:19:08 2018

Fix null dereference in QuitInstructionBubble

BUG= 908677 
R=sky

Change-Id: I5d4a5a43fdf6d503cbd69619472e130a7abcc374
Reviewed-on: https://chromium-review.googlesource.com/c/1351690
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611443}
[modify] https://crrev.com/3bbb2939476f2b88ecb53cecbe3656f61f02e6ee/chrome/browser/ui/views/quit_instruction_bubble.cc

Status: Fixed (was: Started)
Project Member

Comment 8 by ClusterFuzz, Nov 28

ClusterFuzz has detected this issue as fixed in range 611442:611447.

Detailed report: https://clusterfuzz.com/testcase?key=6150857856647168

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000f8
Crash State:
  BrowserView::GetBrowserViewForBrowser
  QuitInstructionBubble::AnimationProgressed
  gfx::LinearAnimation::Step
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=599791:599800
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=611442:611447

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6150857856647168

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Nov 28

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6150857856647168 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment