New issue
Advanced search Search tips

Issue 908673 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile device_hander_unittest

Project Member Reported by noel@chromium.org, Nov 27

Issue description

- remove device_hander_unittest.html
- auto-generate it and fix closure compile issues

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f45b8394f08eabdf998f9ff7652a959ec5320e0b

commit f45b8394f08eabdf998f9ff7652a959ec5320e0b
Author: Noel Gordon <noel@chromium.org>
Date: Tue Nov 27 02:44:54 2018

Closure compile device_hander_unittest

 - remove device_handler_unittest.html
 - add BUILD rule to auto-generate this unit test
 - add BUILD rule to Closure compile this unit test
 - rename handler -> deviceHander, use mockChrome
   everywhere and also install it during Setup()
 - remove unused timeoutCallbacks var
 - fix Closure errors, js code auto-format

No change in test behavior, no new tests.

Bug:  908673 
No-try: true
Change-Id: I46535df1c77a57c488e40f9c410ca4a62ad73ac5
Reviewed-on: https://chromium-review.googlesource.com/c/1351336
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611000}
[modify] https://crrev.com/f45b8394f08eabdf998f9ff7652a959ec5320e0b/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/f45b8394f08eabdf998f9ff7652a959ec5320e0b/ui/file_manager/file_manager/background/js/BUILD.gn
[delete] https://crrev.com/620e9b7369aeb16f73a5321968fcb5c20f597106/ui/file_manager/file_manager/background/js/device_handler_unittest.html
[modify] https://crrev.com/f45b8394f08eabdf998f9ff7652a959ec5320e0b/ui/file_manager/file_manager/background/js/device_handler_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment