New issue
Advanced search Search tips

Issue 908670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Download Home : Filter out transient downloads

Project Member Reported by shaktisahu@chromium.org, Nov 27

Issue description

We should filter out transient downloads from new download home

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9fd3e2ef82917819fd51753a4a21d458870218d

commit a9fd3e2ef82917819fd51753a4a21d458870218d
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Tue Nov 27 07:39:24 2018

Download Home : Filter out the transient downloads

Transient downloads shouldn't show up on download home and hence should
be filtered out.

Bug:  908670 
Change-Id: Ic7ff12a36a7c46a6d7f7e63fe0faede8173488e1
Reviewed-on: https://chromium-review.googlesource.com/c/1351717
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611037}
[modify] https://crrev.com/a9fd3e2ef82917819fd51753a4a21d458870218d/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/InvalidStateOfflineItemFilter.java

Labels: Merge-Request-71
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 27

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This is a small isolated patch which affects only when Download home V2 feature is enabled.
In M-71 we are planning to enable this feature only on 1% experimental and rollout on M72. As such, this patch should be safe to merge. Requesting merge to M-71.
Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Merge approved to 71, branch 3578.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 27

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6af5a4d6335d82c5dae701574318f912db518d3c

commit 6af5a4d6335d82c5dae701574318f912db518d3c
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Tue Nov 27 19:02:56 2018

Download Home : Filter out the transient downloads

Transient downloads shouldn't show up on download home and hence should
be filtered out.

Bug:  908670 
Change-Id: Ic7ff12a36a7c46a6d7f7e63fe0faede8173488e1
Reviewed-on: https://chromium-review.googlesource.com/c/1351717
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#611037}(cherry picked from commit a9fd3e2ef82917819fd51753a4a21d458870218d)
Reviewed-on: https://chromium-review.googlesource.com/c/1352454
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#828}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/6af5a4d6335d82c5dae701574318f912db518d3c/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/InvalidStateOfflineItemFilter.java

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/6af5a4d6335d82c5dae701574318f912db518d3c

Commit: 6af5a4d6335d82c5dae701574318f912db518d3c
Author: shaktisahu@chromium.org
Commiter: shaktisahu@chromium.org
Date: 2018-11-27 19:02:56 +0000 UTC

Download Home : Filter out the transient downloads

Transient downloads shouldn't show up on download home and hence should
be filtered out.

Bug:  908670 
Change-Id: Ic7ff12a36a7c46a6d7f7e63fe0faede8173488e1
Reviewed-on: https://chromium-review.googlesource.com/c/1351717
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#611037}(cherry picked from commit a9fd3e2ef82917819fd51753a4a21d458870218d)
Reviewed-on: https://chromium-review.googlesource.com/c/1352454
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#828}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)

Sign in to add a comment