Drop amd64-generic-asan, amd64-generic-ubsan, and betty-asan from chrome_informational builder list |
||||
Issue descriptionShould the amd64-generic-asan and betty-asan builders be dropped from the "chrome_informational" section at the bottom of http://go/legoland-gardener? I think that the intent was for the gardener to be able to look at these builders to identify incoming memory issues in ToT Chrome (maybe?), but in practice, I don't think that anyone else is watching them, and all of the bugs that I end up filing about failures are about memory leaks in Chrome OS unit tests, which isn't the gardener's job. I literally don't think I've *ever* seen these builders passing while I've been the gardener. I scrolled all the way back to 2018-07-30 in betty-asan's history and couldn't find a single passing build. These builders are just distracting me from trying to get the Chrome PFQ to pass. So can we drop them from this page?
,
Nov 27
Thanks for the link. I'd prefer to remove them until they've been split to only use ASAN for Chrome -- right now, they're making my job harder with no upside. Have they ever revealed any Chrome bugs? I just skimmed through the titles of a hundred issues containing "amd64-generic-asan" and didn't see any obvious cases.
,
Nov 27
,
Nov 30
Email thread is at http://g/chrome-os-gardeners/jkfCQ43ZGJg, and I sent https://crrev.com/c/1356074 to do this.
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/437c929ab95861b9c5ff889239c9b449a1e12f79 commit 437c929ab95861b9c5ff889239c9b449a1e12f79 Author: Daniel Erat <derat@chromium.org> Date: Sat Dec 01 00:18:16 2018 chromeos_config: Remove chrome-informational from ASan/UBSan Remove the "chrome-informational" display label from the amd64-generic-asan, amd64-generic-ubsan, and betty-asan builders, and use "informational" instead. These builders build everything using ASan/UBSan, so they're not useful for the Chrome gardener -- they're eternally red due to OS unit test issues. BUG= chromium:908667 TEST=looked at config_dump.json Change-Id: Ia970817e602754e24a636ddd5c4b63515d3a29b9 Reviewed-on: https://chromium-review.googlesource.com/1356074 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/437c929ab95861b9c5ff889239c9b449a1e12f79/config/chromeos_config.py [modify] https://crrev.com/437c929ab95861b9c5ff889239c9b449a1e12f79/config/config_dump.json [modify] https://crrev.com/437c929ab95861b9c5ff889239c9b449a1e12f79/config/luci-scheduler.cfg
,
Dec 3
The latest builds displayed are from 2018-11-30. I'm not sure exactly how long it'll take for them to expire from the page.
,
Dec 4
Hooray, these don't show up anymore! |
||||
►
Sign in to add a comment |
||||
Comment 1 by steve...@chromium.org
, Nov 27