New issue
Advanced search Search tips

Issue 908633 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Component builds are broken under Fuchsia

Project Member Reported by w...@chromium.org, Nov 26

Issue description

Component builds currently fail to compile (see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-dbg/3931).

Looks like some Mojo struct traits for Skia types are missing an export macro.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7453a788935b61eed7741b058f05851fdd6427ff

commit 7453a788935b61eed7741b058f05851fdd6427ff
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue Nov 27 17:25:36 2018

Fix the Fuchsia component build.

Bug:  908633 
Change-Id: If37d2920cc2b71d002b3674490d1d8e3d8d76b62
Reviewed-on: https://chromium-review.googlesource.com/c/1351902
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611162}
[modify] https://crrev.com/7453a788935b61eed7741b058f05851fdd6427ff/webrunner/BUILD.gn

Status: Verified (was: Assigned)
Build 3997 is back to regular test failures
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-dbg/3997

All is well.

Sign in to add a comment