OS: (e.g. Win10, MacOS 10.12, etc...) gLinux
What steps will reproduce the problem?
(1) Create a new branch
(2) Add some changes
(3) git cl presubmit
What is the expected result?
Presubmit tests and linting runs with warning for checks that fail because the change isn't uploaded (e.g. no owners assigned for review)
What happens instead?
Presubmit ERRORS reports that the OWNERS check has fails and no other tests / checks / linting is run.
It is possible to run git cl lint or upload the issue but its not obvious to me why we should enforce this extra step when a developer wants to check their code.
OS: (e.g. Win10, MacOS 10.12, etc...) gLinux
What steps will reproduce the problem?
(1) Create a new branch
(2) Add some changes
(3) git cl presubmit
What is the expected result?
Presubmit tests and linting runs with warning for checks that fail because the change isn't uploaded (e.g. no owners assigned for review)
What happens instead?
Presubmit ERRORS reports that the OWNERS check has fails and no other tests / checks / linting is run.
It is possible to run git cl lint to get partial results (or upload the CL) but its not obvious to me why we should enforce this extra step when a developer wants to check their code.
Comment 1 by jopra@chromium.org
, Nov 26