New issue
Advanced search Search tips

Issue 908627 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

git cl presubmit should run lint and presubmit checks without CL being uploaded

Project Member Reported by jopra@chromium.org, Nov 26

Issue description

OS: (e.g. Win10, MacOS 10.12, etc...) gLinux

What steps will reproduce the problem?
(1) Create a new branch
(2) Add some changes
(3) git cl presubmit

What is the expected result?
Presubmit tests and linting runs with warning for checks that fail because the change isn't uploaded (e.g. no owners assigned for review)

What happens instead?
Presubmit ERRORS reports that the OWNERS check has fails and no other tests / checks / linting is run.

It is possible to run git cl lint to get partial results (or upload the CL) but its not obvious to me why we should enforce this extra step when a developer wants to check their code.
 
Description: Show this description
Status: Available (was: Untriaged)

Sign in to add a comment