New issue
Advanced search Search tips

Issue 908620 link

Starred by 2 users
Status: Started
Owner:
jdeblasio@chromium.org
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Task
Team-Security-UX



Sign in to add a comment

Remove no-longer-needed HTTP-Bad logic

Project Member Reported by jdeblasio@google.com, Nov 26 
This is a tracking bug for code cleanup of the HTTP-Bad logic. We no longer need the logic to show "Not Secure" in Incognito, nor the logic for tracking password and credit card use on HTTP pages.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20e01fd944268e463a7aaf0153f742b8ed23ced8

commit 20e01fd944268e463a7aaf0153f742b8ed23ced8
Author: Joe DeBlasio <jdeblasio@chromium.org>
Date: Thu Dec 20 19:59:30 2018

Removal of no-longer-used transitional HTTP-Bad logic.

As HTTP-Bad now treats nearly all HTTP sites as universally bad,
this CL removes tracking of incognito mode, insecure credit card
editing, and insecure password entry no longer needed for
updating security state. It also removes now-unused flag conditions
no longer used in experiments.

Bug: 908620
Change-Id: Ia10f399638b3e4b81d733e9bcd955c5ac42feb73
Reviewed-on: https://chromium-review.googlesource.com/c/1350922
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618301}
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/about_flags.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ssl/insecure_sensitive_input_driver.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ssl/insecure_sensitive_input_driver.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ssl/insecure_sensitive_input_driver_factory.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ssl/insecure_sensitive_input_driver_factory.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ssl/insecure_sensitive_input_driver_unittest.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ssl/security_state_tab_helper.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ssl/security_state_tab_helper.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ssl/security_state_tab_helper_browsertest.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ssl/security_state_tab_helper_unittest.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/chrome/browser/ui/autofill/chrome_autofill_client.h
[delete] https://crrev.com/74bec1eff7044287feda422c3c966eb1885c317d/chrome/test/data/password/invisible_password.html
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/content/browser/content_autofill_driver.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/content/browser/content_autofill_driver.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/content/browser/content_autofill_driver_unittest.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/core/browser/autofill_driver.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/core/browser/test_autofill_driver.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/core/browser/test_autofill_driver.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/ios/browser/autofill_driver_ios.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/autofill/ios/browser/autofill_driver_ios.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state/content/content_utils.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state/content/content_utils_browsertest.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state/content/content_utils_unittest.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state/core/features.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state/core/features.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state/core/insecure_input_event_data.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state/core/security_state.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state/core/security_state.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state/core/security_state_unittest.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/components/security_state_strings.grdp
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/ssl/insecure_input_tab_helper.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/ssl/insecure_input_tab_helper.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/ssl/ios_security_state_tab_helper.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/ssl/ios_security_state_tab_helper_unittest.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/third_party/blink/public/platform/modules/insecure_input/insecure_input_service.mojom
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/third_party/blink/renderer/core/html/forms/input_type.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/third_party/blink/renderer/core/html/forms/input_type.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/third_party/blink/renderer/core/html/forms/password_input_type.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/third_party/blink/renderer/core/html/forms/password_input_type.h
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/third_party/blink/renderer/core/html/forms/password_input_type_test.cc
[modify] https://crrev.com/20e01fd944268e463a7aaf0153f742b8ed23ced8/tools/metrics/histograms/histograms.xml

Comment 2 by jdeblasio@chromium.org, Dec 20 

Ooph. That was a lot of files.

I'm going to do some digging yet to see if there's other cleanup to be done, but otherwise this is fixed. I'll hold off until I've poked around a bit.
►

Sign in to add a comment