fix and re-enable performance_browser_tests failing on windows |
|||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of crouleau@google.com df4598a6-603e-4c9d-8bf4-f4e8dd6a85b8 Builders failed on: - Win 7 Nvidia GPU Perf: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/Win%207%20Nvidia%20GPU%20Perf - Win 7 Perf: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/Win%207%20Perf - win-10-perf: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win-10-perf ⛆ |
|
|
,
Nov 26
First failure: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win-10-perf/1206 last success: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win-10-perf/1205 Looks like first failure is from the first time these were turned on.
,
Nov 26
https://chromium-review.googlesource.com/c/1334852
,
Nov 26
I will disable this test on the platforms that it is failing on.
,
Nov 26
They don't seem to be failing on https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf or https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/mac-10_12_laptop_low_end-perf or https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/mac-10_13_laptop_high_end-perf so I will only disable on - Win 7 Nvidia GPU Perf: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/Win%207%20Nvidia%20GPU%20Perf - Win 7 Perf: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/Win%207%20Perf - win-10-perf: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win-10-perf
,
Nov 26
,
Nov 26
Submitted https://chromium-review.googlesource.com/c/chromium/src/+/1351800
,
Nov 26
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f03935092aa623c58a6b641c77da3d6607c6eeab commit f03935092aa623c58a6b641c77da3d6607c6eeab Author: Caleb Rouleau <crouleau@chromium.org> Date: Mon Nov 26 23:32:58 2018 [go/perfbot-sheriff] Disable performance_browser_tests on windows TBR=miu@chromium.org Bug: 908611 Change-Id: I301ab697a2ec894067f62d95beada1fa5f45ba75 Reviewed-on: https://chromium-review.googlesource.com/c/1351800 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#610976} [modify] https://crrev.com/f03935092aa623c58a6b641c77da3d6607c6eeab/testing/buildbot/chromium.perf.json [modify] https://crrev.com/f03935092aa623c58a6b641c77da3d6607c6eeab/tools/perf/core/perf_data_generator.py
,
Nov 26
Issue 906656 has been merged into this issue.
,
Nov 26
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15fe670c140000
,
Nov 26
I started https://pinpoint-dot-chromeperf.appspot.com/job/15fe670c140000 using https://chromium.googlesource.com/chromium/src/+/master/docs/speed/perf_trybots.md . It will help us see if Pinpoint works for non-Telemetry stuff, which we will need to reland this test suite on Windows.
,
Nov 27
Looks like it takes 15 seconds from the point RunExtensionSubtest() is called (in the C++ side of the browser test) until console logging from the very start of the JS code is made! This implies it takes 15 seconds to spin up a render process and start evaluating the page! Speculations: 1) Maybe the video resource is loaded over the network and is taking 15 sec to download? But, I thought all resources were copied to the local machine before running the tests. 2) Windows is delaying the start of the render process for some reason (high load?). Logs attached.
,
Nov 27
,
Nov 27
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/15fe670c140000 All of the runs failed. The most common error (1/20 runs) was: IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\itquqovb\\tmpf1zgghtelemetry\\histograms.json'
,
Dec 8
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/17c3de02140000
,
Dec 8
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/17c3de02140000
,
Dec 17
The pinpoint job that I started here https://pinpoint-dot-chromeperf.appspot.com/job/17c3de02140000 for the issue 913152 shows that this is still flaky. The error is pasted below. Yuri, once you come up with a fix for this, you should be able to follow my directions on issue 913152 to start a pinpoint job. 1 test timed out: CastV2PerformanceTest.Performance/0 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:725) Command ['.\\performance_browser_tests.exe', '--test-launcher-print-test-stdio=always', '--test-launcher-timeout=120000', '--gtest_filter=TabCapturePerformanceTest.*:CastV2PerformanceTest.*', '--test-launcher-jobs=1', '--enable-gpu', '--gtest_repeat=1', '--non-telemetry', 'true', '--verbose'] returned exit code 1 [ RUN ] CastV2PerformanceTest.Performance/0 [8188:8176:1207/172016.804:123421:ERROR:performance_test.cc(351)] CastV2PerformanceTest: Hello! [8188:8176:1207/172016.804:123421:ERROR:performance_test.cc(402)] SetUp: Starting... [8188:8176:1207/172016.804:123421:ERROR:performance_test.cc(406)] SetUp: Doing normal SetUp()... [8188:8176:1207/172016.804:123421:ERROR:performance_test.cc(418)] SetUpCommandLine: Starting... [8188:8176:1207/172016.804:123421:ERROR:performance_test.cc(438)] SetUpCommandLine: Doing normal SetUpCommandLine()... [8188:8176:1207/172016.804:123421:ERROR:performance_test.cc(440)] SetUpCommandLine: Completed. [8188:8176:1207/172017.306:WARNING:chrome_browser_main_win.cc(647)] Command line too long for RegisterApplicationRestart: --disable-gpu-process-for-dx12-vulkan-info-collection --enable-gpu --gtest_also_run_disabled_tests --gtest_filter=CastV2PerformanceTest.Performance/0 --non-telemetry --single_process --test-launcher-jobs=1 --test-launcher-output="c:\b\s\w\it5h1vhs\scoped_dir5696_16379\results5696_15014\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-timeout=120000 --user-data-dir="c:\b\s\w\it5h1vhs\scoped_dir5696_16379\d5696_3021" --verbose --disable-offline-auto-reload --allow-file-access-from-files --window-size=2000,1500 --whitelisted-extension-id=ddchlicdkolnonkihahngkmmmjnjlkkf --disable-renderer-backgrounding --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --browser-test --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=TestFeatureForBrowserTest2 --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --restore-last-session about:blank [8188:5452:1207/172018.596:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [8188:8176:1207/172023.144:ERROR:performance_test.cc(412)] SetUpOnMainThread: Doing normal SetUpOnMainThread()... [8188:8176:1207/172023.144:ERROR:performance_test.cc(414)] SetUpOnMainThread: Completed. [8188:8176:1207/172023.144:ERROR:performance_test.cc(726)] RunTestOnMainThread: Test procedure started. [8188:8176:1207/172023.144:ERROR:performance_test.cc(622)] RunTest: Starting... [8188:8176:1207/172023.144:ERROR:performance_test.cc(637)] RunTest: Got local UDP port for testing: 127.0.0.1:49445 [8188:8176:1207/172023.144:ERROR:performance_test.cc(653)] RunTest: Starting receiver... [8188:8176:1207/172023.144:ERROR:performance_test.cc(656)] RunTest: Creating UDPProxy... [8188:8176:1207/172023.144:ERROR:performance_test.cc(679)] RunTest: Starting tracing... [8188:8176:1207/172023.144:ERROR:performance_test.cc(688)] RunTest: Running extension subtest... [8188:8176:1207/172026.607:INFO:CONSOLE(7)] "Starting eval of performance.js...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (7) [8188:8176:1207/172026.611:INFO:CONSOLE(11)] "Starting sendTestPatterns()...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (11) [8188:8176:1207/172026.614:INFO:CONSOLE(58)] "About to call chrome.tabCapture.capture()...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (58) [8188:8176:1207/172026.615:INFO:CONSOLE(157)] "Completed sendTestPatterns(). (Waiting for promises...)", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (157) [8188:8176:1207/172026.616:INFO:CONSOLE(161)] "Completed eval of performance.js.", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (161) [8188:8176:1207/172030.329:INFO:CONSOLE(60)] "chrome.tabCapture.capture() callback is running...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (60) [8188:8176:1207/172030.329:INFO:CONSOLE(63)] "Started tab capture.", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (63) [8188:8176:1207/172030.329:INFO:CONSOLE(78)] "Starting streaming...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (78) [8188:8176:1207/172030.329:INFO:CONSOLE(85)] "Creating cast streaming session...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (85) [8188:8176:1207/172030.329:INFO:CONSOLE(90)] "Cast streaming session create callback is running...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (90) [8188:8176:1207/172030.329:INFO:CONSOLE(109)] "Started Cast Streaming.", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (109) [8188:8176:1207/172030.329:INFO:CONSOLE(123)] "Running test for 15000 ms.", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (123) Still waiting for the following processes to finish: ".\performance_browser_tests.exe" --disable-gpu-process-for-dx12-vulkan-info-collection --enable-gpu --gtest_also_run_disabled_tests --gtest_filter=CastV2PerformanceTest.Performance/0 --non-telemetry --single_process --test-launcher-jobs=1 --test-launcher-output="c:\b\s\w\it5h1vhs\scoped_dir5696_16379\results5696_15014\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-timeout=120000 --user-data-dir="c:\b\s\w\it5h1vhs\scoped_dir5696_16379\d5696_3021" --verbose [8188:8176:1207/172044.319:INFO:CONSOLE(126)] "Stopping cast streaming...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (126) [8188:8176:1207/172044.320:INFO:user_input_monitor_win.cc(170)] RegisterRawInputDevices() failed for RIDEV_REMOVE: The parameter is incorrect. (0x57) [8188:8176:1207/172044.321:INFO:CONSOLE(134)] "Stopping tab capture (MediaStreamTracks)...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (134) [8188:8176:1207/172044.321:INFO:CONSOLE(145)] "About to chrome.test.succeed()...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (145) [8188:8176:1207/172044.321:INFO:CONSOLE(0)] "[SUCCESS] sendTestPatterns", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance24.html?port=49445&autoThrottling=false&aesKey=000102030405060708090A0B0C0D0E0F&aesIvMask=0F0E0D0C0B0A09080706050403020100 (0) [8188:8176:1207/172044.321:INFO:CONSOLE(147)] "Did chrome.test.succeed()...", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (147) [8188:8176:1207/172044.322:ERROR:performance_test.cc(690)] RunTest: Extension subtest finished. Ending tracing... [8188:8176:1207/172044.420:ERROR:performance_test.cc(692)] RunTest: Stopping receiver... [8188:8176:1207/172044.422:ERROR:performance_test.cc(697)] RunTest: Shutting-down CastEnvironment... [8188:8176:1207/172044.423:ERROR:performance_test.cc(699)] RunTest: Analyzing... [8188:8176:1207/172044.425:INFO:performance_test.cc(454)] Retrieved 3 events for: Capture Received fatal exception EXCEPTION_ACCESS_VIOLATION Still waiting for the following processes to finish: ".\performance_browser_tests.exe" --disable-gpu-process-for-dx12-vulkan-info-collection --enable-gpu --gtest_also_run_disabled_tests --gtest_filter=CastV2PerformanceTest.Performance/0 --non-telemetry --single_process --test-launcher-jobs=1 --test-launcher-output="c:\b\s\w\it5h1vhs\scoped_dir5696_16379\results5696_15014\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-timeout=120000 --user-data-dir="c:\b\s\w\it5h1vhs\scoped_dir5696_16379\d5696_3021" --verbose [1/14] CastV2PerformanceTest.Performance/0 (TIMED OUT)
,
Dec 17
Thanks. Now that I have a way of repo'ing, I can proceed with investigation. :)
,
Dec 18
Issue 759866 has been merged into this issue.
,
Dec 22
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14e06639140000
,
Dec 22
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/14e06639140000 All of the runs failed. The most common error (20/20 runs) was: BuildError: Build failed: BUILD_FAILURE
,
Dec 22
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11a470a9140000
,
Dec 22
,
Dec 22
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/11a470a9140000
,
Dec 22
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12962805140000
,
Dec 22
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12962805140000
,
Dec 27
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14a0a013140000
,
Dec 27
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/105c0c0f140000
,
Dec 27
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/142be490940000
,
Dec 27
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/105c0c0f140000
,
Dec 28
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/142be490940000
,
Dec 28
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14c0b990940000
,
Dec 28
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14c0b990940000
,
Dec 28
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11541528940000
,
Dec 29
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/11541528940000
,
Dec 29
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14ae4667140000
,
Dec 29
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14ae4667140000
,
Dec 29
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/128404b8940000
,
Jan 2
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15c66c6a940000
,
Jan 3
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/15c66c6a940000
,
Jan 7
,
Jan 7
See conclusions about "long startup pauses/freezes" document in bug 177163 (comment #103). I chatted with Caleb about next steps: Through tons of experimenting (while I worked on bug 177163), it seems that some of the things I tried might have helped shave-off a few seconds. However, I was unable to fully-resolve the issue. I noticed today that the BUILD.gn target for performance_browser_tests does not match that of browser_tests, but it should match because many of the browser_tests build dependencies shut-off features that do "bad things" like heavy blocking I/O (e.g., when setting up a new user profile) and attempting to contact Google servers (!). In other words, moving everything in performance_browser_tests to browser_tests may turn out to resolve the issue; though, I will admit this is highly speculative. There's another reason to move the tests over to browser_tests: bug 804191. We've always wanted to run the performance_browser_tests in a "quick dry-run" mode in the CQ. This is to prevent breakage in the performance waterfall. So, the plan, going forward is: 1. Work on and resolve bug 804191: This will allow us to run the tests from browser_tests. By default, the tests should run in a "quick dry-run" mode (for the CQ). A separate command-line flag (e.g., "--full-performance-testing") can activate the full long-running performance testing. 2. Alter CastV2PerformanceTests and TabCapturePerformanceTests to not use the RunExtensionSubtest() infrastructure. Code from my experiments could be polished-up for this, so this shouldn't take much more effort. 3a. Delete chrome/test/perf/url_parse_perftest.cc. It has not been running for a long time, and has been replaced with other, more unit-level benchmarks. 3b. Resolve bug 435425 : Per discussion, we *do* want this performance test (mach port counts/leak-detection) revived, and it should run as a performance_browser_test. 4. Change the performance_browser_tests target to just execve("browser_tests") with the --full-performance-testing flag (and appropriate test timeout adjustments). 5. After all of the above, try re-enabling on Windows to see if things are working. Evaluate next steps from there.
,
Jan 8
,
Jan 8
Plan in #43 SGTM. Thanks for working on this!
,
Jan 8
For #4, instead of making the target execve("browser_tests"), you can still use the same executable as browser_tests. Just include a 'test_suite' in your entries for perf_data_generator.py per https://chromium.googlesource.com/chromium/src/+/refs/changes/84/1162584/5/tools/perf/core/perf_data_generator.py#61
and then include 'extra_args' to add the test filter and the timeouts. The only issue I can see with this is if the infrastructure in https://cs.chromium.org/chromium/src/testing/scripts/run_gtest_perf_test.py?q=run_gtest_perf_test.py&sq=package:chromium&dr&l=125 adds its own --gtest_filter argument (via a --isolated-script-test-filter argument from the recipe), such that you would have
./browser_tests --test_filter=X:Y --test_filter=A:B
In that case I'm not sure whether browser_tests would apply both arguments or just apply the later argument or what. But I guess you will have that issue either way. I'm happy to look into the --test_filter duplicate argument issue. Likely it's as easy as checking "rest_args" in the execute_perf_test() function and seeing it it already has --test_filter in it and in that case concatenating the filters.
,
Jan 8
+Erik (browser_tests owner?): do you know how browser_tests handles multiple --test_filter arguments?
,
Jan 8
So just a note that if you switch to the browser_tests isolate and script the test won't upload to the dashboard. For the CQ it sounds like you are just trying to manage breakages so that should be fine, more of a smoke test.
,
Jan 8
Ah, thanks Emily! Yes, we will still need a different isolate. The browser_tests binary will be the same, but the isolate will need to be different because we will need to specific testing/scripts/run_performance_tests.py as the "script". So we will still need the performance_browser_tests isolate in https://cs.chromium.org/chromium/src/testing/buildbot/gn_isolate_map.pyl Carry on, Yuri. I will guide you through these details once you get there.
,
Jan 8
re comment 48: I'm not sure and would have to try it out so it might be easier for someone else to have a look.
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd88438689feee4b523ebfd5173c8e7124642b14 commit dd88438689feee4b523ebfd5173c8e7124642b14 Author: Yuri Wiitala <miu@chromium.org> Date: Wed Jan 16 19:38:33 2019 Move url_parse_perftest.cc from chrome/test/perf to url/ Revive code that has been dead (accidentally?) since 2008, before Chromium was ever added to the original Subversion repository. Removed the WebKit-specific hacks, removed the "#ifdef 0" surrounding everything, fixed the compile errors, and updated for code style. Added a url_perftests BUILD target to run the tests. Bug: 908611 Change-Id: I309816ab2909d76d0908ade56495a501c5739ba3 Reviewed-on: https://chromium-review.googlesource.com/c/1400054 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#623331} [modify] https://crrev.com/dd88438689feee4b523ebfd5173c8e7124642b14/base/test/launcher/unit_test_launcher_ios.cc [modify] https://crrev.com/dd88438689feee4b523ebfd5173c8e7124642b14/chrome/test/BUILD.gn [delete] https://crrev.com/255173e63a775a3bcc3b5e8dd3df0b86e8bdceb8/chrome/test/perf/url_parse_perftest.cc [modify] https://crrev.com/dd88438689feee4b523ebfd5173c8e7124642b14/url/BUILD.gn [add] https://crrev.com/dd88438689feee4b523ebfd5173c8e7124642b14/url/run_all_perftests.cc [add] https://crrev.com/dd88438689feee4b523ebfd5173c8e7124642b14/url/url_parse_perftest.cc
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dcf5d81914b78d61351c78af4dd37a75d59fd3b commit 6dcf5d81914b78d61351c78af4dd37a75d59fd3b Author: Yuri Wiitala <miu@chromium.org> Date: Fri Jan 18 02:29:36 2019 Refactor performance_browser_tests to mitigate long start-up pauses. As outlined in the crbug, this change alters CastV2PerformanceTests and TabCapturePerformanceTests to stop using the RunExtensionSubtest() infrastructure. Instead, the browser test code explicitly loads an extension itself, explicitly loads a normal web page containing test content, and then messages the extension to start tab capture (and cast streaming). This should improve the general stability of the tests. Since CastV2PerformanceTests and TabCapturePerformanceTests need much of the same set-up and utilities, common code was factored into a base class. In addition, the concept of running these tests without a GPU was removed (a legacy Chromium compositing model that no longer applies). Bug: 908611 Change-Id: I45edc9c30ad2120ab8c2f4cd5aeedee967bc9d39 Reviewed-on: https://chromium-review.googlesource.com/c/1416090 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#623964} [modify] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/browser/extensions/api/cast_streaming/performance_test.cc [add] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/browser/extensions/api/tab_capture/tab_capture_performance_test_base.cc [add] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/browser/extensions/api/tab_capture/tab_capture_performance_test_base.h [modify] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc [modify] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/test/BUILD.gn [delete] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/chrome/test/data/extensions/api_test/cast_streaming/performance.js [delete] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/chrome/test/data/extensions/api_test/cast_streaming/performance24.html [delete] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/chrome/test/data/extensions/api_test/cast_streaming/performance30.html [delete] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/chrome/test/data/extensions/api_test/cast_streaming/performance60.html [add] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/test/data/extensions/api_test/cast_streaming/perftest_extension/background.js [add] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/test/data/extensions/api_test/cast_streaming/perftest_extension/manifest.json [add] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/test/data/extensions/api_test/tab_capture/balls.html [delete] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/chrome/test/data/extensions/api_test/tab_capture/performance.html [delete] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/chrome/test/data/extensions/api_test/tab_capture/performance.js [add] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/test/data/extensions/api_test/tab_capture/perftest_extension/background.js [add] https://crrev.com/6dcf5d81914b78d61351c78af4dd37a75d59fd3b/chrome/test/data/extensions/api_test/tab_capture/perftest_extension/manifest.json |
||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by crouleau@chromium.org
, Nov 26