Fix keyboard focus behavior for activity log page |
||
Issue descriptionFocus is lost when entering/exiting activity view with the keyboard. Repro1: Tab to "view activity log", hit enter. Expected: Activity view opens and the "back" arrow is focused. Actual: The "back" arrow is not focused (need to hit tab once again to focus it). Repro2: Exit activity view via tabbing on the "back" arrow Expected: The button that triggers the activity view in the "details view should be focused. Actual: Focused is lost.
,
Jan 17
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff808d82f7126425bafbea9425f5b963bf0a448c commit ff808d82f7126425bafbea9425f5b963bf0a448c Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Thu Jan 17 03:27:16 2019 [Extensions] Fix keyboard focus behavior for activity log page This CL fixes keyboard focus for the activity log page by introducing these 2 behaviors: 1) When the activity log page is entered either through the detail view or via url, the back button is focused. 2) When the user navigates back from the activity log page to the detail view page, the View Activity Log button/link is focused. Patchset >1 achieves this by using a flag stored in manager.js which indicates if the previous view was the activity log. This flag is set to true by an event which is fired when the user is about to exit the activity log and is set back to false by manager.js in onViewEnterStart. The detail view page uses the flag upon onViewEnterStart to determine which element should receive focus. This is safe as onViewEnterStart is bubbled up in manager.js later so the flag is safely reset. Bug: 908598 Change-Id: I58bfda628aa347357315f483f3859856c7264196 Reviewed-on: https://chromium-review.googlesource.com/c/1410123 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#623551} [modify] https://crrev.com/ff808d82f7126425bafbea9425f5b963bf0a448c/chrome/browser/resources/md_extensions/BUILD.gn [modify] https://crrev.com/ff808d82f7126425bafbea9425f5b963bf0a448c/chrome/browser/resources/md_extensions/activity_log.html [modify] https://crrev.com/ff808d82f7126425bafbea9425f5b963bf0a448c/chrome/browser/resources/md_extensions/activity_log.js [modify] https://crrev.com/ff808d82f7126425bafbea9425f5b963bf0a448c/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/ff808d82f7126425bafbea9425f5b963bf0a448c/chrome/browser/resources/md_extensions/detail_view.js [modify] https://crrev.com/ff808d82f7126425bafbea9425f5b963bf0a448c/chrome/browser/resources/md_extensions/manager.html [modify] https://crrev.com/ff808d82f7126425bafbea9425f5b963bf0a448c/chrome/browser/resources/md_extensions/manager.js [modify] https://crrev.com/ff808d82f7126425bafbea9425f5b963bf0a448c/chrome/test/data/webui/extensions/activity_log_test.js [modify] https://crrev.com/ff808d82f7126425bafbea9425f5b963bf0a448c/chrome/test/data/webui/extensions/detail_view_test.js
,
Today
(7 hours ago)
|
||
►
Sign in to add a comment |
||
Comment 1 by kelvinjiang@chromium.org
, Jan 12