New issue
Advanced search Search tips

Issue 908595 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Fix table appearance in activity log view

Project Member Reported by kelvinjiang@chromium.org, Nov 26

Issue description

The table showing activity log items has no headers. It is unclear what each column represents. It is also a bit inconsistently styled with other tables across WebUI, see https://imgur.com/a/K1yIjd1.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b234defa3d69945864c1d1e4ae5d62361843f4ef

commit b234defa3d69945864c1d1e4ae5d62361843f4ef
Author: Kelvin Jiang <kelvinjiang@chromium.org>
Date: Fri Jan 11 22:36:12 2019

[Extensions] Fix table appearance in activity log view

Change appearance of the activity log to be more inline with other webui
based tables. This CL also adds the functionality for activity log items
to be expanded and collapsed if an item is associated with one or more
urls.

A placeholder delete icon is also added for this CL. The functionality
for deleting specific activity log items will be implemented in a future
CL.

How to test changes:

1) Run chrome locally with the flag "enable-extension-activity-logging"
i.e. "out/Default/chrome --enable-extension-activity-logging"

2) navigate to chrome://extensions (install extensions if needed)

3) click on "Details" for an extension to see the details page.

4) click on "View Activity log" on the details page for that extension.

2b) Alternatively, the activity log can be found at:
chrome://extensions/?activity=<extension_id>

Design mock: https://screenshot.googleplex.com/WAtvuqifSDM.png

Screenshots:
Before: https://imgur.com/a/ZUIBtE9

After: https://imgur.com/a/5CCeQf9
With arrows showing alignment specs: https://imgur.com/a/DwPu51k
Old (Patchset 1) https://imgur.com/a/LzPGB5d

Bug:  908595 
Change-Id: I7d5f8aa5f5050bee929cdc4489f80114d7576d75
Reviewed-on: https://chromium-review.googlesource.com/c/1381375
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622193}
[modify] https://crrev.com/b234defa3d69945864c1d1e4ae5d62361843f4ef/chrome/browser/resources/md_extensions/activity_log_item.html
[modify] https://crrev.com/b234defa3d69945864c1d1e4ae5d62361843f4ef/chrome/browser/resources/md_extensions/activity_log_item.js
[modify] https://crrev.com/b234defa3d69945864c1d1e4ae5d62361843f4ef/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/b234defa3d69945864c1d1e4ae5d62361843f4ef/chrome/browser/resources/md_extensions/extensions_resources.grd
[modify] https://crrev.com/b234defa3d69945864c1d1e4ae5d62361843f4ef/chrome/browser/resources/md_extensions/shared_style.html
[add] https://crrev.com/b234defa3d69945864c1d1e4ae5d62361843f4ef/chrome/browser/resources/md_extensions/shared_vars.html
[modify] https://crrev.com/b234defa3d69945864c1d1e4ae5d62361843f4ef/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
[modify] https://crrev.com/b234defa3d69945864c1d1e4ae5d62361843f4ef/chrome/test/data/webui/extensions/activity_log_item_test.js

Comment 2 by kelvinjiang@chromium.org, Today (7 hours ago)

Status: Fixed (was: Assigned)

Sign in to add a comment