Issue metadata
Sign in to add a comment
|
[FCP++] 5.1%-81.9% regression in rendering.desktop/queueing_durations at 608888:609061 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 26
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/13db775c140000
,
Nov 26
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/13db775c140000 unsupported operand type(s) for +: 'float' and 'NoneType'
,
Nov 27
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/17738f4be40000
,
Nov 28
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/17738f4be40000 [FCP++] Enable FCP++ metrics via finch experiment by maxlg@chromium.org https://chromium.googlesource.com/chromium/src/+/4e243fc4a328acee8354c73e7c9df2facac9f3f7 queueing_durations: 0.4522 → 0.6402 (+0.1881) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/rendering-benchmarks
,
Nov 29
,
Jan 16
(6 days ago)
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/169f7742540000
,
Jan 16
(6 days ago)
I confused queueing_duration with Expected Queueing Time until I found the definition here: https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/metrics/rendering/queueing_duration.html?type=cs&q=queueing_duration+package:%5Echromium$&g=0&l=18 * This quantifies how out of sync the compositor and renderer threads are. It * is the amount of wall time that elapses between a * ScheduledActionSendBeginMainFrame event in the compositor thread and the * corresponding BeginMainFrame event in the main thread. I am surprised how FCP++ can relate to the queueing duration. FCP++'s main cost happens in pre-paint, which is way later than frame start.
,
Jan 16
(6 days ago)
,
Jan 20
(2 days ago)
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/169f7742540000 unsupported operand type(s) for +: 'float' and 'NoneType'
,
Today
(11 hours ago)
+Ehsan, do you know how the queueing durations metric may relate to the implementation of FCP++? Here's are something FCP++ is doing, do you see anything suspicous? - FCP++ runs swap-time callback as a task on mainthread - FCP++ runs timer callback as a task on mainthread - FCP++ records image/text at pre-paint stage - FCP++ has a hook in LayoutObject::WillBeRemovedFromTree FCP++ design doc: https://docs.google.com/document/d/1DRVd4a2VU8-yyWftgOparZF-sf16daf0vfbsHuz2rws/edit# Implementation: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_timing_detector.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 26