DNS histograms don't notice when internal resolver is enabled |
||
Issue descriptionMost Lollipop devices aren't using Chrome's internal DNS resolver even though it is defaulted to enabled. Most Marshmallow devices are using it. I've been printf debugging and there appears to be some race during browser startup. I haven't fully tracked it down yet. Looks like if DnsConfigServicePosix parses the DNS config before HostResolverImpl is created then there is not DNS changed signal produced later and the internal resolver is disabled. If HostResolverImpl is created before DnsConfigServicePosix parses the config, then there is a later DNS changed signal that causes the HostResolverImpl to enable the internal resolver.
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e501e3d04037d0fe9b3ecb103be7423bc0175b6 commit 1e501e3d04037d0fe9b3ecb103be7423bc0175b6 Author: Paul Jensen <pauljensen@chromium.org> Date: Thu Nov 29 20:38:48 2018 Fix my DNS histograms to notice when internal resolver is enabled Previously my DNS histograms incorrectly thought the internal resolver was not used when it in fact was. Bug: 908535 Change-Id: I1c3a8d41298b91d23236649de72299c47cf93926 Reviewed-on: https://chromium-review.googlesource.com/c/1351742 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#612343} [modify] https://crrev.com/1e501e3d04037d0fe9b3ecb103be7423bc0175b6/net/dns/host_resolver_impl.cc [modify] https://crrev.com/1e501e3d04037d0fe9b3ecb103be7423bc0175b6/net/dns/host_resolver_impl.h
,
Nov 30
Fix went into 72.0.3626.0 |
||
►
Sign in to add a comment |
||
Comment 1 by pauljensen@chromium.org
, Nov 27Summary: DNS histograms don't notice when internal resolver is enabled (was: Race causing most Lollipop and older devices to not use internal DNS resolver)