Fix InterceptNavigationDelegateTest assumptions about user activation |
|||
Issue descriptionWe have three tests in InterceptNavigationDelegateTest that rely on assumptions around Chrome's old user gesture model (UserGestureToken): The following two expects something that's a long standing bug in Chrome (Issue 760848): - testNavigationFromXHRCallback - testNavigationFromXHRCallbackAndShortTimeout And this one expects stack-scoped tokens which are not there in UAv2: - testNavigationFromImageOnLoad All these three fails when UAv2 is enabled.
,
Nov 26
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f51287c7c9bab2a55aa8b10349150262037a68e3 commit f51287c7c9bab2a55aa8b10349150262037a68e3 Author: Mustaq Ahmed <mustaq@google.com> Date: Tue Nov 27 14:47:34 2018 Fix three tests in Android InterceptNavigationDelegateTests. These tests rely on assumptions on Chrome's old user gesture model. This CL fixes the assumptions for the new model (UAv2). Bug: 908531 Change-Id: I3d290489075f81f5c8fd414c050d1beabab48488 Reviewed-on: https://chromium-review.googlesource.com/c/1351570 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#611100} [modify] https://crrev.com/f51287c7c9bab2a55aa8b10349150262037a68e3/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/f51287c7c9bab2a55aa8b10349150262037a68e3/chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java [modify] https://crrev.com/f51287c7c9bab2a55aa8b10349150262037a68e3/chrome/browser/android/chrome_feature_list.cc
,
Nov 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mustaq@chromium.org
, Nov 26