New issue
Advanced search Search tips

Issue 908519 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Convert AccountInvestigator away from SiginManager

Project Member Reported by toniki...@chromium.org, Nov 26

Issue description

APIs:

IsAuthenticated
GetAuthenticatedAccountInfo

+ unit tests
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e4094bf4b581c1451b5e514c5627563d86792b9

commit 7e4094bf4b581c1451b5e514c5627563d86792b9
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Nov 27 14:59:10 2018

[s13n] Convert AccountInvestigator away from SiginManager

Ideally, it should be possible to use the IdentityTestEnvironment
ctor that takes only the boolean paramater, and constructs the
signin and token handler objects internally. But some tests
tweak the PrefService instance, which is not exposed by
IdentityTestEnvironment APIs.

Bots are true but mac_chromium_rel_gn, which is sick. Adding "notry".

NOTRY=true

BUG= 908519 

Change-Id: I6b4c9076c61079b45da76960c5269fd5ca8397a8
Reviewed-on: https://chromium-review.googlesource.com/c/1351152
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611106}
[modify] https://crrev.com/7e4094bf4b581c1451b5e514c5627563d86792b9/chrome/browser/signin/account_investigator_factory.cc
[modify] https://crrev.com/7e4094bf4b581c1451b5e514c5627563d86792b9/components/signin/core/browser/account_investigator.cc
[modify] https://crrev.com/7e4094bf4b581c1451b5e514c5627563d86792b9/components/signin/core/browser/account_investigator.h
[modify] https://crrev.com/7e4094bf4b581c1451b5e514c5627563d86792b9/components/signin/core/browser/account_investigator_unittest.cc

Status: Fixed (was: Started)
Cc: toniki...@chromium.org
 Issue 797944  has been merged into this issue.

Sign in to add a comment