New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 908517 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Flakiness in http/tests/devtools/sources/debugger/live-edit-no-reveal.js

Project Member Reported by erikc...@chromium.org, Nov 26

Issue description

In this build: 
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/132726

We see that http/tests/devtools/sources/debugger/live-edit-no-reveal.js fails in 'with patch' and 'retry with patch' steps. We didn't run 'retry without patch' since the CL changed gn_isolate_map.pyl:

https://chromium-review.googlesource.com/c/chromium/src/+/1337347/5

When the build was retried, the test passed:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/132777

Date:11-19

The text diff:
"""
-Cursor position is: (2, 4).
+Cursor position is: (8, 15).
"""

The test was previously disabled. It was enabled and deflaked on 10-02:
https://chromium-review.googlesource.com/c/chromium/src/+/1258249


 
Cc: kozyatinskiy@chromium.org atotic@chromium.org dgozman@chromium.org e...@chromium.org
Components: Platform>DevTools Blink
When I run the test on my Windows device by itself, it deterministically fails with the same error. This suggests that the test only passes when the test is run in a batch and state is carried over from previous tests.

I'm going to disable the test.
Cc: chanli@chromium.org liaoyuke@chromium.org st...@chromium.org
+ lioayuke: I don't see this flaky test when I search on "Ranked Flaky Tests". https://findit-for-me.appspot.com/ranked-flakes?test_filter=http%2Ftests%2Fdevtools%2Fsources%2Fdebugger%2Flive-edit-no-reveal.js

Am I using it wrong?
The most recent detected occurrence for this test is on 2018-11-19.

Since it's over a week ago, it'll not show on the dashboard.

Though now I'm thinking maybe we should add an option to show historical occurrences for a searched flake. 

And for this particular flake, here are the occurrences: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYwsSBUZsYWtlIlhjaHJvbWl1bUB3ZWJraXRfbGF5b3V0X3Rlc3RzQGh0dHAvdGVzdHMvZGV2dG9vbHMvc291cmNlcy9kZWJ1Z2dlci9saXZlLWVkaXQtbm8tcmV2ZWFsLmpzDA 

Thanks for the link. I guess we just missed the 7 day threshold. Is there a UI that I can use to see the same results you linked to? I'm not sure how you determined the key.
I actually looked for the test in our datastore to get the key. So currently there's no way for non-findit-admin users to directly get to the page.

How frequently do you need to check flakes that have not happened within a week? I can adjust my priority to support searching for any flake regardless the last time it happened if this is a popular feature request.
This is a low-priority request, but thanks for offering. :)

I mostly thought that I was misusing the existing UI. In the future, if no results show up, I'll try pinging you to see if I'm misusing the UI or if the flake just occurs relatively infrequently. Also, we're in prime holiday season, and I imagine that there were much fewer CQ runs last week compared to previous weeks.

SG. Thanks for clarifying :)
Components: -Blink
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fcbf6597b312d0d6e2a725fb131b662efd35c75

commit 1fcbf6597b312d0d6e2a725fb131b662efd35c75
Author: erikchen <erikchen@chromium.org>
Date: Tue Nov 27 17:31:16 2018

Disable live-edit-no-reveal.js layout test.

The test was enabled here:
https://chromium-review.googlesource.com/c/chromium/src/+/1258249/

The test deterministically fails when run by itself. This failure is
reproducible on both trybots and a local device.

This CL reverts the change made by the CL mentioned above. It intentionally sets
a super broad set of TestExpectations as I have not investigated the behavior of
the test on platforms other than Windows. The test was observed to be flaky on
Linux -- this CL removes that TestExpectation. The test was observed by Find-It
to be flaky on macOS. See
https://bugs.chromium.org/p/chromium/issues/detail?id=908517#c3.

Bug:  908517 ,  789139 
Change-Id: Idfa9603b093c9abc4c337c33a4a3e061482d9dd5
Reviewed-on: https://chromium-review.googlesource.com/c/1351491
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611167}
[modify] https://crrev.com/1fcbf6597b312d0d6e2a725fb131b662efd35c75/third_party/blink/web_tests/TestExpectations

Owner: alph@chromium.org
Status: Assigned (was: Untriaged)
Status: Archived (was: Assigned)
Test failures are processed as a part of a dedicated triage, bulk-closing the bugs.

Sign in to add a comment