OOBE handlers automatically prefix JS calls with a string. This makes it hard to trace the code. Let's eliminate the automatic prefixing.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/607c07f8b5ff58946efe8368ac33bc0be76e70fa commit 607c07f8b5ff58946efe8368ac33bc0be76e70fa Author: Jacob Dufault <jdufault@google.com> Date: Tue Nov 27 23:39:15 2018 cros: Rename CallJS to CallJSWithPrefix. Prefix-based calls make it hard to search the code-base. They save some typing but at the cost of readability. There will be a set of follow-up CLs that reintroduce CallJS that does not use a prefix. Then, CallJSWithPrefix will be removed. Bug: 908498 Change-Id: I495c097be210ece3ef2f7144e1b5371fe13c7406 Reviewed-on: https://chromium-review.googlesource.com/c/1351455 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#611418} [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/app_downloading_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/assistant_optin_flow_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/base_webui_handler.h [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/fingerprint_setup_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/sync_consent_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc [modify] https://crrev.com/607c07f8b5ff58946efe8368ac33bc0be76e70fa/components/login/screens/screen_context.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99 commit 78f4c62678dce8c7d3ffa14623dc0f7df7a65c99 Author: Jacob Dufault <jdufault@google.com> Date: Wed Jan 09 22:15:07 2019 cros: Migrate the simple CallJSWithPrefix to CallJS. Bug: 908498 Change-Id: I6da60ef794112a6f9e06bcca48c9681915be5e11 Reviewed-on: https://chromium-review.googlesource.com/c/1351572 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#621324} [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/base_webui_handler.h [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/fingerprint_setup_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/sync_consent_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc [modify] https://crrev.com/78f4c62678dce8c7d3ffa14623dc0f7df7a65c99/components/login/screens/screen_context.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/710c57432db9e9b80174d9ecb07680a5b1964aad commit 710c57432db9e9b80174d9ecb07680a5b1964aad Author: Jacob Dufault <jdufault@google.com> Date: Tue Jan 22 21:52:54 2019 cros: Remove BaseWebUIHandler::AddPrefixedCallback Use BaseWebUIHandler::AddCallback instead. Bug: 908498 Change-Id: I86e1fdf49139d4f026cac0a2acf4d0b5e3c5e57c Reviewed-on: https://chromium-review.googlesource.com/c/1351508 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#624941} [modify] https://crrev.com/710c57432db9e9b80174d9ecb07680a5b1964aad/chrome/browser/ui/webui/chromeos/login/assistant_optin_flow_screen_handler.cc [modify] https://crrev.com/710c57432db9e9b80174d9ecb07680a5b1964aad/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc [modify] https://crrev.com/710c57432db9e9b80174d9ecb07680a5b1964aad/chrome/browser/ui/webui/chromeos/login/base_webui_handler.h [modify] https://crrev.com/710c57432db9e9b80174d9ecb07680a5b1964aad/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc [modify] https://crrev.com/710c57432db9e9b80174d9ecb07680a5b1964aad/chrome/browser/ui/webui/chromeos/login/marketing_opt_in_screen_handler.cc [modify] https://crrev.com/710c57432db9e9b80174d9ecb07680a5b1964aad/chrome/browser/ui/webui/chromeos/login/sync_consent_screen_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a860730713a37da77f04a78a4b5f24d49c895c1 commit 3a860730713a37da77f04a78a4b5f24d49c895c1 Author: Jacob Dufault <jdufault@google.com> Date: Tue Jan 22 22:00:04 2019 cros: Migrate CallJSWithPrefixOrDefer to CallJSOrDefer Bug: 908498 Change-Id: I7c8db276f19f4f3a9bcb58019738a0a4c8e389c8 Reviewed-on: https://chromium-review.googlesource.com/c/1351792 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#624946} [modify] https://crrev.com/3a860730713a37da77f04a78a4b5f24d49c895c1/chrome/browser/ui/webui/chromeos/login/base_webui_handler.h [modify] https://crrev.com/3a860730713a37da77f04a78a4b5f24d49c895c1/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/3a860730713a37da77f04a78a4b5f24d49c895c1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
Comment 1 by jdufault@chromium.org
, Nov 26