Feature description: add UI affordancfe and ability to go back to the tab with media content from the Picture-in-Picture window in Chrome. More details here: https://docs.google.com/document/d/1JXyGvWEG35NhiPUXJfSqJ0TQzELFUbOVx8L29fTt0hk/edit#heading=h.yh03qdihbbpd Eng owner: mlamouri@ Product owner: denizz@
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfc3585fb109ad40c7ddb19c9048018c09291acb commit dfc3585fb109ad40c7ddb19c9048018c09291acb Author: François Beaufort <beaufort.francois@gmail.com> Date: Tue Dec 18 05:30:38 2018 Add back-to-tab Picture-in-Picture window button This CL adds a button to the Picture-in-Picture window that user can click to close the window and focuses back original tab that contains video that was in Picture-in-Picture. Screenshot: https://i.imgur.com/2Usfrb8.png Bug: 908497 Change-Id: I02a3f55387ad92a4d5263734737c2b35ebff2a75 Reviewed-on: https://chromium-review.googlesource.com/c/1354940 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#617385} [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/chrome/app/generated_resources.grd [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.cc [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.h [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/chrome/browser/ui/BUILD.gn [add] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/chrome/browser/ui/views/overlay/back_to_tab_image_button.cc [add] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/chrome/browser/ui/views/overlay/back_to_tab_image_button.h [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/chrome/browser/ui/views/overlay/overlay_window_views.h [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h [modify] https://crrev.com/dfc3585fb109ad40c7ddb19c9048018c09291acb/content/public/browser/picture_in_picture_window_controller.h
Comment 1 by edcourtney@chromium.org
, Dec 14