Various Content Controls (Buttons, Autocomplete) Use a White Foreground on White Background in Dark Mode |
||||||||
Issue description1) Fire up Chrome with --force-dark-mode 2) Navigate to crbug.com 3) Create a new issue. ACTUAL: Buttons and autocomplete text foreground are white / low contrast. EXPECTED: Buttons and autocomplete text foreground have high contrast.
,
Nov 27
I'm running Mojave 10.14.1 My Mojave is certainly in Dark Mode (the menubar is dark and Finder renders in Dark Mode).
,
Nov 27
And now it repros. Who knows!? Looks like WebKit uses a scoped appearance helper when pulling system colors, I'm guessing using the prefers-color-scheme media query (Issue 889087), though I didn't dig far enough to be sure if this is the specific thing that gets plumbed down. This seems like a fine approach to me.
,
Nov 29
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92e3fdd3a77ca97233868ca01b7a4888399e8253 commit 92e3fdd3a77ca97233868ca01b7a4888399e8253 Author: Leonard Grey <lgrey@chromium.org> Date: Fri Nov 30 19:42:50 2018 Mac: Ensure web content system colors use light appearance in Mojave Bug: 908486 Change-Id: I762b8a74fcb98fb99218cee590da7cf003dec8cf Reviewed-on: https://chromium-review.googlesource.com/c/1356870 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#612732} [modify] https://crrev.com/92e3fdd3a77ca97233868ca01b7a4888399e8253/content/browser/theme_helper_mac.mm
,
Dec 3
Buttons fixed, dropdowns: not yet
,
Dec 4
,
Dec 6
,
Dec 6
,
Dec 6
,
Dec 11
,
Dec 12
Should be fixed as of https://chromium-review.googlesource.com/c/chromium/src/+/1367936 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by lgrey@chromium.org
, Nov 27