Eliminate build steps that extract or zip files unnecessarily |
|||
Issue descriptionThere are a few spots in our build that zip files or extract them as intermediate steps, which should either be done within the main step, or just not done at all. E.g.: * Generating .java files, and then zipping them separately * For these, we should just not bother zipping them. * Cronet: Extracts .class files, and then zips them in a separate step * This should all happen in one step rather than two Update! There's only one instance of this left that I can find: java_cpp_template(). For this, I think we should: a) Make the python script output a .srcjar directly, b) Have the python extract the java package rather than specify it in GN. c) Maybe also have it sniff the class name (javac.py already has sniffing code, so just need to use that).
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4e7bed3e85a67d0c88f017c5d4dc59405776866 commit f4e7bed3e85a67d0c88f017c5d4dc59405776866 Author: agrieve <agrieve@chromium.org> Date: Mon Nov 26 20:55:33 2018 Revert "Cronet: Simplify Android GN logic for srcjars by not using them" This reverts commit 27bd2d6ffb68067d7b771524ece94cf9a579f00c. Reason for revert: Broke this bot: https://logs.chromium.org/logs/chrome/bb/internal.client.clank/arm-builder/18748/+/recipes/steps/compile/0/stdout Original change's description: > Cronet: Simplify Android GN logic for srcjars by not using them > > No need to zip up the generated source just to unzip it again :P > > Bug: 908479 > Change-Id: Iac6982eb4b436a7e33c53b79f239fe2954fa4f11 > Reviewed-on: https://chromium-review.googlesource.com/c/1349871 > Commit-Queue: agrieve <agrieve@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610889} TBR=pauljensen@chromium.org,agrieve@chromium.org Change-Id: I9daab0436aa1ff7605f427ab815adff711c0d59d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908479 Reviewed-on: https://chromium-review.googlesource.com/c/1351575 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610938} [modify] https://crrev.com/f4e7bed3e85a67d0c88f017c5d4dc59405776866/components/cronet/android/BUILD.gn
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/282d95d76a005959d5366fcd01859430dfd5883a commit 282d95d76a005959d5366fcd01859430dfd5883a Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Nov 27 15:05:01 2018 Reland "Cronet: Simplify Android GN logic for srcjars by not using them" No need to zip up the generated source just to unzip it again :P This reverts commit f4e7bed3e85a67d0c88f017c5d4dc59405776866. Reason for reland: Fixed missing deps in __final_jni template TBR=pauljensen@chromium.org,agrieve@chromium.org Bug: 908479 Change-Id: I1177d550eb33737f47192bd70db5358c6392598c Reviewed-on: https://chromium-review.googlesource.com/c/1351930 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#611108} [modify] https://crrev.com/282d95d76a005959d5366fcd01859430dfd5883a/build/config/android/rules.gni [modify] https://crrev.com/282d95d76a005959d5366fcd01859430dfd5883a/components/cronet/android/BUILD.gn
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61c12ee7d4154b5cdf052802021cf432cd6ebab8 commit 61c12ee7d4154b5cdf052802021cf432cd6ebab8 Author: agrieve <agrieve@chromium.org> Date: Tue Nov 27 21:24:45 2018 Revert "Reland "Cronet: Simplify Android GN logic for srcjars by not using them"" This reverts commit 282d95d76a005959d5366fcd01859430dfd5883a. Reason for revert: Still has a missing dep: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928671892382176864/+/steps/compile__with_patch_/0/stdout Original change's description: > Reland "Cronet: Simplify Android GN logic for srcjars by not using them" > > No need to zip up the generated source just to unzip it again :P > > This reverts commit f4e7bed3e85a67d0c88f017c5d4dc59405776866. > > Reason for reland: Fixed missing deps in __final_jni template > > TBR=pauljensen@chromium.org,agrieve@chromium.org > > Bug: 908479 > Change-Id: I1177d550eb33737f47192bd70db5358c6392598c > Reviewed-on: https://chromium-review.googlesource.com/c/1351930 > Commit-Queue: agrieve <agrieve@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611108} TBR=pauljensen@chromium.org,agrieve@chromium.org Change-Id: I5f10f94e023f7413fb19d85624013fbddcb732a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908479 Reviewed-on: https://chromium-review.googlesource.com/c/1352516 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#611329} [modify] https://crrev.com/61c12ee7d4154b5cdf052802021cf432cd6ebab8/build/config/android/rules.gni [modify] https://crrev.com/61c12ee7d4154b5cdf052802021cf432cd6ebab8/components/cronet/android/BUILD.gn
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85a83882a59aa9e6ae7267ecea4da0fe64d87d71 commit 85a83882a59aa9e6ae7267ecea4da0fe64d87d71 Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Nov 28 15:22:10 2018 Reland #2 Cronet: Simplify Android GN logic for srcjars by not using them No need to zip up the generated source just to unzip it again :P This reverts commit 61c12ee7d4154b5cdf052802021cf432cd6ebab8. Reason for reland: Fix missing deps for realz TBR=pauljensen@chromium.org,agrieve@chromium.org Bug: 908479 Change-Id: Ib3108f01ad49a68aa1a2d6de303aaa79d899ec8f Reviewed-on: https://chromium-review.googlesource.com/c/1352520 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#611698} [modify] https://crrev.com/85a83882a59aa9e6ae7267ecea4da0fe64d87d71/base/android/jni_generator/jni_registration_generator.py [modify] https://crrev.com/85a83882a59aa9e6ae7267ecea4da0fe64d87d71/build/config/android/rules.gni [modify] https://crrev.com/85a83882a59aa9e6ae7267ecea4da0fe64d87d71/components/cronet/android/BUILD.gn
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a52806d08dd7e18975257e131b8a1528c5a116ba commit a52806d08dd7e18975257e131b8a1528c5a116ba Author: Andrew Grieve <agrieve@chromium.org> Date: Thu Dec 06 15:07:05 2018 Android: Don't bother creating .srcjar for generated chrome version file Bug: 908479 Change-Id: I6b6d50319143a5b4135c446d7723d6a70fc3fecc Reviewed-on: https://chromium-review.googlesource.com/c/1364610 Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#614352} [modify] https://crrev.com/a52806d08dd7e18975257e131b8a1528c5a116ba/chrome/android/BUILD.gn
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09e78caaf8a95c230efdd010b1c11a828d7a421d commit 09e78caaf8a95c230efdd010b1c11a828d7a421d Author: Andrew Grieve <agrieve@chromium.org> Date: Fri Dec 07 01:00:28 2018 Android: Don't create .srcjar for generated version_info file Bug: 908479 Change-Id: Ibb6192e9c77342b67e0342e724de18c87a021b1f Reviewed-on: https://chromium-review.googlesource.com/c/1364611 Reviewed-by: Paul Miller <paulmiller@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#614511} [modify] https://crrev.com/09e78caaf8a95c230efdd010b1c11a828d7a421d/components/version_info/android/BUILD.gn
,
Dec 11
,
Jan 14
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Nov 26