New issue
Advanced search Search tips

Issue 908472 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android MediaFormat is misconfigured for AAC

Project Member Reported by auy...@opera.com, Nov 26

Issue description

Chrome Version: 71.0.3563.0 (Developer Build)
OS: Android

What steps will reproduce the problem?
(1) Build chrome_public_apk with "proprietary_codecs = true" gn arg but without "ffmpeg_branding = "Chrome"" so that it'll decode AAC using platform codecs through MediaCodecAudioDecoder.
(2) Go to https://view.ly/v/uVSW91cTUMmn
(3) Play the video

What is the expected result?
Video and audio plays

What happens instead?
Video plays. Audio is very choppy.

The audio is encoded in AAC Parametric Stereo profile so AudioSpecificConfig data structure contains extension config. The frequency_index is overwritten by the extension config that is read in GetCodecSpecificDataForAudio function. It should not be overwritten.
 
Owner: auy...@opera.com
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61dc46849c5b204027d29d3026e52b3e7d8835cb

commit 61dc46849c5b204027d29d3026e52b3e7d8835cb
Author: Attila Uygun <auygun@opera.com>
Date: Wed Nov 28 10:34:08 2018

Fix frequency index set for AAC Parametric Stereo profile.

Bug:  908472 
Change-Id: I2d67e946f46a83b930a22ace762cb064e73bb8fb
Reviewed-on: https://chromium-review.googlesource.com/c/1350894
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Attila Uygun <auygun@opera.com>
Cr-Commit-Position: refs/heads/master@{#611634}
[modify] https://crrev.com/61dc46849c5b204027d29d3026e52b3e7d8835cb/media/base/android/media_codec_bridge_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment