New issue
Advanced search Search tips

Issue 908461 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rethink MockRTCPeerConnectionHandler

Project Member Reported by hbos@chromium.org, Nov 26

Issue description

MockRTCPeerConnectionHandler is currently wired to do NO-OP things or create "dummy" objects that return default values.

1. Should we rename it to DummyRTCPeerConnectionHandler? FakeRTCPeerConnectionHandler?

2. Should we change it into an actual mock using GMOCK?

3. Given that these fake/dummy implementations more often than not create more problems than they solve, should we consider deleting this class in favor of using the real RTCPeerConnectionHandler?

 
Components: -Blink>WebRTC Blink>WebRTC>PeerConnection
Owner: hbos@chromium.org

Sign in to add a comment