New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 908451: Support localization in GCPW

Reported by tienmai@google.com, Nov 26 Project Member

Issue description

Ensure that localization is supported fully in GCPW for
1. The windows logon UI and texts shown by GCPW
2. The GLS used by GCPW to perform sign in (currently Chrome)
 

Comment 1 by bugdroid1@chromium.org, Nov 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/241875c2420578c76a53616c4fefdc264653a6b2

commit 241875c2420578c76a53616c4fefdc264653a6b2
Author: Tien Mai <tienmai@chromium.org>
Date: Mon Nov 26 16:51:33 2018

Pass the UI language to Chrome when starting it as GLS of GCPW

- Checks the current thread preferred UI language and pass it onto
Chrome so that it presents itself with a language that matches the
logon screen.

Bug:  908451 
Change-Id: I8f40a1501baabfe592cde6eea2c74bd19d47e9df
Reviewed-on: https://chromium-review.googlesource.com/c/1351249
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610860}
[modify] https://crrev.com/241875c2420578c76a53616c4fefdc264653a6b2/chrome/credential_provider/gaiacp/gaia_credential_base.cc

Comment 2 by tienmai@chromium.org, Nov 27

Status: Started (was: Untriaged)

Comment 3 by tienmai@google.com, Dec 14

Status: Fixed (was: Started)

Comment 4 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61e28c177145da085bdf576f2db782c5402213da

commit 61e28c177145da085bdf576f2db782c5402213da
Author: Tien Mai <tienmai@chromium.org>
Date: Fri Dec 14 16:01:10 2018

Embed all localized strings into GCPW dll directly to allow localization.

- Code that generates the strings to be embedded into an
executable in chrome/installer/util was adapted so that it could be
used generically anyone.
- Used this common code to embed the strings into gaia1_0.dll and use
them directly in code.

Bug:  908451 
Change-Id: I6f40dc08aee8553358c775aeda82b8d0ed7a5db2
Reviewed-on: https://chromium-review.googlesource.com/c/1352576
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616695}
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/base/BUILD.gn
[add] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/base/win/embedded_i18n/create_string_rc.py
[add] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/base/win/embedded_i18n/generate_embedded_i18n.gni
[add] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/base/win/embedded_i18n/language_selector.cc
[add] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/base/win/embedded_i18n/language_selector.h
[add] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/base/win/embedded_i18n/language_selector_unittest.cc
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/BUILD.gn
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/dllmain.cc
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/gaia_credential.h
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/gaia_credential_base.h
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/gaia_credential_provider.h
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/gaia_resources.grd
[add] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/gaia_static_resources.grd
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/gcp_utils.cc
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/credential_provider/gaiacp/gcp_utils.h
[delete] https://crrev.com/99ce1976dc08de8ae59a7c378668ab773991115d/chrome/credential_provider/gaiacp/strings/gaia_resources_en-US.xtb
[delete] https://crrev.com/99ce1976dc08de8ae59a7c378668ab773991115d/chrome/credential_provider/gaiacp/strings/gaia_resources_fake-bidi.xtb
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/installer/util/BUILD.gn
[modify] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/installer/util/l10n_string_util.cc
[delete] https://crrev.com/99ce1976dc08de8ae59a7c378668ab773991115d/chrome/installer/util/language_selector.cc
[delete] https://crrev.com/99ce1976dc08de8ae59a7c378668ab773991115d/chrome/installer/util/language_selector.h
[delete] https://crrev.com/99ce1976dc08de8ae59a7c378668ab773991115d/chrome/installer/util/language_selector_unittest.cc
[add] https://crrev.com/61e28c177145da085bdf576f2db782c5402213da/chrome/installer/util/prebuild/create_installer_string_rc.py
[delete] https://crrev.com/99ce1976dc08de8ae59a7c378668ab773991115d/chrome/installer/util/prebuild/create_string_rc.py

Comment 5 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57

commit f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57
Author: Nico Weber <thakis@chromium.org>
Date: Fri Dec 14 16:21:31 2018

Revert "Embed all localized strings into GCPW dll directly to allow localization."

This reverts commit 61e28c177145da085bdf576f2db782c5402213da.

Reason for revert: Broke compile on
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20Win%20Builder/102191

../../chrome/credential_provider/gaiacp/gcp_utils.cc(46,10):  fatal error: 'chrome/credential_provider/gaiacp/gaia_resources.h' file not found
#include "chrome/credential_provider/gaiacp/gaia_resources.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Looks like this is probably missing a gn dep to make sure the header
is generated by the time it is included.

Original change's description:
> Embed all localized strings into GCPW dll directly to allow localization.
> 
> - Code that generates the strings to be embedded into an
> executable in chrome/installer/util was adapted so that it could be
> used generically anyone.
> - Used this common code to embed the strings into gaia1_0.dll and use
> them directly in code.
> 
> Bug:  908451 
> Change-Id: I6f40dc08aee8553358c775aeda82b8d0ed7a5db2
> Reviewed-on: https://chromium-review.googlesource.com/c/1352576
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Commit-Queue: Tien Mai <tienmai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616695}

TBR=rogerta@chromium.org,thakis@chromium.org,grt@chromium.org,tienmai@chromium.org

Change-Id: I8a26588d125713cd2a1c6c925a5adbbf91e47219
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  908451 
Reviewed-on: https://chromium-review.googlesource.com/c/1378405
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616702}
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/base/BUILD.gn
[delete] https://crrev.com/71e551ac476ec9b247be8f19c6eb696632d90cf4/base/win/embedded_i18n/create_string_rc.py
[delete] https://crrev.com/71e551ac476ec9b247be8f19c6eb696632d90cf4/base/win/embedded_i18n/generate_embedded_i18n.gni
[delete] https://crrev.com/71e551ac476ec9b247be8f19c6eb696632d90cf4/base/win/embedded_i18n/language_selector.cc
[delete] https://crrev.com/71e551ac476ec9b247be8f19c6eb696632d90cf4/base/win/embedded_i18n/language_selector.h
[delete] https://crrev.com/71e551ac476ec9b247be8f19c6eb696632d90cf4/base/win/embedded_i18n/language_selector_unittest.cc
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/BUILD.gn
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/dllmain.cc
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/gaia_credential.h
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/gaia_credential_base.h
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/gaia_credential_provider.h
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/gaia_resources.grd
[delete] https://crrev.com/71e551ac476ec9b247be8f19c6eb696632d90cf4/chrome/credential_provider/gaiacp/gaia_static_resources.grd
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/gcp_utils.cc
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/gcp_utils.h
[add] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/strings/gaia_resources_en-US.xtb
[add] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/credential_provider/gaiacp/strings/gaia_resources_fake-bidi.xtb
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/installer/util/BUILD.gn
[modify] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/installer/util/l10n_string_util.cc
[add] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/installer/util/language_selector.cc
[add] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/installer/util/language_selector.h
[add] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/installer/util/language_selector_unittest.cc
[delete] https://crrev.com/71e551ac476ec9b247be8f19c6eb696632d90cf4/chrome/installer/util/prebuild/create_installer_string_rc.py
[add] https://crrev.com/f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57/chrome/installer/util/prebuild/create_string_rc.py

Comment 6 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0006bcec361a8197eb9b16f6e4ec5911b47e95e

commit e0006bcec361a8197eb9b16f6e4ec5911b47e95e
Author: Tien Mai <tienmai@chromium.org>
Date: Fri Dec 14 18:46:59 2018

Fix dependency error and re-land:

Embed all localized strings into GCPW dll directly to allow localization.

- Code that generates the strings to be embedded into an
executable in chrome/installer/util was adapted so that it could be
used generically anyone.
- Used this common code to embed the strings into gaia1_0.dll and use
them directly in code.

Bug:  908451 
Change-Id: Icc9b29c46afc93f2684cfe22370db12386907014
Reviewed-on: https://chromium-review.googlesource.com/c/1352576
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616695}
Reviewed-on: https://chromium-review.googlesource.com/c/1378247
Cr-Commit-Position: refs/heads/master@{#616762}
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/base/BUILD.gn
[add] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/base/win/embedded_i18n/create_string_rc.py
[add] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/base/win/embedded_i18n/generate_embedded_i18n.gni
[add] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/base/win/embedded_i18n/language_selector.cc
[add] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/base/win/embedded_i18n/language_selector.h
[add] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/base/win/embedded_i18n/language_selector_unittest.cc
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/BUILD.gn
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/dllmain.cc
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/gaia_credential.h
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/gaia_credential_base.h
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/gaia_credential_provider.h
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/gaia_resources.grd
[add] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/gaia_static_resources.grd
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/gcp_utils.cc
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/credential_provider/gaiacp/gcp_utils.h
[delete] https://crrev.com/d25d640f7f2ce6bae0a0c7f5711e0af79e622791/chrome/credential_provider/gaiacp/strings/gaia_resources_en-US.xtb
[delete] https://crrev.com/d25d640f7f2ce6bae0a0c7f5711e0af79e622791/chrome/credential_provider/gaiacp/strings/gaia_resources_fake-bidi.xtb
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/installer/util/BUILD.gn
[modify] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/installer/util/l10n_string_util.cc
[delete] https://crrev.com/d25d640f7f2ce6bae0a0c7f5711e0af79e622791/chrome/installer/util/language_selector.cc
[delete] https://crrev.com/d25d640f7f2ce6bae0a0c7f5711e0af79e622791/chrome/installer/util/language_selector.h
[delete] https://crrev.com/d25d640f7f2ce6bae0a0c7f5711e0af79e622791/chrome/installer/util/language_selector_unittest.cc
[add] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/installer/util/prebuild/create_installer_string_rc.py
[delete] https://crrev.com/d25d640f7f2ce6bae0a0c7f5711e0af79e622791/chrome/installer/util/prebuild/create_string_rc.py

Sign in to add a comment