Enabling steady-state elision feature in test configs triggers intermittent failures |
|
Issue description
Chrome Version: ToT (72.0.3616.0)
OS: na
What steps will reproduce the problem?
(1) Enable steady-state elision experiments in test configs:
+++ b/testing/variations/fieldtrial_testing_config.json
@@ -3311,6 +3311,25 @@
]
}
],
+ "OmniboxSteadyStateElisions": [
+ {
+ "platforms": [
+ "windows",
+ "mac",
+ "chromeos",
+ "linux"
+ ],
+ "experiments": [
+ {
+ "name": "Enabled",
+ "enable_features": [
+ "OmniboxUIExperimentHideSteadyStateUrlScheme",
+ "OmniboxUIExperimentHideSteadyStateUrlTrivialSubdomains"
+ ]
+ }
+ ]
+ }
+ ],
"OomIntervention": [
(2) Upload to gerrit and attempt a CQ dry-run.
What is the expected result?
All the bots pass.
What happens instead?
What I observed was that the Win7 and Fuschia bots would intermittently fail, and in different ways. If the change goes in clean, great!
It would be good if we could enable these, to eliminate some of the warnings from Finch about the feature.
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7698813700de5e89f3ff0da36c98d09ab784db8 commit b7698813700de5e89f3ff0da36c98d09ab784db8 Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Nov 30 19:54:06 2018 Omnibox: Add back Steady State Elisions feature in test configs Bug: 908440 Change-Id: Id846e2c8d209ebe77b08fa78dab90d1362e95328 Reviewed-on: https://chromium-review.googlesource.com/c/1351277 Reviewed-by: Kevin Bailey <krb@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#612735} [modify] https://crrev.com/b7698813700de5e89f3ff0da36c98d09ab784db8/testing/variations/fieldtrial_testing_config.json |
|
►
Sign in to add a comment |
|
Comment 1 by jdonnelly@chromium.org
, Nov 26Components: UI>Browser>Omnibox
Owner: tommycli@chromium.org
Status: Assigned (was: Available)