Issue 908439 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	se...@chromium.org
Closed:	Dec 12
Cc:	sabineb@chromium.org █ tschumann@chromium.org
Components:	UI>Browser>Autofill
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Mac
Pri:	2
Type:	Bug
Hotlist-Merge-Approved M-72 butter-hotlist merge-merged-3626 Merge-Merged-72-3626

Add UMA logging for users clicking the link to open their card in GPay from payment settings

Project Member Reported by feuunk@google.com, Nov 26

Issue description

We should add UMA logging for users clicking the link to open their card in GPay from payment settings.

This could be a signal for users that did not actually want to save their card to GPay.

Not quite a P1, because we're not sure how valuable this signal would be, but would still be great to have.

Comment 1 by feuunk@google.com, Nov 26

Labels: butter-hotlist

Comment 2 by feuunk@google.com, Nov 26

Labels: M-72 OS-Linux OS-Mac OS-Windows

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a61a1c00343a6ac4e71de3f2ff59258db96130c

commit 2a61a1c00343a6ac4e71de3f2ff59258db96130c
Author: sebsg <sebsg@chromium.org>
Date: Mon Dec 10 21:56:09 2018

[AF] Add UMA logging for the server card link in payment settings.

This will help us figure out if users are more likely to go check
their card in different sync situations.

Bug:  908439 
Change-Id: Idcbf6fee62bc2f364126d185d4a2f1f8a5ce431a
Reviewed-on: https://chromium-review.googlesource.com/c/1367927
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615271}
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/chrome/browser/extensions/api/autofill_private/autofill_private_api.h
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/chrome/browser/resources/settings/autofill_page/payments_section.js
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/chrome/common/extensions/api/autofill_private.idl
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/components/autofill/core/browser/sync_utils.h
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/third_party/closure_compiler/externs/autofill_private.js
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2a61a1c00343a6ac4e71de3f2ff59258db96130c/tools/metrics/histograms/histograms.xml

Comment 4 by se...@chromium.org, Dec 11

Labels: Merge-Request-72

Project Member

Comment 5 by sheriffbot@chromium.org, Dec 12

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72

Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12

Labels: -merge-approved-72 merge-merged-3626

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fa34f75f7f2c542e44de3c69b0d064f5155e791

commit 2fa34f75f7f2c542e44de3c69b0d064f5155e791
Author: Sébastien Séguin-Gagnon <sebsg@chromium.org>
Date: Wed Dec 12 14:59:00 2018

Merge72 [AF]Add UMA logging for server card link in payment settings.

This will help us figure out if users are more likely to go check
their card in different sync situations.

TBR=sebsg@chromium.org

(cherry picked from commit 2a61a1c00343a6ac4e71de3f2ff59258db96130c)

Bug:  908439 
Change-Id: Idcbf6fee62bc2f364126d185d4a2f1f8a5ce431a
Reviewed-on: https://chromium-review.googlesource.com/c/1367927
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615271}
Reviewed-on: https://chromium-review.googlesource.com/c/1374149
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#285}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/chrome/browser/extensions/api/autofill_private/autofill_private_api.h
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/chrome/browser/resources/settings/autofill_page/payments_section.js
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/chrome/common/extensions/api/autofill_private.idl
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/components/autofill/core/browser/sync_utils.h
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/third_party/closure_compiler/externs/autofill_private.js
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2fa34f75f7f2c542e44de3c69b0d064f5155e791/tools/metrics/histograms/histograms.xml

Comment 7 by se...@chromium.org, Dec 12

Status: Fixed (was: Untriaged)

Project Member

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/2fa34f75f7f2c542e44de3c69b0d064f5155e791

Commit: 2fa34f75f7f2c542e44de3c69b0d064f5155e791
Author: sebsg@chromium.org
Commiter: sebsg@chromium.org
Date: 2018-12-12 14:59:00 +0000 UTC

Merge72 [AF]Add UMA logging for server card link in payment settings.

This will help us figure out if users are more likely to go check
their card in different sync situations.

TBR=sebsg@chromium.org

(cherry picked from commit 2a61a1c00343a6ac4e71de3f2ff59258db96130c)

Bug:  908439 
Change-Id: Idcbf6fee62bc2f364126d185d4a2f1f8a5ce431a
Reviewed-on: https://chromium-review.googlesource.com/c/1367927
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615271}
Reviewed-on: https://chromium-review.googlesource.com/c/1374149
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#285}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

►

Issue 908439 link

Issue metadata

Add UMA logging for users clicking the link to open their card in GPay from payment settings

Issue description

Comment 1 by feuunk@google.com, Nov 26

Comment 1 Deleted

Comment 2 by feuunk@google.com, Nov 26

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Dec 10

Comment 3 Deleted

Comment 4 by se...@chromium.org, Dec 11

Comment 4 Deleted

Comment 5 by sheriffbot@chromium.org, Dec 12

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Dec 12

Comment 6 Deleted

Comment 7 by se...@chromium.org, Dec 12

Comment 7 Deleted

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Comment 8 Deleted

Sign in to add a comment