New issue
Advanced search Search tips

Issue 908409 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Nov 27
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Switch to open tab should close if done from NTP

Project Member Reported by gambard@chromium.org, Nov 26 
With the 'switch to this tab' flag.

What steps will reproduce the problem?
(1) Open a web page.
(2) Open a new tab
(3) Type part of the URL of the page opened in (1)
(4) Tap the "switch to this tab" button in the omnibox suggestions

What is the expected result?
The NTP tab should be closed (if it doesn't have back/forward history).

What happens instead?
It isn't closed.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a49a188c2115ebe2e29f242812168b41f2c5e1f4

commit a49a188c2115ebe2e29f242812168b41f2c5e1f4
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Nov 27 16:03:33 2018

[iOS] Close NTP when switching tab

When the user switch from a NTP which doesn't have a back/forward
history to an open tab, the tab should be closed.

Bug:  908010 ,  908409 
Change-Id: Ie4c783bef4c43ddafa175ba5796bd2a0b05cc54c
Reviewed-on: https://chromium-review.googlesource.com/c/1349264
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611123}
[modify] https://crrev.com/a49a188c2115ebe2e29f242812168b41f2c5e1f4/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/a49a188c2115ebe2e29f242812168b41f2c5e1f4/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/a49a188c2115ebe2e29f242812168b41f2c5e1f4/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_egtest.mm

Comment 2 by gambard@chromium.org, Nov 27

Status: Fixed (was: Assigned)

Comment 3 by ghuphran@chromium.org, Dec 4

Status: Verified (was: Fixed)
This issue has been verified and found fixed.

Version: Chrome Canary 73.0.3629.0 canary
iOS Version: 11.4.1, 12.0.1
Device: iPad Air, iPhone 7

Link to Video:
https://drive.google.com/open?id=1q6KEdtuvmGp_Hd3mp4kzUQgur4jF10Uf
►

Sign in to add a comment