New issue
Advanced search Search tips

Issue 908388 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Dots are seen misaligned in 'Display Size' sidebar of chrome://settings/display page

Project Member Reported by mmanchala@chromium.org, Nov 26

Issue description

Chrome Version: 72.0.3618.0/1297.0.0 dev-channel Kip,Reks and Diasy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Now go to chrome://settings/display page
(2)At 'Internal Display' observe 'Display Size' slide bar points is not aligned properly i.e. Dots are available at down side instead of Middle 
(Please refer Video and Screenshot)

Expected: Dots should be available at  Middle of Slide bar
Actual: Instead Dots are available at down side 

This is Regression Issue as same is working fine on 72.0.3612.0/1288.0.0 dev-channel Kip

Note : Issue is also seen in 'Touchpad' , 'Storage Management' and 'Keyboard' section 

 
Actual_Dots.mp4
14.1 MB View Download
Actual_Dots.jpg
121 KB View Download
Expected_Dots.jpg
119 KB View Download
Expected_Dots.mp4
7.3 MB View Download
Cc: aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19db7d8bc35e5902b6c089af5539e4b5156b335b

commit 19db7d8bc35e5902b6c089af5539e4b5156b335b
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Nov 29 03:06:26 2018

WebUI: cr-slider, fix inactive marker color for disabled sliders

Bug:  908388 
Change-Id: Iecdfd9081cb56769bac3643589c145e648e7bbe4
Reviewed-on: https://chromium-review.googlesource.com/c/1354309
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612008}
[modify] https://crrev.com/19db7d8bc35e5902b6c089af5539e4b5156b335b/ui/webui/resources/cr_elements/cr_slider/cr_slider.html

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c2c88644986fa7707fc48d7d2b3e8bce82339f5

commit 8c2c88644986fa7707fc48d7d2b3e8bce82339f5
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Nov 29 06:43:57 2018

WebUI: cr-slider, adjust markers location to match up with bar

Bug:  908388 
Change-Id: I0a93f9c648610331db2de63596f3349dd3d07333
Reviewed-on: https://chromium-review.googlesource.com/c/1351535
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612073}
[modify] https://crrev.com/8c2c88644986fa7707fc48d7d2b3e8bce82339f5/ui/webui/resources/cr_elements/cr_slider/cr_slider.html

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-72 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 11

Labels: -Merge-TBD

Sign in to add a comment