RTCConfiguration.offerExtmapAllowMixed |
||
Issue descriptionAs of M-71, Chrome will support two-byte RTP header extensions as defined in RFC8285. One- and two-byte RTP header extensions can only be mixed in the same stream if the SDP attribute extmap-allow-mixed is supported by all clients. The problem with extmap-allow-mixed is that prior to Chrome 71, this attribute made the SDP parser to stop parsing due to a bug in the implementation. The member RTCConfiguration.offerExtmapAllowMixed will therefore be added to make it configurable if the extmap-allow-mixed attribute should be offered or not. See design doc at http://go/extmap for more details.
,
Jan 7
Link to "Intent to Implement and Ship" thread with 3xLGTM: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7z3uvp0-ZAc
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad5a45340771e82d369ddb81340de238e2b6a2ff commit ad5a45340771e82d369ddb81340de238e2b6a2ff Author: Johannes Kron <kron@chromium.org> Date: Wed Jan 09 11:17:46 2019 Add offerExtmapAllowMixed to RTCConfiguration - Add offerExtmapAllowMixed to RTCConfiguration. - Add UMA histogram to track usage. Bug: 908377 Change-Id: I192797a17ca75c8db75d4484d3eab5caa064b52a Reviewed-on: https://chromium-review.googlesource.com/c/1397624 Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#621113} [modify] https://crrev.com/ad5a45340771e82d369ddb81340de238e2b6a2ff/third_party/blink/common/features.cc [modify] https://crrev.com/ad5a45340771e82d369ddb81340de238e2b6a2ff/third_party/blink/public/common/features.h [modify] https://crrev.com/ad5a45340771e82d369ddb81340de238e2b6a2ff/third_party/blink/renderer/modules/peerconnection/rtc_configuration.idl [modify] https://crrev.com/ad5a45340771e82d369ddb81340de238e2b6a2ff/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc [modify] https://crrev.com/ad5a45340771e82d369ddb81340de238e2b6a2ff/tools/metrics/histograms/enums.xml [modify] https://crrev.com/ad5a45340771e82d369ddb81340de238e2b6a2ff/tools/metrics/histograms/histograms.xml
,
Yesterday
(43 hours ago)
Tested on a Canary build.
If the RTCPeerConnection object is created as
pc = new RTCPeerConnection({offerExtmapAllowMixed:true});
the offer will include the SDP attribute a=extmap-allow-mixed.
|
||
►
Sign in to add a comment |
||
Comment 1 by kron@chromium.org
, Nov 26