Issue metadata
Sign in to add a comment
|
Regression : Input value in ‘Page number’ text box appears chopped when cursor blinks.
Reported by
avsha...@etouch.net,
Nov 26
|
||||||||||||||||||||||
Issue descriptionChrome Version : 72.0.3622.0 (Official Build) 74770d660797220710701b2c66ad38390ab86d43-refs/branch-heads/3622@{#1} 32/64 bit OS : Mac(10.13.1, 10.14.2), Windows (7, 8, 8.1, 10) Test URL : http://cb.vu/unixtoolbox.pdf What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Click inside ‘Page number’ text box on PDF toolbar and hit ’TAB’ key to bring focus on ‘Rotate’ icon. 3. Press ‘SHIFT + TAB’ to bring focus in ‘Page number’ text box. 4. Enter ’00’ in text box and observe. Actual Result : Input value in ‘Page number’ text box appears chopped when cursor blinks. Expected Result : Input value in ‘Page number’ text box should not be chopped when cursor blinks. This is a regression issue broken in M-69 and below is the bisect information: Good Build : 69.0.3469.0 (Revision : 569383) Bad Build : 69.0.3472.0 (Revision : 569948) Change log URL: https://chromium.googlesource.com/chromium/src/+log/83f54456850a92b700befbe570e599576b350409..d336e26825e9925c18a0b2ff7a03015976ce3299 Suspecting : https://chromium.googlesource.com/chromium/src/+/d336e26825e9925c18a0b2ff7a03015976ce3299 scottchen@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Unable to reproduce issue in Linux(14.04 LTS) and Mac Touch-bar(10.13.6) device. 2. Able to repro issue in Stable #70.0.3538.110, Beta#71.0.3578.62, Dev #72.0.3610.2 3. Issue can be reproduced on any PDF page that has more than 10 pages. Ex. https://collegereadiness.collegeboard.org/pdf/sat-practice-test-1.pdf Thank you..!
,
Dec 7
,
Dec 13
I could reproduce this on ChromeOS and Linux as well. I'm guessing it's a rounding issue since it only happens in certain window widths and the width of the input isn't in exact pixels (it's in `ch` units). Fixed by adding a buffer of 1px padding. See attached screencasts showing the before/after on ChromeOS.
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7398696b1aa40fefc1f4ecab364287a4851ca20d commit 7398696b1aa40fefc1f4ecab364287a4851ca20d Author: John Lee <johntlee@chromium.org> Date: Fri Dec 14 01:42:05 2018 WebUI: Add 1px of padding to 'Page number' input on PDF viewer to fix possible rounding errors Bug: 908367 Change-Id: Iefa3b3841518338753ca0b29d0865bd3ffe432c7 Reviewed-on: https://chromium-review.googlesource.com/c/1373017 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616555} [modify] https://crrev.com/7398696b1aa40fefc1f4ecab364287a4851ca20d/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js [modify] https://crrev.com/7398696b1aa40fefc1f4ecab364287a4851ca20d/chrome/test/data/pdf/material_elements_test.js
,
Dec 14
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by scottchen@chromium.org
, Dec 7Owner: johntlee@chromium.org