New issue
Advanced search Search tips

Issue 908357 link

Starred by 1 user
Status: Fixed
Owner:
hiroh@chromium.org
Closed: Nov 29
Cc:
tfiga@chromium.org
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Judge whether pixel format is supported by seeing format.fmt.pix_mp.pixelformat returned on S_FMT

Project Member Reported by hiroh@chromium.org, Nov 26 
V4L2 VEA currently judges whether pixel format is supported by seeing the return value of S_FMT.
According to the definition, S_FMT doesn't have to fail even if the pixel format is unsupported.
The correct way is to compare format.fmt.pix_mp.pixelformat returned on S_FMT with the queried pixel format.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60740217befc62853f2205a1b5f282a64d55291b

commit 60740217befc62853f2205a1b5f282a64d55291b
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Thu Nov 29 06:42:53 2018

media/gpu/v4l2/v4l2{VDA, VEA, JEA, JDA, IP}: check pixel format value returned on S_FMT

In the definition, S_FMT doesn't have to fail even if the queried pixel format
is not supported on the device. The correct way of judging pixel format support
is to compare the pixel format value returned on S_FMT with the queried pixel
format.

Bug:  908357 
Test: VDA, VEA, JDA unittest on elm
Test: JEA unittest on kevin

Change-Id: Ie57eaa37aec954997e743ebea05beed130faf604
Reviewed-on: https://chromium-review.googlesource.com/c/1351049
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612071}
[modify] https://crrev.com/60740217befc62853f2205a1b5f282a64d55291b/media/gpu/v4l2/v4l2_image_processor.cc
[modify] https://crrev.com/60740217befc62853f2205a1b5f282a64d55291b/media/gpu/v4l2/v4l2_jpeg_decode_accelerator.cc
[modify] https://crrev.com/60740217befc62853f2205a1b5f282a64d55291b/media/gpu/v4l2/v4l2_jpeg_encode_accelerator.cc
[modify] https://crrev.com/60740217befc62853f2205a1b5f282a64d55291b/media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/60740217befc62853f2205a1b5f282a64d55291b/media/gpu/v4l2/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/60740217befc62853f2205a1b5f282a64d55291b/media/gpu/v4l2/v4l2_video_encode_accelerator.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e96110f2d81b831da9cbc0180519eaaf5c51aec

commit 8e96110f2d81b831da9cbc0180519eaaf5c51aec
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Thu Nov 29 07:20:13 2018

media/gpu/v4l2/V4L2JEA: Execute S_FMT for YUV420M and YUV420 separately

Formerly, V4L2JEA calls S_FMT one time for YUV420M and checks if the pixel
format filled by driver is either YUV420 or YUV420M. Then, a driver can fill
NV12 even if it supports YUV420. V4L2JEA would rather execute S_FMT for
YUV420M and YUV420 separately and check if the returned format is exactly same
as the specified one.

Bug:  908357 
Test: VEA unittest on kevin
Change-Id: I15b5bae4f8d1c728f0db0bb961a1f5d39fed3c53
Reviewed-on: https://chromium-review.googlesource.com/c/1352074
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612084}
[modify] https://crrev.com/8e96110f2d81b831da9cbc0180519eaaf5c51aec/media/gpu/v4l2/v4l2_jpeg_encode_accelerator.cc

Comment 3 by hiroh@chromium.org, Nov 29

Status: Fixed (was: Assigned)
►

Sign in to add a comment