New issue
Advanced search Search tips

Issue 908354 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Find-in-page' doesn't work properly on 'Add languages' overlay.

Reported by dchau...@etouch.net, Nov 26

Issue description

Chrome Version: 72.0.3621.0 (Official Build) Revision	a10b0af074b5c7c088e27fb9d801d568a85b56a1-refs/branch-heads/3621@{#1} (32/64-bit)
OS: Mac(10.13.1 , 10.13.6 , 10.14.2), Windows(7,8,10) & Linux(14.04 LTS) OS. 

What steps will reproduce the problem?
1. Launch Chrome, navigate to chrome://settings/languages and expand the Language section.
2. Click on 'Add languages' link to open 'Add languages' overlay and open the Find-in-page text-box from Chrome wrench menu list.
3. Now type 'hi' text in Find-in-page text-box and observe the 'Add languages' overlay.

Actual: 'Add languages' overlay doesn't get scroll down and typed 'hi' text is not highlighted.
Expected: 'Add languages' overlay should scroll down and 'hi' text should get highlighted.

This is a regression issue, broken in M-69 series, below is manual regression range:

Good build: 69.0.3466.0 (Revision: 568695)
Bad build: 69.0.3469.3.0 (Revision: 569382)

Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/69.0.3466.0..69.0.3469.0?pretty=fuller&n=10000

Suspecting: https://chromium.googlesource.com/chromium/src/+/1805b4dc1d63e92bab0c8d884790096573fcba36

@yoichio: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Provided Suspect through Change-Log URL because unable to perform bisect using 'Chromium bisect' script and 'per-revision' script both.
2. Tried performing 'Chromium bisect' and 'per-revision' bisect on multiple Windows and Mac machines but Unable to get the good build after increasing the good revision range.
3. This issue is also reproducible on Stable #70.0.3538.110, Beta #71.0.3578.62 & Dev #72.0.3610.2

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual behavior.mp4
686 KB View Download
Expected behavior.mp4
863 KB View Download
Components: UI>Browser>FindInPage
Owner: rakina@chromium.org
I didn't change focus/scrolling behavior in the range.
Passed to the Find-in-page owner.
The languages list is a virtual list, which does not play along with Find in page anyway. That is the reason there is a dedicated search box within the dialog itself. Moreover, that is the reason why handle Ctrl+F to focus the that search box, instead of triggering native Find in page.

I suggest closing this as a WontFix, unless there is a Blink regression I am missing.
Status: WontFix (was: Assigned)

Sign in to add a comment