New issue
Advanced search Search tips

Issue 908353 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Nov 27
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CSS: contain keywords serialize out of order

Project Member Reported by ericwilligers@chromium.org, Nov 26 
https://drafts.csswg.org/css-contain/#contain-property
none | strict | content | [ size || layout || style || paint ]

They keywords "size layout style paint" should serialize in that order.

Blink currently serializes the specified value using the keywords in whichever order they were supplied, and serializes the computed value keywords in the order  style, layout, paint, size.

https://jsfiddle.net/ericwilligers/v6g18hex/
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5b4016fdb88af20d7907aec95f4b72b05dfb58c

commit e5b4016fdb88af20d7907aec95f4b72b05dfb58c
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Tue Nov 27 19:57:49 2018

CSS: Serialize contain keywords in canonical order

Keywords size, layout, style, paint now serialize in that order
for the 'contain' property.
https://drafts.csswg.org/css-contain/#contain-property

Bug:  908353 
Change-Id: Ifde635f2d313add887dd43a0a0d98249e45bff4b
Reviewed-on: https://chromium-review.googlesource.com/c/1350562
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611270}
[modify] https://crrev.com/e5b4016fdb88af20d7907aec95f4b72b05dfb58c/third_party/blink/renderer/core/css/properties/longhands/contain_custom.cc
[add] https://crrev.com/e5b4016fdb88af20d7907aec95f4b72b05dfb58c/third_party/blink/web_tests/external/wpt/css/css-contain/parsing/contain-computed-expected.txt
[add] https://crrev.com/e5b4016fdb88af20d7907aec95f4b72b05dfb58c/third_party/blink/web_tests/external/wpt/css/css-contain/parsing/contain-computed.html
[add] https://crrev.com/e5b4016fdb88af20d7907aec95f4b72b05dfb58c/third_party/blink/web_tests/external/wpt/css/css-contain/parsing/contain-invalid.html
[add] https://crrev.com/e5b4016fdb88af20d7907aec95f4b72b05dfb58c/third_party/blink/web_tests/external/wpt/css/css-contain/parsing/contain-valid.html

Comment 2 by ericwilligers@chromium.org, Nov 27

Status: Fixed (was: Started)
►

Sign in to add a comment