Suspect reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1350561

 Issue 908297  has been merged into this issue.

Change reverted for issue 873539.

There is only 1 test failing, I'll change to not run this tests with the flag for now.

Error from this builder:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9160


[ RUN      ] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameWithoutChangingCurrent_MyFilesVolume
[12343:12343:1126/000440.465239:WARNING:user_policy_manager_factory_chromeos.cc(208)] No policy loaded for known non-enterprise user
[12343:12343:1126/000440.582541:WARNING:easy_unlock_service_regular.cc(522)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false.
[12343:12343:1126/000440.969071:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
[12343:12343:1126/000441.243683:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[12343:12343:1126/000441.622952:INFO:file_manager_browsertest_base.cc(1303)] FileManagerBrowserTest::StartTest dirRenameWithoutChangingCurrent_MyFilesVolume
[12343:12343:1126/000445.712540:INFO:CONSOLE(5237)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5237)
[12343:12343:1126/000445.772764:INFO:CONSOLE(4635)] "Loading chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/runtime_loaded_test_util.js", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4635)
[12343:12343:1126/000445.786226:INFO:CONSOLE(646)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/runtime_loaded_test_util.js (646)
[12343:12343:1126/000445.789491:INFO:CONSOLE(837)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (837)
[12343:12343:1126/000445.791770:INFO:CONSOLE(5239)] "Volume list fetched with: 3 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5239)
[12343:12343:1126/000445.793656:INFO:CONSOLE(5249)] "Initializing volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5249)
[12343:12343:1126/000445.793884:INFO:CONSOLE(5713)] "Requesting file system: android_files android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5713)
[12343:12343:1126/000445.794872:INFO:CONSOLE(5249)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5249)
[12343:12343:1126/000445.795105:INFO:CONSOLE(5713)] "Requesting file system: downloads downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5713)
[12343:12343:1126/000445.795991:INFO:CONSOLE(5249)] "Initializing volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5249)
[12343:12343:1126/000445.796810:INFO:CONSOLE(5713)] "Requesting file system: drive drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5713)
[12343:12343:1126/000445.994747:INFO:CONSOLE(5763)] "File system obtained: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5763)
[12343:12343:1126/000445.995230:INFO:CONSOLE(5253)] "Initialized volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5253)
[12343:12343:1126/000445.998764:INFO:CONSOLE(5763)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5763)
[12343:12343:1126/000446.002433:INFO:CONSOLE(5253)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5253)
[12343:12343:1126/000446.005382:INFO:CONSOLE(5763)] "File system obtained: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5763)
[12343:12343:1126/000446.012517:INFO:CONSOLE(5253)] "Initialized volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5253)
[12343:12343:1126/000446.013453:INFO:CONSOLE(5257)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5257)
[12343:12343:1126/000446.389590:INFO:CONSOLE(643)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/runtime_loaded_test_util.js (643)
[12343:12343:1126/000446.390120:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source:  (0)
[12343:12343:1126/000446.485403:INFO:CONSOLE(0)] ":unresolved pseudo selector is deprecated and will be removed in M73, around March 2019. Please use :not(:defined) instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source:  (0)
[12343:12343:1126/000450.272857:INFO:CONSOLE(156)] "at /file_manager/background.js:379:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[12343:12343:1126/000453.721322:INFO:CONSOLE(156)] "at /file_manager/background.js:379:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[12343:12343:1126/000459.734751:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:194:15): Element #directory-tree-context-menu:not([hidden]) [command="#rename"]:not([disabled]) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[12343:12343:1126/000502.815453:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:194:15): Element #directory-tree-context-menu:not([hidden]) [command="#rename"]:not([disabled]) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[12343:12343:1126/000505.726875:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:194:15): Element #directory-tree-context-menu:not([hidden]) [command="#rename"]:not([disabled]) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[12343:12343:1126/000508.822634:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:194:15): Element #directory-tree-context-menu:not([hidden]) [command="#rename"]:not([disabled]) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[12343:12343:1126/000511.785481:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:194:15): Element #directory-tree-context-menu:not([hidden]) [command="#rename"]:not([disabled]) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[12343:12343:1126/000514.719474:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:194:15): Element #directory-tree-context-menu:not([hidden]) [command="#rename"]:not([disabled]) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[12343:12343:1126/000517.851556:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:194:15): Element #directory-tree-context-menu:not([hidden]) [command="#rename"]:not([disabled]) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[12343:12343:1126/000520.753283:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:194:15): Element #directory-tree-context-menu:not([hidden]) [command="#rename"]:not([disabled]) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x7f03334b46ad base::debug::StackTrace::StackTrace()
#1 0x7f03331b063a base::debug::StackTrace::StackTrace()
#2 0x559496352192 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f0300419cb0 <unknown>
#4 0x7f03004e16d3 epoll_wait
#5 0x7f0333563c5f epoll_dispatch
#6 0x7f03335573e5 event_base_loop
#7 0x7f0333507ae9 base::MessagePumpLibevent::Run()
#8 0x7f0333242336 base::MessageLoopImpl::Run()
#9 0x7f03332ee082 base::RunLoop::Run()
#10 0x55948fab9004 file_manager::(anonymous namespace)::FileManagerTestMessageListener::GetNextMessage()
#11 0x55948fab8637 file_manager::FileManagerBrowserTestBase::RunTestMessageLoop()
#12 0x55948fab8429 file_manager::FileManagerBrowserTestBase::StartTest()
#13 0x55948fa753b5 file_manager::FilesAppBrowserTest_Test_Test::RunTestOnMainThread()
#14 0x5594963506c5 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#15 0x55948d8f377d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_
#16 0x55948d8f36c4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#17 0x559496353525 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#18 0x55949635345c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#19 0x55948d8e3dcd _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#20 0x559495096300 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#21 0x559495094434 ChromeBrowserMainParts::PreMainMessageLoopRun()
#22 0x55949081c77b chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#23 0x7f0328c088c2 content::BrowserMainLoop::PreMainMessageLoopRun()
#24 0x7f032775d5fd _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_
#25 0x7f032775d544 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_
#26 0x7f0328c0e385 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#27 0x7f0328c0e2bc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#28 0x7f032765f78d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#29 0x7f0329c0d63d content::StartupTaskRunner::RunAllTasksNow()
#30 0x7f0328c0461f content::BrowserMainLoop::CreateStartupTasks()
#31 0x7f0328c10a03 content::BrowserMainRunnerImpl::Initialize()
#32 0x7f0328bfbf29 content::BrowserMain()
#33 0x7f032af43920 content::RunBrowserProcessMain()
#34 0x7f032af464c6 content::ContentMainRunnerImpl::Run()
#35 0x7f032af3c73c content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#36 0x7f02feae1a61 service_manager::Main()
#37 0x7f032af41055 content::ContentMain()
#38 0x55949634fc72 content::BrowserTestBase::SetUp()
#39 0x559494f2e9bb InProcessBrowserTest::SetUp()
#40 0x559494e4c7ec extensions::ExtensionBrowserTest::SetUp()
#41 0x55948fab3b0c file_manager::FileManagerBrowserTestBase::SetUp()
#42 0x55948d94576e _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_
#43 0x559491731972 testing::internal::HandleExceptionsInMethodIfSupported<>()
#44 0x5594917116d4 testing::Test::Run()
#45 0x559491712382 testing::TestInfo::Run()
#46 0x55949171329f testing::TestCase::Run()
#47 0x55949172714b testing::internal::UnitTestImpl::RunAllTests()
#48 0x55949173b27e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#49 0x5594917330e2 testing::internal::HandleExceptionsInMethodIfSupported<>()
#50 0x559491726d87 testing::UnitTest::Run()
#51 0x559494f78341 RUN_ALL_TESTS()
#52 0x559494f7550b base::TestSuite::Run()
#53 0x559494e1f417 ChromeTestSuiteRunner::RunTestSuite()
#54 0x559494e1f503 ChromeTestLauncherDelegate::RunTestSuite()
#55 0x5594963dab59 content::LaunchTests()
#56 0x559494e20852 LaunchChromeTests()
#57 0x559494e1ed5b main
#58 0x7f0300404f45 __libc_start_main
#59 0x55948d86d7fa _start
[ RUN      ] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameWithoutChangingCurrent_MyFilesVolume

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/735581534da6de8fa8c28a26c0ff18a0f0a94e19

commit 735581534da6de8fa8c28a26c0ff18a0f0a94e19
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 27 08:08:49 2018

Reland: Fix some tests when flag MyFilesVolume is enabled

Don't run dirRenameWithoutChangingCurrent with MyFilesVolume flag, since
it was flaky  crbug.com/908352 .

Add RootPaths.DOWNLOADS_PATH which sets the full path to Downloads
folder: "" when MyFilesVolume is disabled, which means Downloads is the
root; "/Downloads" when MyFilesVolume is enabled, which means that
Downloads it's a folder at root.

Change tests that uses entry.fullPath to prefix with
RootPaths.DOWNLOADS_PATH so the tests passes with/without the flag
MyFilesVolume.

Enable some tests to run with flag MyFilesVolumeEnabled which were
failing before this CL.

NOTE: RootPaths.DOWNLOADS_PATH will be removed and the full path with
/Downloads will be in-lined when MyFiles as Volume is fully rolled out.

--gtest_filter="DirectoryTreeContextMenu/FilesAppBrowserTest*"
--gtest_filter="CreateNewFolder/FilesAppBrowserTest*"

Test: browser_tests
Bug: 873539,  908352 
Change-Id: Iaac6c8bd51c2bc8dc31e1c395f2f74d8533f4f9c
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1351341
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611040}
[modify] https://crrev.com/735581534da6de8fa8c28a26c0ff18a0f0a94e19/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/735581534da6de8fa8c28a26c0ff18a0f0a94e19/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/735581534da6de8fa8c28a26c0ff18a0f0a94e19/ui/file_manager/integration_tests/file_manager/background.js
[modify] https://crrev.com/735581534da6de8fa8c28a26c0ff18a0f0a94e19/ui/file_manager/integration_tests/file_manager/create_new_folder.js
[modify] https://crrev.com/735581534da6de8fa8c28a26c0ff18a0f0a94e19/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js
[modify] https://crrev.com/735581534da6de8fa8c28a26c0ff18a0f0a94e19/ui/file_manager/integration_tests/remote_call.js
[modify] https://crrev.com/735581534da6de8fa8c28a26c0ff18a0f0a94e19/ui/file_manager/integration_tests/test_util.js

Looks good so far, closing this bug.