Currently, when editing wayland protocol XML files, we need to run wayland-scanner manually to generate protocol impl and header files. This should be done automatically when building chrome with some GN trick.
Uploaded a CL https://chromium-review.googlesource.com/c/chromium/src/+/1375197
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a64f758399d26a1c80ab0d3dfecee3abf0714305 commit a64f758399d26a1c80ab0d3dfecee3abf0714305 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Wed Jan 09 02:30:53 2019 Run wayland-scanner as part of build No longer need to run wayland-scanner manually. Add wayland_scanner as a target in third_party/wayland/BUILD.gn. Add wayland_protocol GN template. Try using the new template for aura-shell in components/exo/wayland/BUILD.gn BUG= 908346 TEST=build && manually verified that the generated code is the same. Change-Id: Ia40e7800cec5b899a99cc010a88ff7d824747a52 Reviewed-on: https://chromium-review.googlesource.com/c/1375197 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#621007} [modify] https://crrev.com/a64f758399d26a1c80ab0d3dfecee3abf0714305/components/exo/wayland/BUILD.gn [modify] https://crrev.com/a64f758399d26a1c80ab0d3dfecee3abf0714305/components/exo/wayland/clients/client_helper.h [add] https://crrev.com/a64f758399d26a1c80ab0d3dfecee3abf0714305/components/exo/wayland/protocol/BUILD.gn [delete] https://crrev.com/176e6a37cb827f4e487846356421087f45949a9c/components/exo/wayland/public/BUILD.gn [delete] https://crrev.com/176e6a37cb827f4e487846356421087f45949a9c/components/exo/wayland/public/aura-shell-client-protocol.h [delete] https://crrev.com/176e6a37cb827f4e487846356421087f45949a9c/components/exo/wayland/public/aura-shell-protocol.c [delete] https://crrev.com/176e6a37cb827f4e487846356421087f45949a9c/components/exo/wayland/public/aura-shell-server-protocol.h [modify] https://crrev.com/a64f758399d26a1c80ab0d3dfecee3abf0714305/third_party/wayland/BUILD.gn [modify] https://crrev.com/a64f758399d26a1c80ab0d3dfecee3abf0714305/third_party/wayland/README.chromium [add] https://crrev.com/a64f758399d26a1c80ab0d3dfecee3abf0714305/third_party/wayland/features.gni [modify] https://crrev.com/a64f758399d26a1c80ab0d3dfecee3abf0714305/third_party/wayland/include/config.h [add] https://crrev.com/a64f758399d26a1c80ab0d3dfecee3abf0714305/third_party/wayland/wayland_protocol.gni [add] https://crrev.com/a64f758399d26a1c80ab0d3dfecee3abf0714305/third_party/wayland/wayland_scanner_wrapper.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f5aac0ac79b8e8c5b256218b10be17ac1022ded commit 2f5aac0ac79b8e8c5b256218b10be17ac1022ded Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Thu Jan 10 04:37:41 2019 wayland-protocols: Generate protocol code with GN No longer need to run wayland-scanner manually. Bug: 908346 Test: The same code is generated. Manually confirmed that Android apps run on Chrome OS Change-Id: I63c1cd493d82b567ce544a81013a8fe6e0fe80ac Reviewed-on: https://chromium-review.googlesource.com/c/1401829 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#621461} [modify] https://crrev.com/2f5aac0ac79b8e8c5b256218b10be17ac1022ded/third_party/wayland-protocols/BUILD.gn [modify] https://crrev.com/2f5aac0ac79b8e8c5b256218b10be17ac1022ded/third_party/wayland-protocols/README.chromium [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/cursor-shapes-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/cursor-shapes-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/fullscreen-shell-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/fullscreen-shell-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v2-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v2-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/input-timestamps-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/input-timestamps-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/keyboard-configuration-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/keyboard-configuration-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/keyboard-extension-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/keyboard-extension-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/linux-dmabuf-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/linux-dmabuf-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/pointer-gestures-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/pointer-gestures-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/presentation-time-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/presentation-time-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/stylus-tools-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/stylus-tools-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/stylus-unstable-v2-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/stylus-unstable-v2-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/text-input-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/text-input-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/viewporter-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/viewporter-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v5-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v5-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v6-client-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v6-server-protocol.h [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/alpha-compositing-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/cursor-shapes-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/fullscreen-shell-v1-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/gaming-input-protocol-v1.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/gaming-input-protocol-v2.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/input-timestamps-v1-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/keyboard-configuration-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/keyboard-extension-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/linux-dmabuf-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/notification-shell-v1-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/pointer-gestures-v1-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/presentation-time-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/remote-shell-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/secure-output-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/stylus-protocol-v2.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/stylus-tools-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/text-input-v1-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/viewporter-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/vsync-feedback-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/xdg-shell-v5-protocol.c [delete] https://crrev.com/6888d0770e9a1fcd08c6b3048fa2bfa1df543b2b/third_party/wayland-protocols/protocol/xdg-shell-v6-protocol.c
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8 commit e6ff5c5d69a1fa4e97b437281d411d420f7e93e8 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Jan 10 05:26:10 2019 Revert "wayland-protocols: Generate protocol code with GN" This reverts commit 2f5aac0ac79b8e8c5b256218b10be17ac1022ded. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 621461 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJmNWFhYzBhYzc5YjhlOGM1YjI1NjIxOGIxMGJlMTdhYzEwMjJkZWQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/10172 Sample Failed Step: compile Original change's description: > wayland-protocols: Generate protocol code with GN > > No longer need to run wayland-scanner manually. > > Bug: 908346 > Test: The same code is generated. Manually confirmed that Android apps run on Chrome OS > Change-Id: I63c1cd493d82b567ce544a81013a8fe6e0fe80ac > Reviewed-on: https://chromium-review.googlesource.com/c/1401829 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621461} Change-Id: I7e8648d4976462b1f86d9ad712d35d5bc637c0e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908346 Reviewed-on: https://chromium-review.googlesource.com/c/1404738 Cr-Commit-Position: refs/heads/master@{#621468} [modify] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/BUILD.gn [modify] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/README.chromium [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/cursor-shapes-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/cursor-shapes-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/fullscreen-shell-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/fullscreen-shell-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v2-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v2-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/input-timestamps-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/input-timestamps-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/keyboard-configuration-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/keyboard-configuration-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/keyboard-extension-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/keyboard-extension-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/linux-dmabuf-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/linux-dmabuf-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/pointer-gestures-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/pointer-gestures-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/presentation-time-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/presentation-time-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/stylus-tools-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/stylus-tools-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/stylus-unstable-v2-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/stylus-unstable-v2-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/text-input-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/text-input-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/viewporter-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/viewporter-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v5-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v5-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v6-client-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v6-server-protocol.h [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/alpha-compositing-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/cursor-shapes-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/fullscreen-shell-v1-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/gaming-input-protocol-v1.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/gaming-input-protocol-v2.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/input-timestamps-v1-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/keyboard-configuration-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/keyboard-extension-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/linux-dmabuf-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/notification-shell-v1-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/pointer-gestures-v1-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/presentation-time-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/remote-shell-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/secure-output-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/stylus-protocol-v2.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/stylus-tools-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/text-input-v1-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/viewporter-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/vsync-feedback-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/xdg-shell-v5-protocol.c [add] https://crrev.com/e6ff5c5d69a1fa4e97b437281d411d420f7e93e8/third_party/wayland-protocols/protocol/xdg-shell-v6-protocol.c
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8b4b5b8968c7bef1cd0128c684c771e63ee425c commit e8b4b5b8968c7bef1cd0128c684c771e63ee425c Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Thu Jan 10 06:56:11 2019 Reland "wayland-protocols: Generate protocol code with GN" This is a reland of 2f5aac0ac79b8e8c5b256218b10be17ac1022ded Original change's description: > wayland-protocols: Generate protocol code with GN > > No longer need to run wayland-scanner manually. > > Bug: 908346 > Test: The same code is generated. Manually confirmed that Android apps run on Chrome OS > Change-Id: I63c1cd493d82b567ce544a81013a8fe6e0fe80ac > Reviewed-on: https://chromium-review.googlesource.com/c/1401829 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621461} TBR=oshima@chromium.org for previously approved changes. TBR=msisov@igalia.com for the addition of missing dependency for wayland_unittests Bug: 908346 Change-Id: I5d25f99457d2ad492668857da81cc5c163cda28b Reviewed-on: https://chromium-review.googlesource.com/c/1404758 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#621489} [modify] https://crrev.com/e8b4b5b8968c7bef1cd0128c684c771e63ee425c/third_party/wayland-protocols/BUILD.gn [modify] https://crrev.com/e8b4b5b8968c7bef1cd0128c684c771e63ee425c/third_party/wayland-protocols/README.chromium [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/cursor-shapes-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/cursor-shapes-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/fullscreen-shell-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/fullscreen-shell-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v2-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v2-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/input-timestamps-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/input-timestamps-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/keyboard-configuration-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/keyboard-configuration-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/keyboard-extension-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/keyboard-extension-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/linux-dmabuf-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/linux-dmabuf-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/pointer-gestures-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/pointer-gestures-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/presentation-time-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/presentation-time-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/stylus-tools-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/stylus-tools-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/stylus-unstable-v2-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/stylus-unstable-v2-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/text-input-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/text-input-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/viewporter-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/viewporter-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v5-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v5-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v6-client-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/include/protocol/xdg-shell-unstable-v6-server-protocol.h [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/alpha-compositing-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/cursor-shapes-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/fullscreen-shell-v1-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/gaming-input-protocol-v1.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/gaming-input-protocol-v2.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/input-timestamps-v1-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/keyboard-configuration-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/keyboard-extension-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/linux-dmabuf-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/notification-shell-v1-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/pointer-gestures-v1-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/presentation-time-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/remote-shell-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/secure-output-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/stylus-protocol-v2.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/stylus-tools-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/text-input-v1-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/viewporter-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/vsync-feedback-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/xdg-shell-v5-protocol.c [delete] https://crrev.com/5f4244d322801e2213ee090c3ced9beeab6e8c1b/third_party/wayland-protocols/protocol/xdg-shell-v6-protocol.c [modify] https://crrev.com/e8b4b5b8968c7bef1cd0128c684c771e63ee425c/ui/ozone/platform/wayland/BUILD.gn
Comment 1 by hashimoto@chromium.org
, Dec 4Status: Available (was: Assigned)