New issue
Advanced search Search tips

Issue 908337 link

Starred by 1 user
Status: Fixed
Owner:
edcourtney@chromium.org
Closed: Nov 29
Cc:
mccanny@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Cr-PiP-Alignment


Sign in to add a comment

Picture-in-picture slide-out dismiss animation only plays once

Project Member Reported by edcourtney@chromium.org, Nov 26 
Repro steps:
1. Open a Chrome PIP window
2. Close it, see it slide out to dismiss
3. Open the same video in a PIP window again
4. Close it - it just cross-fades out.

Expected behaviour:
Does the same slide out animation.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54d566e69be485e27a55c986b0dcee80a78f1dec

commit 54d566e69be485e27a55c986b0dcee80a78f1dec
Author: Eliot Courtney <edcourtney@google.com>
Date: Thu Nov 29 02:34:53 2018

Apply slide out animation type to PIP window on show.

    applied both times.

Bug:  908337 
Test: Open and close a Chrome PIP window twice. Slide out animation is
Change-Id: I617e008070f733184d635486ea3c14b260838c8b
Reviewed-on: https://chromium-review.googlesource.com/c/1350026
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611995}
[modify] https://crrev.com/54d566e69be485e27a55c986b0dcee80a78f1dec/ash/public/cpp/window_animation_types.h
[modify] https://crrev.com/54d566e69be485e27a55c986b0dcee80a78f1dec/ash/wm/base_state.cc
[modify] https://crrev.com/54d566e69be485e27a55c986b0dcee80a78f1dec/ash/wm/window_animations.cc
[modify] https://crrev.com/54d566e69be485e27a55c986b0dcee80a78f1dec/ash/wm/window_animations_unittest.cc
[modify] https://crrev.com/54d566e69be485e27a55c986b0dcee80a78f1dec/ash/wm/window_state.cc

Comment 2 by edcourtney@chromium.org, Nov 29

Status: Fixed (was: Started)
►

Sign in to add a comment