New issue
Advanced search Search tips

Issue 908330 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Nov 29
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus does not stay on 'more actions' icon for saved password after pressing 'Esc' key

Reported by vineetha...@etouch.net, Nov 26 
Chrome Version: 72.0.3621.0 (Official Build) Revision a10b0af074b5c7c088e27fb9d801d568a85b56a1-refs/branch-heads/3621@{#1}(32/64 bit)
OS: Windows (7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS) OS

Pre-condition: At least one saved password entry should be present under chrome://settings/passwords

What steps will reproduce the problem?
(1) Launch Chrome, navigate to chrome://settings/passwords.
(2) Click on more actions icon for saved password to open overlay options.
(3) Now press Esc key and observe the focus.

Actual Result  : Focus does not stay on 'more actions'(3 dot) icon for saved password instead focus ring is seen on corresponding website name.
Expected Result: Focus should stay on 'more actions' icon for saved passwords after pressing 'Esc'.

This is a Regression issue seen from 'M-72' and providing the bisect info below:
Good Build: 72.0.3511.0 (Revision: 608212)
Bad Build:  72.0.3512.0 (Revision: 608630)

You are probably looking for a change made after 608561 (known good), but no later than 608562 (first known bad).
CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/9b0436b7f7661e562fb0cb2d5d3aec70aa1d966f..292d851b752f8a97a347ecdf8e1f412afe9bcc37

Suspect: https://chromium.googlesource.com/chromium/src/+/292d851b752f8a97a347ecdf8e1f412afe9bcc37

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You..!
ActualVideo.mp4
338 KB View Download
ExpectedVideo.mp4
318 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5faf315880672b538cecf46b66a3ba334065be6f

commit 5faf315880672b538cecf46b66a3ba334065be6f
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Nov 28 02:52:40 2018

Settings and History: Fix focus issues

The 3 linked bugs are all due to an issue with refocusing a list item
from an element after the last control. In this case, the last control
should be refocused, not the first control.

This case can be identified by the first element in the focus event's
path. This will be the list item itself if focus is coming from outside
the control from an element that is before the list item in the tab
order. It will be the last control if focus is coming from an element
that is after the list item in the tab order.

Bug:  908330 ,  908323 ,  908014 
Change-Id: Ie2289547470e2f66cd9285d29e9ed1e0ab3207c1
Reviewed-on: https://chromium-review.googlesource.com/c/1351713
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611536}
[modify] https://crrev.com/5faf315880672b538cecf46b66a3ba334065be6f/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/5faf315880672b538cecf46b66a3ba334065be6f/chrome/browser/resources/settings/focus_row_behavior.js

Comment 2 by vineetha...@etouch.net, Nov 29

Labels: TE-Verified-M72 TE-Verified-72.0.3625.0
Update:

Rechecked the above issue on Windows (7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS) OS using latest Canary build #72.0.3625.0 and the issue is fixed. Kindly refer attached screen cast.

Thank you
FixedVideo.mp4
276 KB View Download

Comment 3 by rbpotter@chromium.org, Nov 29

Status: Verified (was: Assigned)
►

Sign in to add a comment