New issue
Advanced search Search tips

Issue 908324 link

Starred by 1 user
Status: Fixed
Owner:
toyoshim@chromium.org
Closed: Nov 30
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 870173
issue 891891
issue 905971



Sign in to add a comment

OOR-CORS: Newly created NetworkContext for the same profile should start with a copy of the existing access list

Project Member Reported by toyoshim@chromium.org, Nov 26 
This maybe a root of remaining test failures with NetworkService enabled.

In the browser process, multiple NetworkContext can be created per profile. At this time, newly created NetworkContext should start with a copy of the existing access list.

Also this copy may be needed when the network service does unexpected restarts.

Comment 1 by toyoshim@chromium.org, Nov 26

Blocking: 870173

Comment 2 by toyoshim@chromium.org, Nov 26

Blocking: 905971

Comment 3 by toyoshim@chromium.org, Nov 26

Blocking: 891891
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72e96bdf5bb8ed3715d5002729304b7fdd229190

commit 72e96bdf5bb8ed3715d5002729304b7fdd229190
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Mon Nov 26 09:59:21 2018

OOR-CORS: Use mojom::CorsOriginAccessMatchMode in OriginAccessEntry

This patch makes network::cors::OriginAccessEntry to use
mojom::CorsOriginAccessMatchMode rather than inter-class enum.

This also allows mojom::CorsOriginPattern to use the
mojom::CorsOriginAccessMatchMode rather than bool so that it can
represent complete OriginAccessEntry content. This is needed to
have an entry set copy outside NetworkService.

TBR=haraken@chromium.org

Bug:  908324 
Change-Id: I5a29e877baecdcd77dea0c7c16dd90dc66f93302
Reviewed-on: https://chromium-review.googlesource.com/c/1350554
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610798}
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/services/network/public/cpp/cors/origin_access_entry.cc
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/services/network/public/cpp/cors/origin_access_entry.h
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/services/network/public/cpp/cors/origin_access_entry_unittest.cc
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/services/network/public/cpp/cors/origin_access_list.cc
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/services/network/public/mojom/cors.mojom
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/services/network/public/mojom/cors_origin_pattern.mojom
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/third_party/blink/public/web/DEPS
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/third_party/blink/public/web/web_security_policy.h
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/third_party/blink/renderer/platform/weborigin/origin_access_entry.cc
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/third_party/blink/renderer/platform/weborigin/origin_access_entry.h
[modify] https://crrev.com/72e96bdf5bb8ed3715d5002729304b7fdd229190/third_party/blink/renderer/platform/weborigin/security_policy.h
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f105984120b4b564105d5e41257a73d8ab106cf

commit 7f105984120b4b564105d5e41257a73d8ab106cf
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Nov 28 08:49:52 2018

OOR-CORS: Use CorsOriginAccessMatchMode in CorsOriginPattern

This patch makes mojom::CorsOriginPattern use CorsORiginAccessMatchMode
and allows network::cors::OriginAccessList to create equivalent
mojom::CorsOriginAccessPatterns array.

Also this patch enforces not to rely on cors_origin_patterns.mojom.h
indirectly from Blink platform.

Bug:  908324 , 908756
Change-Id: If059a460b424025376b2e4d4433ba6ec17523357
Reviewed-on: https://chromium-review.googlesource.com/c/1350689
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611603}
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/chrome/common/extensions/chrome_extensions_client.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/content/browser/loader/cors_origin_access_list_browsertest.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/extensions/common/cors_util.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_entry.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_entry.h
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_entry_unittest.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_list.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_list.h
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_list_unittest.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/mojom/cors_origin_pattern.mojom
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/third_party/blink/renderer/platform/weborigin/security_policy.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8893ec99d0180595cf950a2f7bad2869d9c394b7

commit 8893ec99d0180595cf950a2f7bad2869d9c394b7
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Fri Nov 30 04:58:52 2018

OOR-CORS: Manage per-profile access list even for NetworkService

This patch makes BrowserContext manages per-profile CORS access lists
even if NetworkService is enabled, and use it to setup initial access
lists for the non-primary NetworkContext. It will also work for
restoring per-profile CORS settings on network service restarts.

This patch makes following tests work even with
--enable-features=OutOfBlinkCors,NetworkService.

- CrossOriginReadBlockingExtensionTest.ProgrammaticContentScriptVsAppCache
- CrossOriginReadBlockingExtensionTest.WebViewContentScript
- ExtensionWebRequestApiTest.ExtensionRequests
- PlatformAppBrowserTest.Isolation

Bug:  908324 , 891891
Change-Id: Ib0cfc2f5633f25187366a4d7d63168d60ea51f71
Reviewed-on: https://chromium-review.googlesource.com/c/1351208
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612567}
[modify] https://crrev.com/8893ec99d0180595cf950a2f7bad2869d9c394b7/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/8893ec99d0180595cf950a2f7bad2869d9c394b7/content/browser/browser_context.cc
[modify] https://crrev.com/8893ec99d0180595cf950a2f7bad2869d9c394b7/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/8893ec99d0180595cf950a2f7bad2869d9c394b7/content/browser/loader/shared_cors_origin_access_list_impl.cc
[modify] https://crrev.com/8893ec99d0180595cf950a2f7bad2869d9c394b7/content/public/browser/shared_cors_origin_access_list.h
[modify] https://crrev.com/8893ec99d0180595cf950a2f7bad2869d9c394b7/services/network/network_context.cc
[modify] https://crrev.com/8893ec99d0180595cf950a2f7bad2869d9c394b7/services/network/network_context.h
[modify] https://crrev.com/8893ec99d0180595cf950a2f7bad2869d9c394b7/services/network/public/mojom/network_context.mojom

Comment 7 by toyoshim@chromium.org, Nov 30

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 13

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abeca37d816b48b549eb840a8231f704aac82c03

commit abeca37d816b48b549eb840a8231f704aac82c03
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Dec 13 06:55:58 2018

OOR-CORS: Manage per-profile access list even for NetworkService

This patch makes BrowserContext manages per-profile CORS access lists
even if NetworkService is enabled, and use it to setup initial access
lists for the non-primary NetworkContext. It will also work for
restoring per-profile CORS settings on network service restarts.

This patch makes following tests work even with
--enable-features=OutOfBlinkCors,NetworkService.

- CrossOriginReadBlockingExtensionTest.ProgrammaticContentScriptVsAppCache
- CrossOriginReadBlockingExtensionTest.WebViewContentScript
- ExtensionWebRequestApiTest.ExtensionRequests
- PlatformAppBrowserTest.Isolation

Bug:  908324 , 891891,  895999 
Change-Id: Ib0cfc2f5633f25187366a4d7d63168d60ea51f71
Reviewed-on: https://chromium-review.googlesource.com/c/1351208
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612567}(cherry picked from commit 8893ec99d0180595cf950a2f7bad2869d9c394b7)

TBR=yhirano@chromium.org

Change-Id: Ib0cfc2f5633f25187366a4d7d63168d60ea51f71
Reviewed-on: https://chromium-review.googlesource.com/c/1373370
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#319}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/abeca37d816b48b549eb840a8231f704aac82c03/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/abeca37d816b48b549eb840a8231f704aac82c03/content/browser/browser_context.cc
[modify] https://crrev.com/abeca37d816b48b549eb840a8231f704aac82c03/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/abeca37d816b48b549eb840a8231f704aac82c03/content/browser/loader/shared_cors_origin_access_list_impl.cc
[modify] https://crrev.com/abeca37d816b48b549eb840a8231f704aac82c03/content/public/browser/shared_cors_origin_access_list.h
[modify] https://crrev.com/abeca37d816b48b549eb840a8231f704aac82c03/services/network/network_context.cc
[modify] https://crrev.com/abeca37d816b48b549eb840a8231f704aac82c03/services/network/network_context.h
[modify] https://crrev.com/abeca37d816b48b549eb840a8231f704aac82c03/services/network/public/mojom/network_context.mojom
Project Member

Comment 9 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/abeca37d816b48b549eb840a8231f704aac82c03

Commit: abeca37d816b48b549eb840a8231f704aac82c03
Author: toyoshim@chromium.org
Commiter: toyoshim@chromium.org
Date: 2018-12-13 06:55:58 +0000 UTC

OOR-CORS: Manage per-profile access list even for NetworkService

This patch makes BrowserContext manages per-profile CORS access lists
even if NetworkService is enabled, and use it to setup initial access
lists for the non-primary NetworkContext. It will also work for
restoring per-profile CORS settings on network service restarts.

This patch makes following tests work even with
--enable-features=OutOfBlinkCors,NetworkService.

- CrossOriginReadBlockingExtensionTest.ProgrammaticContentScriptVsAppCache
- CrossOriginReadBlockingExtensionTest.WebViewContentScript
- ExtensionWebRequestApiTest.ExtensionRequests
- PlatformAppBrowserTest.Isolation

Bug:  908324 , 891891,  895999 
Change-Id: Ib0cfc2f5633f25187366a4d7d63168d60ea51f71
Reviewed-on: https://chromium-review.googlesource.com/c/1351208
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612567}(cherry picked from commit 8893ec99d0180595cf950a2f7bad2869d9c394b7)

TBR=yhirano@chromium.org

Change-Id: Ib0cfc2f5633f25187366a4d7d63168d60ea51f71
Reviewed-on: https://chromium-review.googlesource.com/c/1373370
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#319}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment