New issue
Advanced search Search tips

Issue 908323 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Nov 29
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Glimpse of focus is seen on remove icon before it shifts to arrow icon (skips remove icon)

Reported by sanyam.g...@etouch.net, Nov 26 
Chrome Version: 72.0.3621.0 (Official Build) Revision	a10b0af074b5c7c088e27fb9d801d568a85b56a1-refs/branch-heads/3621@{#1}  (32/64-bit)
OS:Mac(10.13.1 , 10.13.6 , 10.14.2), Windows(7,8,10) & Linux(14.04 LTS) OS.

Steps to reproduce:
1. Launch chrome and navigate to 'chrome://settings/siteData'.
2. Press tab key to bring focus to 'Remove' icon of first entry and again press tab once.
3. Now press shift+tab once and observe.

Actual  : Glimpse of focus is seen on remove icon before it shifts to arrow icon (skips remove icon) on pressing 'shift+tab'.
Expected: No such glimpse should be seen and focus should stay on remove icon on pressing shift+tab key.

This is a Regression issue seen from 'M-72' and providing the bisect info below:
Good Build: 72.0.3511.0 (Revision: 608212)
Bad Build:  72.0.3512.0 (Revision: 608630)

You are probably looking for a change made after 608561 (known good), but no later than 608562 (first known bad).
CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  
https://chromium.googlesource.com/chromium/src/+log/9b0436b7f7661e562fb0cb2d5d3aec70aa1d966f..292d851b752f8a97a347ecdf8e1f412afe9bcc37

Suspect: https://chromium.googlesource.com/chromium/src/+/292d851b752f8a97a347ecdf8e1f412afe9bcc37

@Rebekah: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You..!
Actual_Result.mov
1.9 MB View Download
Expected_Result.mov
987 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5faf315880672b538cecf46b66a3ba334065be6f

commit 5faf315880672b538cecf46b66a3ba334065be6f
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Nov 28 02:52:40 2018

Settings and History: Fix focus issues

The 3 linked bugs are all due to an issue with refocusing a list item
from an element after the last control. In this case, the last control
should be refocused, not the first control.

This case can be identified by the first element in the focus event's
path. This will be the list item itself if focus is coming from outside
the control from an element that is before the list item in the tab
order. It will be the last control if focus is coming from an element
that is after the list item in the tab order.

Bug:  908330 ,  908323 ,  908014 
Change-Id: Ie2289547470e2f66cd9285d29e9ed1e0ab3207c1
Reviewed-on: https://chromium-review.googlesource.com/c/1351713
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611536}
[modify] https://crrev.com/5faf315880672b538cecf46b66a3ba334065be6f/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/5faf315880672b538cecf46b66a3ba334065be6f/chrome/browser/resources/settings/focus_row_behavior.js

Comment 2 by sanyam.g...@etouch.net, Nov 29

Labels: TE-Verified-72.0.3625.0 TE-Verified-M72
Update:
Rechecked this issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2) and Linux(14.04) machines using latest Canary #72.0.3625.0 and issue is fixed. Hence adding TE-Verified labels.

please refer the attached screen-cast for reference.
Fixed_Result.mov
1.2 MB View Download

Comment 3 by rbpotter@chromium.org, Nov 29

Status: Verified (was: Assigned)
►

Sign in to add a comment