It has concepts of document_url and topmost_frame_url, while it can be for a document, shared worker, or service worker. Clean this up a bit.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54544c536731f89f923499bdc0f6f84c95063728 commit 54544c536731f89f923499bdc0f6f84c95063728 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Nov 26 06:56:39 2018 service worker: Rename topmost_frame_url to site_for_cookies. This aligns with ResourceRequest's naming, which is where the value comes from anyway. Note that ResourceRequest documentation states site_for_cookies is "usually" the topmost frame URL. This also allows the getter function to be called for service worker execution contexts. This simplifies some code at the callsite. Bug: 908311 Change-Id: Ief92f49d439e1219a6a33a7bafb03371d514b6e6 Reviewed-on: https://chromium-review.googlesource.com/c/1350415 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610775} [modify] https://crrev.com/54544c536731f89f923499bdc0f6f84c95063728/content/browser/service_worker/service_worker_controllee_request_handler.cc [modify] https://crrev.com/54544c536731f89f923499bdc0f6f84c95063728/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/54544c536731f89f923499bdc0f6f84c95063728/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/54544c536731f89f923499bdc0f6f84c95063728/content/browser/service_worker/service_worker_provider_host_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e816a9acc084c07b63a28476deb3fb3742ab90a0 commit e816a9acc084c07b63a28476deb3fb3742ab90a0 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Nov 26 07:45:30 2018 service worker: Remove SetSiteForCookies(). Make callers use UpdateURLs instead. Bug: 908311 Change-Id: I1689c8670dc2c03f325500be24dcdde9a88586a0 Reviewed-on: https://chromium-review.googlesource.com/c/1350419 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610780} [modify] https://crrev.com/e816a9acc084c07b63a28476deb3fb3742ab90a0/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/e816a9acc084c07b63a28476deb3fb3742ab90a0/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/e816a9acc084c07b63a28476deb3fb3742ab90a0/content/browser/service_worker/service_worker_provider_host_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9 commit f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Nov 26 09:11:04 2018 service worker: Remove document_url() setters/getters. Callsites must use UpdateURLs() instead to ensure dependent state is updated. Replace the getter with url(), which makes more sense for all provider types. Bug: 908311 Change-Id: I4741225a0aec82f150d906f0f8f1736ac0097705 Reviewed-on: https://chromium-review.googlesource.com/c/1350021 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610787} [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_client_utils.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_context_core.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_context_unittest.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_object_host.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_object_host_unittest.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_provider_host_unittest.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_register_job.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_registration_object_host.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_registration_unittest.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_request_handler_unittest.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_test_utils.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_test_utils.h [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/f3e0a8d98a516df306c2ae9f27f1dbea5e029fc9/content/browser/service_worker/service_worker_version_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50ff7cbcac3a980824eab8142099ff2d95f427b1 commit 50ff7cbcac3a980824eab8142099ff2d95f427b1 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Nov 27 18:07:30 2018 service worker: Rename provider host's document_url_ to url_. Because provider hosts can be for workers as well as documents. Also rename UpdateURLs to UpdateUrls for typing ease and alignment with the style guide (acronyms are treated as a normal word). Bug: 908311 Change-Id: Ie4c7edaed41f8d89315a2ae4514880e8b3fdd2b0 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/c/1350422 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611188} [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/loader/navigation_url_loader_impl.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_context_unittest.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_controllee_request_handler.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_object_host_unittest.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_provider_host_unittest.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_registration_unittest.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_request_handler_unittest.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/50ff7cbcac3a980824eab8142099ff2d95f427b1/content/browser/service_worker/service_worker_version_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Nov 26