New issue
Advanced search Search tips

Issue 908299 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 26
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355
issue 907967



Sign in to add a comment

Add file_operation_manager to the closure BUILD and its mock

Project Member Reported by noel@chromium.org, Nov 26

Issue description

Add file_operation_manager.js and its mock file to the closure BUILD and make it compile, remove closure errors.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fe9b01c4708f519740b1f53c45279be4b2c5a2d

commit 7fe9b01c4708f519740b1f53c45279be4b2c5a2d
Author: Noel Gordon <noel@chromium.org>
Date: Mon Nov 26 11:16:41 2018

Closure compile file_operation_manager and its mock file

 - add these files to the BUILD file, fix all closure errors
 - change externs FileOperationManager to be an @interface
 - rename FileOperationManager to FileOperationManagerImpl,
   and use it as the implementation in FilesApp
 - remove FileOperationManager.DELETE_TIMEOUT, it is unused
 - update class MockFileOperationManager, an implementation
   of FileOperationManager for tests, and add missing base
   class methods needed to Closure compile it.
 - re-order file_operation_handler_unittest.html scripts: the
   simple scripts first, the unittest-related scripts last.
 - make util.addEventListenerToBackgroundComponent have an
   EventTarget to satisfy Closure compile now EventTarget is
   used to define the externs FileOperationManager @interface

No change in test behavior, no new tests.

Bug:  908299 
Change-Id: I5b03596b6beb3e6bce3bd8a140525fff4cb30d2d
Reviewed-on: https://chromium-review.googlesource.com/c/1350447
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610810}
[modify] https://crrev.com/7fe9b01c4708f519740b1f53c45279be4b2c5a2d/ui/file_manager/externs/background/file_operation_manager.js
[modify] https://crrev.com/7fe9b01c4708f519740b1f53c45279be4b2c5a2d/ui/file_manager/file_manager/background/js/BUILD.gn
[modify] https://crrev.com/7fe9b01c4708f519740b1f53c45279be4b2c5a2d/ui/file_manager/file_manager/background/js/background.js
[modify] https://crrev.com/7fe9b01c4708f519740b1f53c45279be4b2c5a2d/ui/file_manager/file_manager/background/js/file_operation_handler_unittest.html
[modify] https://crrev.com/7fe9b01c4708f519740b1f53c45279be4b2c5a2d/ui/file_manager/file_manager/background/js/file_operation_manager.js
[modify] https://crrev.com/7fe9b01c4708f519740b1f53c45279be4b2c5a2d/ui/file_manager/file_manager/background/js/file_operation_manager_unittest.js
[modify] https://crrev.com/7fe9b01c4708f519740b1f53c45279be4b2c5a2d/ui/file_manager/file_manager/background/js/mock_file_operation_manager.js
[modify] https://crrev.com/7fe9b01c4708f519740b1f53c45279be4b2c5a2d/ui/file_manager/file_manager/common/js/util.js

Status: Fixed (was: Started)
Blocking: 907967

Sign in to add a comment