New issue
Advanced search Search tips

Issue 908293 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: params->background_texture || params->background_image_id == params->use_shaders

Project Member Reported by ClusterFuzz, Nov 26

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5605188855136256

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  params->background_texture || params->background_image_id == params->use_shaders
  viz::GLRenderer::UpdateRPDQShadersForBlending
  viz::GLRenderer::DrawRenderPassQuadInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=602110:602118

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5605188855136256

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 26

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 26

Labels: Test-Predator-Auto-Owner
Owner: dcasta...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/5d8b75a4024d0759466fd1ea8043fabb2adb1483 (cc: Remove unnecessary BindTexture and texture name check).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceb3da6c512ed69d102f0501e83efdf61ed7dd95

commit ceb3da6c512ed69d102f0501e83efdf61ed7dd95
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Tue Nov 27 23:37:52 2018

viz: Fix params->background_texture == 0 case

In crrev.com/c/1296679 we removed unnecessary code given the assumption that
backdrop_texture could never be 0.

Unfortunately we missed the case where background_rect is empty, and we still
can have params->background_texture equal to 0.

This patch brings back that check.

Bug:  908293 ,  904981 
Change-Id: I94a1109c839337b77589c69fa607d7dc074c0daf
Reviewed-on: https://chromium-review.googlesource.com/c/1351711
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611417}
[modify] https://crrev.com/ceb3da6c512ed69d102f0501e83efdf61ed7dd95/components/viz/service/display/gl_renderer.cc

Project Member

Comment 5 by ClusterFuzz, Nov 28

ClusterFuzz has detected this issue as fixed in range 611414:611419.

Detailed report: https://clusterfuzz.com/testcase?key=5605188855136256

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  params->background_texture || params->background_image_id == params->use_shaders
  viz::GLRenderer::UpdateRPDQShadersForBlending
  viz::GLRenderer::DrawRenderPassQuadInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=602110:602118
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=611414:611419

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5605188855136256

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Nov 28

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5605188855136256 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment