New issue
Advanced search Search tips

Issue 908289 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Folders shared from Drive to crostini are not remounted if DriveFS remounts

Project Member Reported by sa...@chromium.org, Nov 26

Issue description

Chrome Version: 72.0.3618.0
OS: Chrome

What steps will reproduce the problem?
(1) Share a folder from Drive with Linux
(2) Turn drive off and on again from settings
(3) Try to access shared folders from crostini

What is the expected result?
Folders are accessible


What happens instead?
Transport endpoint is not connected

Attempting to share further folders from Drive has no effect.
 
Cc: slangley@chromium.org dgreid@chromium.org
Owner: tbuck...@chromium.org
Assigned to Tom to prioritize.

Currently this situation is resolved by restarting the VM.
Components: OS>Systems>Containers
Does this happen if the network temporarily disconnects as well? (i.e. switch wifi network or tethering etc)?
No, it should only occur if DriveFS restarts or crashes (and is relaunched).
Cc: rohi...@chromium.org tbuck...@chromium.org joelhockey@chromium.org
 Issue 908604  has been merged into this issue.
Labels: Crostini-Test
This is a good candidate for an automated test.
Owner: joelhockey@chromium.org
I don't think people frequently turn Drive on/off, so I'd make this low priority.

In this case, I'd actually expect the folder to disappear from Linux when Drive is disabled. When it is re-enabled, I would not expect it to be automatically shared.
Labels: -Pri-2 -M-72 Pri-3
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/73834eacaff2258c1baf45e4827a583a95dd7ba1

commit 73834eacaff2258c1baf45e4827a583a95dd7ba1
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Dec 18 08:43:02 2018

vm_tools: seneschal: mount as slave

Use minijail '-Kslave' to propogate any mounts that occur
after the container starts (such as drivefs,
removable media, android).

BUG= chromium:908289 
TEST=Test with FilesApp on device

Change-Id: Idef83b27ae5b37bf0e520fc108080dd271c5247e
Reviewed-on: https://chromium-review.googlesource.com/1381313
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/73834eacaff2258c1baf45e4827a583a95dd7ba1/vm_tools/init/seneschal.conf

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d106e0062290f58e6dda11260cbce6ef8c2062a

commit 9d106e0062290f58e6dda11260cbce6ef8c2062a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Dec 18 09:03:09 2018

Add CrostiniSharePath to observe volume mount events to auto reshare

Automatically share and unshare persisted shared folders when the
relevant volume is mounted or unmounted.  For example, when a removable
USB is added and removed, it will automatically be shared and unshared
with the VM if it is set as a persistent share.

Bug:  908289 
Change-Id: I77435b8be227959669c741b3f6e3c79ccf6c62b5
Reviewed-on: https://chromium-review.googlesource.com/c/1381359
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617421}
[modify] https://crrev.com/9d106e0062290f58e6dda11260cbce6ef8c2062a/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/9d106e0062290f58e6dda11260cbce6ef8c2062a/chrome/browser/chromeos/crostini/crostini_share_path.h
[modify] https://crrev.com/9d106e0062290f58e6dda11260cbce6ef8c2062a/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/9d106e0062290f58e6dda11260cbce6ef8c2062a/chrome/browser/chromeos/file_manager/volume_manager_observer.h

Status: Fixed (was: Assigned)

Sign in to add a comment