Styles drawer - setting the value to calc(- -) collapses the rest of the declaration in the rule |
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Steps to reproduce the problem: 1. Press F12. 2. In the Styles drawer, pick a rule that has a few declarations and click on the value of the first declaration in order to edit it. 3. Set it to calc(- -) What is the expected behavior? An invalid value triangle and nothing more, really. What went wrong? Havoc. The rest of the declarations in that rule are joined to a single declaration, removing any ; between them. :( Did this work before? N/A Chrome version: 70.0.3538.102 Channel: n/a OS Version: 10.0 Flash Version:
,
Nov 29
,
Nov 29
Filed upstream in CodeMirror as https://github.com/codemirror/CodeMirror/issues/5686
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975 commit 8fe6cbf5977fb9b18b1265284c40aa9e12b5c975 Author: Joel Einbinder <einbinder@chromium.org> Date: Sat Dec 01 01:07:41 2018 DevTools: Roll CodeMirror to 5.42.1 Bug: 908243 Change-Id: Ic049c51f0c631699a2117a4f3e275e4d51e8d91c Reviewed-on: https://chromium-review.googlesource.com/c/1357545 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#612884} [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm/codemirror.css [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm/codemirror.js [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm/matchbrackets.js [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm_modes/clike.js [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm_modes/clojure.js [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm_modes/markdown.js [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm_modes/python.js [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm_modes/shell.js [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm_web_modes/css.js [modify] https://crrev.com/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975/third_party/blink/renderer/devtools/front_end/cm_web_modes/javascript.js
,
Dec 3
Tried checking the issue on chrome version 70.0.3538.102 using Windows 10 with the steps mentioned in comment#0. When clicked on a value in order to edit it and typed calc(- -) In the reported version itself we were able to see an invalid value triangle. @Joel Einbinder: As we could not reproduce the issue on reported chrome version, could you please let us know if we have missed anything here and requesting you to help us in verifying the fix. Thanks!
,
Dec 3
#5 - you did reproduce the issue. See the second struck-through line? margin-right: auto margin-top: 10px min-width: calc(...) width: 60% That is the issue, you did not type those. They were separate lines - margin-right: auto; margin-top: 10px; min-width: calc(...); width: 60%; But they were changed to be a single invalid line instead.
,
Dec 3
It looks fixed to me in chrome 73 after the CodeMirror role.
,
Dec 4
Not fixed. :( I tried Chrome canary 73.0.3630.0 which should have it according to https://chromiumdash.appspot.com/commit/8fe6cbf5977fb9b18b1265284c40aa9e12b5c975 calc(--) as well as calc(- -) (dash-space-dash) still trigger the issue. body { margin: calc(--); background-attachment: fixed !important cursor: default display: none font-family: arial, sans-serif font-size: small margin: 0 min-height: 100%; } body { margin: calc(- -); background-attachment: fixed !important cursor: default display: none font-family: arial, sans-serif font-size: small margin: 0 min-height: 100%; } |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by phistuck@chromium.org
, Nov 25Status: Untriaged (was: Unconfirmed)