New issue
Advanced search Search tips

Issue 908187 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 30
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Flaky-Test: external/wpt/event-timing/event-timing-retrievability.html



Sign in to add a comment

external/wpt/event-timing/event-timing-retrievability.html is flaky

Project Member Reported by Findit, Nov 24

Issue description


Flaky test: external/wpt/event-timing/event-timing-retrievability.html
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/75936
Test output log: https://chromium-swarm.appspot.com/task?id=415bbb6f51ed4f10
Culprit (100.0% confidence): r610669
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKOAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzc1OTM2L3dlYmtpdF9sYXlvdXRfdGVzdHMvWlhoMFpYSnVZV3d2ZDNCMEwyVjJaVzUwTFhScGJXbHVaeTlsZG1WdWRDMTBhVzFwYm1jdGNtVjBjbWxsZG1GaWFXeHBkSGt1YUhSdGJBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20external/wpt/event-timing/event-timing-retrievability.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKOAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzc1OTM2L3dlYmtpdF9sYXlvdXRfdGVzdHMvWlhoMFpYSnVZV3d2ZDNCMEwyVjJaVzUwTFhScGJXbHVaeTlsZG1WdWRDMTBhVzFwYm1jdGNtVjBjbWxsZG1GaWFXeHBkSGt1YUhSdGJBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94

commit a62a5cd9f3af72f8033bf2c055f2f01030e0fb94
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Nov 24 00:05:00 2018

Revert "Move EventTiming tests to WPT"

This reverts commit a97f76cd07db5041ec7a3665e37c228b1e92f8a0.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 610669 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTk3Zjc2Y2QwN2RiNTA0MWVjN2EzNjY1ZTM3YzIyOGIxZTkyZjhhMAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/75936

Sample Failed Step: webkit_layout_tests

Sample Flaky Test: external/wpt/event-timing/event-timing-retrievability.html

Original change's description:
> Move EventTiming tests to WPT
> 
> This CL moves the tests in http/tests/event-timing to external/wpt/event-timing.
> The slow image is change from php based to python based. The click is now
> handled by test driver. and setTimeout is replaced with step_timeout.
> 
> Bug: 841224
> Change-Id: I035c087550a2d9a67cda1aed88553c16967d04b6
> Reviewed-on: https://chromium-review.googlesource.com/c/1349451
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610669}

Change-Id: Ia7d9f24fd9866fde7fed255b6b7554e44e4a39ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 841224,  908187 
Reviewed-on: https://chromium-review.googlesource.com/c/1349500
Cr-Commit-Position: refs/heads/master@{#610689}
[modify] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/MSANExpectations
[modify] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/d5f2cc2677dd64428379b88249cf2fbe9569c647/third_party/WebKit/LayoutTests/external/wpt/event-timing/resources/slow-image.py
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-bufferbeforeonload.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-crossiframe.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observer-manual.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observethenonload.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-only-observe-firstInput.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-retrievability.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-timingconditions.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-observer-manual-childframe.html
[rename] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js
[add] https://crrev.com/a62a5cd9f3af72f8033bf2c055f2f01030e0fb94/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/slow-image.php

Labels: -Pri-1 -Sheriff-Chromium Pri-2
Owner: npm@chromium.org
Status: Assigned (was: Untriaged)
Was reverted.
 Issue 908189  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d

commit 7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Nov 27 14:38:31 2018

Prepare to move EventTiming tests to WPT

This CL does most of the changes needed to move EventTiming tests to WPT. The CL
attempts to make the tests less flaky by ensuring the event handlers themselves
take a long time to execute.

Bug:  908187 ,  907948 ,  907949 
Change-Id: Iced25d635cb05c9903a209d43988ba4e71681195
Reviewed-on: https://chromium-review.googlesource.com/c/1351600
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611099}
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-bufferbeforeonload.html
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-crossiframe.html
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-observethenonload.html
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-onloadthenobserve.html
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-only-observe-firstInput.html
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-retrievability.html
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-timingconditions.html
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html
[modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/resources/event-timing-support.js

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f5f9c29d24b1a83e226a49f446575ffb372512e

commit 6f5f9c29d24b1a83e226a49f446575ffb372512e
Author: Nicolas Pena <npm@chromium.org>
Date: Thu Nov 29 15:59:00 2018

Move EventTiming tests to WPT Try 3

This CL moves the tests in http/tests/event-timing to external/wpt/event-timing.
The slow image is change from php based to python based. The click is now
handled by test driver. and setTimeout is replaced with step_timeout.

Bug: 841224,  908187 ,  907948 ,  907949 
Change-Id: Ia6359878666cfb96645aa3b7cd7736ce9df97683
Reviewed-on: https://chromium-review.googlesource.com/c/1352617
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612214}
[modify] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/MSANExpectations
[modify] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/SlowTests
[modify] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/TestExpectations
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-bufferbeforeonload.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-crossiframe.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-observer-manual.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-observethenonload.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve-firstInput.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-only-observe-firstInput.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-retrievability.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-timingconditions.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-crossiframe-childframe.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-observer-manual-childframe.html
[rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-support.js
[add] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/slow-image.py
[delete] https://crrev.com/7d81ddd9a1d0364772b0f423ab2fc8ad8c1c0187/third_party/blink/web_tests/http/tests/event-timing/resources/slow-image.php

Status: Fixed (was: Assigned)

Sign in to add a comment