Flaky test: external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26746 Test output log: https://chromium-swarm.appspot.com/task?id=415b865d0a310510 Culprit (100.0% confidence): r610667 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKrAWNocm9taXVtLndlYmtpdC9XZWJLaXQgTGludXggVHJ1c3R5IExlYWsvMjY3NDYvd2Via2l0X2xheW91dF90ZXN0cy9aWGgwWlhKdVlXd3ZkM0IwTDNKbGMyOTFjbU5sTFhScGJXbHVaeTlpZFdabVpYSXRablZzYkMxemRHOXlaUzFoYm1RdFkyeGxZWEl0WkhWeWFXNW5MV05oYkd4aVlXTnJMbWgwYld3PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKrAWNocm9taXVtLndlYmtpdC9XZWJLaXQgTGludXggVHJ1c3R5IExlYWsvMjY3NDYvd2Via2l0X2xheW91dF90ZXN0cy9aWGgwWlhKdVlXd3ZkM0IwTDNKbGMyOTFjbU5sTFhScGJXbHVaeTlpZFdabVpYSXRablZzYkMxemRHOXlaUzFoYm1RdFkyeGxZWEl0WkhWeWFXNW5MV05oYkd4aVlXTnJMbWgwYld3PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e821a78897cd1636f99520bb8629c8ef3aaafd7 commit 6e821a78897cd1636f99520bb8629c8ef3aaafd7 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Nov 23 22:52:27 2018 Revert "Align resource timing buffer full processing to spec PR 168" This reverts commit 579d65014c9d6cc248ec1de47013bf6c20c72158. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 610667 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTc5ZDY1MDE0YzlkNmNjMjQ4ZWMxZGU0NzAxM2JmNmMyMGM3MjE1OAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26746 Sample Failed Step: webkit_layout_tests Sample Flaky Test: external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html Original change's description: > Align resource timing buffer full processing to spec PR 168 > > This change implements the processing model from PR 168[1], when > it comes to setResourceTimingBufferSize(), clearResourceTimings() > and the firing of the resourcetimingbufferfull event. > > [1] https://github.com/w3c/resource-timing/pull/168 > > Change-Id: I3a57196f10e0b4cf2bae5662b0e075673a0c2d80 > Reviewed-on: https://chromium-review.googlesource.com/c/1345269 > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Commit-Queue: Yoav Weiss <yoav@yoav.ws> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610667} Change-Id: I0840bd9b763030b6e200e8f9a94c73c7982044a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908181 Reviewed-on: https://chromium-review.googlesource.com/c/1349498 Cr-Commit-Position: refs/heads/master@{#610683} [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-add-after-full-event.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-add-entries-during-callback-that-drop.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-add-entries-during-callback.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-add-then-clear.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-decrease-buffer-during-callback.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-increase-buffer-during-callback.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-inspect-buffer-during-callback.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-set-to-current-buffer.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-then-increased.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/buffer-full-when-populate-entries.html [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_timing_buffer_full_when_populate_entries.html [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_timing_buffer_full_when_shrink_buffer_size-expected.txt [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_timing_store_and_clear_during_callback-expected.txt [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_timing_store_and_clear_during_callback.html [delete] https://crrev.com/8bc2e0de111915687cd99980d1a9d9057b41b00d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resources/append.js [modify] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/performance-timeline-worker.js [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/http/tests/misc/cache-hit-resource-timing-buffer-full-crash-expected.txt [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/http/tests/misc/cache-hit-resource-timing-buffer-full-crash.html [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/http/tests/misc/finish-load-resource-timing-buffer-full-crash-expected.txt [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/http/tests/misc/finish-load-resource-timing-buffer-full-crash.html [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash-expected.txt [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash.html [add] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html [modify] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/http/tests/performance-timing/resource_timing_buffer_full_250.html [modify] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/WebKit/LayoutTests/http/tests/workers/resources/performance-timeline-worker.js [modify] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/blink/renderer/core/timing/performance.cc [modify] https://crrev.com/6e821a78897cd1636f99520bb8629c8ef3aaafd7/third_party/blink/renderer/core/timing/performance.h
FindIt reverted this one.
Yeah, unflaking it now
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dd060768d1c1183e0d29e422a2213f106d98299 commit 6dd060768d1c1183e0d29e422a2213f106d98299 Author: Yoav Weiss <yoavweiss@chromium.org> Date: Tue Nov 27 17:40:34 2018 Align resource timing buffer full processing to spec PR 168 (reland) This change implements the processing model from PR 168[1], when it comes to setResourceTimingBufferSize(), clearResourceTimings() and the firing of the resourcetimingbufferfull event. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1345269 (but with nicer tests). [1] https://github.com/w3c/resource-timing/pull/168 Change-Id: I10431bfda7f79b484c7ee5c608bb8a360d905339 Bug: 908181 , 908414 Reviewed-on: https://chromium-review.googlesource.com/c/1350950 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#611174} [modify] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/renderer/core/timing/performance.cc [modify] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/renderer/core/timing/performance.h [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-after-full-event.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-entries-during-callback-that-drop.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-entries-during-callback.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-then-clear.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-decrease-buffer-during-callback.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-increase-buffer-during-callback.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-inspect-buffer-during-callback.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-set-to-current-buffer.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-then-increased.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-when-populate-entries.html [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_buffer_full_when_populate_entries.html [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_buffer_full_when_shrink_buffer_size-expected.txt [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_store_and_clear_during_callback-expected.txt [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_store_and_clear_during_callback.html [add] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/resource-timing/resources/buffer-full-utilities.js [modify] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/performance-timeline-worker.js [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/http/tests/misc/cache-hit-resource-timing-buffer-full-crash-expected.txt [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/http/tests/misc/cache-hit-resource-timing-buffer-full-crash.html [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/http/tests/misc/finish-load-resource-timing-buffer-full-crash-expected.txt [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/http/tests/misc/finish-load-resource-timing-buffer-full-crash.html [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash-expected.txt [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash.html [delete] https://crrev.com/b372dc01e6b988abf97d951a7ef4da8e1d6825d2/third_party/blink/web_tests/http/tests/misc/webtiming-buffer-full-no-event.html [modify] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/http/tests/performance-timing/resource_timing_buffer_full_250.html [modify] https://crrev.com/6dd060768d1c1183e0d29e422a2213f106d98299/third_party/blink/web_tests/http/tests/workers/resources/performance-timeline-worker.js
Should be fixed now.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1185fcb981b2317bdc707990b28a065be2ddb38 commit a1185fcb981b2317bdc707990b28a065be2ddb38 Author: Ned Nguyen <nednguyen@google.com> Date: Wed Nov 28 16:17:44 2018 Revert "Align resource timing buffer full processing to spec PR 168 (reland)" This reverts commit 6dd060768d1c1183e0d29e422a2213f106d98299. Reason for revert: suspect causing WebRtcDisableEncryptionFlagBrowserTest.VerifyEncryption to be flaky (FindIt's report) BUG: chromium:909704 Original change's description: > Align resource timing buffer full processing to spec PR 168 (reland) > > This change implements the processing model from PR 168[1], when > it comes to setResourceTimingBufferSize(), clearResourceTimings() > and the firing of the resourcetimingbufferfull event. > > This is a reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1345269 > (but with nicer tests). > > [1] https://github.com/w3c/resource-timing/pull/168 > > Change-Id: I10431bfda7f79b484c7ee5c608bb8a360d905339 > Bug: 908181 , 908414 > Reviewed-on: https://chromium-review.googlesource.com/c/1350950 > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611174} TBR=npm@chromium.org,yoavweiss@chromium.org Change-Id: Ia4bf26c6be1e7c4ae35b904bac25fe031f854604 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908181 , 908414 Reviewed-on: https://chromium-review.googlesource.com/c/1354123 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#611722} [modify] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/renderer/core/timing/performance.cc [modify] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/renderer/core/timing/performance.h [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-after-full-event.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-entries-during-callback-that-drop.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-entries-during-callback.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-then-clear.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-decrease-buffer-during-callback.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-increase-buffer-during-callback.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-inspect-buffer-during-callback.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-set-to-current-buffer.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-then-increased.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-when-populate-entries.html [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_buffer_full_when_populate_entries.html [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_buffer_full_when_shrink_buffer_size-expected.txt [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_store_and_clear_during_callback-expected.txt [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_store_and_clear_during_callback.html [delete] https://crrev.com/617a8563d6b9a1bee6113d8ba35e4806f99593ac/third_party/blink/web_tests/external/wpt/resource-timing/resources/buffer-full-utilities.js [modify] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/performance-timeline-worker.js [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/http/tests/misc/cache-hit-resource-timing-buffer-full-crash-expected.txt [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/http/tests/misc/cache-hit-resource-timing-buffer-full-crash.html [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/http/tests/misc/finish-load-resource-timing-buffer-full-crash-expected.txt [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/http/tests/misc/finish-load-resource-timing-buffer-full-crash.html [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash-expected.txt [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash.html [add] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/http/tests/misc/webtiming-buffer-full-no-event.html [modify] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/http/tests/performance-timing/resource_timing_buffer_full_250.html [modify] https://crrev.com/a1185fcb981b2317bdc707990b28a065be2ddb38/third_party/blink/web_tests/http/tests/workers/resources/performance-timeline-worker.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/618e62b560677a64de2447211d0e2b96f3dee783 commit 618e62b560677a64de2447211d0e2b96f3dee783 Author: Yoav Weiss <yoavweiss@chromium.org> Date: Wed Dec 12 17:04:56 2018 Align resource timing buffer full processing to spec PR 168 (take 3) This change implements the processing model from PR 168[1], when it comes to setResourceTimingBufferSize(), clearResourceTimings() and the firing of the resourcetimingbufferfull event. This is a reland of [2] which is a reland of [3] (but with nicer tests). [1] https://github.com/w3c/resource-timing/pull/168 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1350950 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1345269 Bug: 908181 , 908414 Change-Id: I3a6c6e9d6a9aa5b5f907d1e86bec701ff2fa022d Reviewed-on: https://chromium-review.googlesource.com/c/1373819 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#615929} [modify] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/renderer/core/timing/performance.cc [modify] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/renderer/core/timing/performance.h [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-after-full-event.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-entries-during-callback-that-drop.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-entries-during-callback.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-add-then-clear.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-decrease-buffer-during-callback.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-increase-buffer-during-callback.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-inspect-buffer-during-callback.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-set-to-current-buffer.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-then-increased.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/buffer-full-when-populate-entries.html [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_buffer_full_when_populate_entries.html [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_buffer_full_when_shrink_buffer_size-expected.txt [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_store_and_clear_during_callback-expected.txt [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/external/wpt/resource-timing/resource_timing_store_and_clear_during_callback.html [add] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/resource-timing/resources/buffer-full-utilities.js [modify] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/performance-timeline-worker.js [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/http/tests/misc/cache-hit-resource-timing-buffer-full-crash-expected.txt [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/http/tests/misc/cache-hit-resource-timing-buffer-full-crash.html [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/http/tests/misc/finish-load-resource-timing-buffer-full-crash-expected.txt [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/http/tests/misc/finish-load-resource-timing-buffer-full-crash.html [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash-expected.txt [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/http/tests/misc/stop-loading-on-resource-timing-buffer-full-crash.html [delete] https://crrev.com/ad3c758a491a0f08788acba07a859e66c42684b8/third_party/blink/web_tests/http/tests/misc/webtiming-buffer-full-no-event.html [modify] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/http/tests/performance-timing/resource_timing_buffer_full_250.html [modify] https://crrev.com/618e62b560677a64de2447211d0e2b96f3dee783/third_party/blink/web_tests/http/tests/workers/resources/performance-timeline-worker.js
Comment 1 by bugdroid1@chromium.org
, Nov 23